From Mark_Andrews@isc.org  Tue Oct 17 01:02:25 2006
Return-Path: <Mark_Andrews@isc.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 5AD7616A417
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 17 Oct 2006 01:02:25 +0000 (UTC)
	(envelope-from Mark_Andrews@isc.org)
Received: from mx.isc.org (mx.isc.org [204.152.184.167])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 1590B43D5A
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 17 Oct 2006 01:02:23 +0000 (GMT)
	(envelope-from Mark_Andrews@isc.org)
Received: from farside.isc.org (farside.isc.org [IPv6:2001:4f8:3:bb::5])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(Client CN "farside.isc.org", Issuer "ISC CA" (verified OK))
	by mx.isc.org (Postfix) with ESMTP id DAEB1114043
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 17 Oct 2006 01:02:23 +0000 (UTC)
	(envelope-from Mark_Andrews@isc.org)
Received: from bsdi.dv.isc.org (localhost.isc.org [IPv6:::1])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(Client did not present a certificate)
	by farside.isc.org (Postfix) with ESMTP id 551FAE6077
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 17 Oct 2006 01:02:23 +0000 (UTC)
	(envelope-from marka@isc.org)
Received: from bsdi.dv.isc.org (localhost.dv.isc.org [127.0.0.1])
	by bsdi.dv.isc.org (8.13.8/8.13.4) with ESMTP id k9H12Ipj057685
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 17 Oct 2006 11:02:18 +1000 (EST)
	(envelope-from marka@bsdi.dv.isc.org)
Received: (from marka@localhost)
	by bsdi.dv.isc.org (8.13.8/8.13.4/Submit) id k9H12HG7057568;
	Tue, 17 Oct 2006 11:02:17 +1000 (EST)
	(envelope-from marka)
Message-Id: <200610170102.k9H12HG7057568@bsdi.dv.isc.org>
Date: Tue, 17 Oct 2006 11:02:17 +1000 (EST)
From: Mark Andrews <Mark_Andrews@isc.org>
Reply-To: Mark Andrews <Mark_Andrews@isc.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: security/openssh-portable/files/patch-sshd.c unconditionally includes <gssapi.h>.
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         104481
>Category:       ports
>Synopsis:       security/openssh-portable/files/patch-sshd.c unconditionally includes <gssapi.h>.
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    mnag
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Oct 17 01:10:19 GMT 2006
>Closed-Date:    Fri Nov 10 13:12:24 GMT 2006
>Last-Modified:  Fri Nov 10 13:20:21 GMT 2006
>Originator:     Mark Andrews
>Release:        FreeBSD 4.11-STABLE i386
>Organization:
ISC
>Environment:
System: FreeBSD bsdi.dv.isc.org 4.11-STABLE FreeBSD 4.11-STABLE #29: Fri Sep 29 14:34:34 EST 2006 marka@bsdi.dv.isc.org:/usr/obj/usr/src/sys/BSDI i386


>Description:

	/usr/ports/security/openssh-portable/files/patch-sshd.c
	unconditionally includes <gssapi.h>.  This prevents the use
	of krb5 for gssapi support.  krb5's gssapi.h is <gssapi/gssapi.h>.

>How-To-Repeat:
	
	mv /usr/include/gssapi.h sideways, as 4.11's gssapi is
	broken beyound belief and this lets configure find the krb5
	implementation.  Then attempt to build with KRB5_HOME set
	to use the krb5 port.
	
	Note this does not currently build a working ssh.  I had
	to revert to openssh-gssapi-4.3.p2_1,1 as ssh was dropping
	core.  I'll send a additional pr once I have time to chase
	that one down.

>Fix:

	Remove the #include <gssapi.h> as it will be included via.

#ifdef GSSAPI
#include "ssh-gss.h"
#endif

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->mnag 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Tue Oct 17 01:10:29 UTC 2006 
Responsible-Changed-Why:  
Over to maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=104481 
State-Changed-From-To: open->closed 
State-Changed-By: mnag 
State-Changed-When: Fri Nov 10 13:12:20 UTC 2006 
State-Changed-Why:  
Committed. Thanks. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=104481 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/104481: commit references a PR
Date: Fri, 10 Nov 2006 13:12:00 +0000 (UTC)

 mnag        2006-11-10 13:11:49 UTC
 
   FreeBSD ports repository
 
   Modified files:
     security/openssh-portable Makefile distinfo 
     security/openssh-portable/files patch-sshd.c 
   Log:
   - Update to 4.5p1
   - patch-sshd.c unconditionally includes <gssapi.h>. Include "ssh-gss.h" instead. [1]
   
   PR:             104481 [1]
   Submitted by:   Mark Andrews <Mark_Andrews___isc.org> [1]
   
   Revision  Changes    Path
   1.115     +1 -2      ports/security/openssh-portable/Makefile
   1.39      +3 -3      ports/security/openssh-portable/distinfo
   1.3       +1 -1      ports/security/openssh-portable/files/patch-sshd.c
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
