From nobody@FreeBSD.org  Mon Oct 16 13:36:18 2006
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 9BFE716A527
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 16 Oct 2006 13:36:18 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id BDB2E43D9C
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 16 Oct 2006 13:34:30 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id k9GDYUmt068264
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 16 Oct 2006 13:34:30 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id k9GDYUPn068263;
	Mon, 16 Oct 2006 13:34:30 GMT
	(envelope-from nobody)
Message-Id: <200610161334.k9GDYUPn068263@www.freebsd.org>
Date: Mon, 16 Oct 2006 13:34:30 GMT
From: Andrey Alakozov<aa29@mail.ru>
To: freebsd-gnats-submit@FreeBSD.org
Subject: port www/apache13-mod_perl: stale RcNG script
X-Send-Pr-Version: www-3.0

>Number:         104465
>Category:       ports
>Synopsis:       port www/apache13-modperl: stale RcNG script
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    apache
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Mon Oct 16 13:40:18 GMT 2006
>Closed-Date:    Wed Mar 14 20:21:38 GMT 2007
>Last-Modified:  Wed Mar 14 20:30:02 GMT 2007
>Originator:     Andrey Alakozov
>Release:        FreeBSD 6.2-PRERELEASE #2
>Organization:
RKSI
>Environment:
FreeBSD aa29.local 6.2-PRERELEASE FreeBSD 6.2-PRERELEASE #2: Mon Oct  9 15:56:22 MSD 2006     aa29@aa29.local:/usr/obj/usr/src/sys/AA29BSD  i386

>Description:
Port www/apache13-mod_perl has RcNG script 'files/apache.sh' with following string

apache_flags=""

But then 'apache_flags' is set in /etc/rc.conf nothig happens, no flags are set  for httpd start.  

Similar port, www/apache13 (note: without mod_perl), has similar file 'apache.sh', but flags are set where by the other way:

apache_flags=${apache_flags-""}

With this line flags are set OK.

>How-To-Repeat:
1. Install port www/apache13-mod_perl

2. Add add to /etc/rc.conf

apache_enable="YES"
apache_flags="-v"

3. Reboot

4. Apache will start instead of showing version. 

>Fix:
Sync apache.sh with similar script in port www/apache.
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->apache 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Mon Oct 16 21:17:05 UTC 2006 
Responsible-Changed-Why:  
Over to maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=104465 

From: Volker <volker@vwsoft.com>
To: bug-followup@FreeBSD.org,  aa29@mail.ru
Cc:  
Subject: Re: ports/104465: port www/apache13-modperl: stale RcNG script
Date: Thu, 01 Mar 2007 19:21:59 +0100

 here's a patch to solve that PR:
 
 --- apache.sh.orig      Thu Mar  1 19:02:35 2007
 +++ apache.sh   Thu Mar  1 19:04:58 2007
 @@ -14,8 +14,8 @@
  # DO NOT CHANGE THESE DEFAULT VALUES HERE
  #
  apache_enable="${apache_enable-NO}"
 -apache_flags=""
 -apache_pidfile="/var/run/httpd.pid"
 +apache_flags="${apache_flags=''}"
 +apache_pidfile="${apache_pidfile='/var/run/httpd.pid'}"
 
  . %%RC_SUBR%%
State-Changed-From-To: open->closed 
State-Changed-By: pav 
State-Changed-When: Wed Mar 14 19:55:57 UTC 2007 
State-Changed-Why:  
Fixed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=104465 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/104465: commit references a PR
Date: Wed, 14 Mar 2007 20:21:37 +0000 (UTC)

 pav         2007-03-14 20:21:31 UTC
 
   FreeBSD ports repository
 
   Modified files:
     www/apache13-modperl Makefile pkg-plist 
   Added files:
     www/apache13-modperl/files apache.in 
   Removed files:
     www/apache13-modperl/files apache.sh 
   Log:
   - Fix rc script to have overridable apache_flags and apache_pidfile
   
   PR:             ports/104465
   Reported by:    Andrey Alakozov <aa29@mail.ru>
   Submitted by:   Volker <volker@vwsoft.com>
   Approved by:    maintainer timeout (apache; 5 months)
   
   - While here, modernize USE_RC_SUBR usage
   
   Revision  Changes    Path
   1.18      +2 -8      ports/www/apache13-modperl/Makefile
   1.1       +32 -0     ports/www/apache13-modperl/files/apache.in (new)
   1.4       +0 -32     ports/www/apache13-modperl/files/apache.sh (dead)
   1.7       +0 -1      ports/www/apache13-modperl/pkg-plist
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
