From nobody@FreeBSD.org  Tue Oct  3 14:15:42 2006
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 01E9C16A494
	for <freebsd-gnats-submit@FreeBSD.org>; Tue,  3 Oct 2006 14:15:42 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id ADB8D43D55
	for <freebsd-gnats-submit@FreeBSD.org>; Tue,  3 Oct 2006 14:15:40 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id k93EFbig088927
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 3 Oct 2006 14:15:37 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id k93EFbWf088926;
	Tue, 3 Oct 2006 14:15:37 GMT
	(envelope-from nobody)
Message-Id: <200610031415.k93EFbWf088926@www.freebsd.org>
Date: Tue, 3 Oct 2006 14:15:37 GMT
From: Fabian Wenk <fabian@wenks.ch>
To: freebsd-gnats-submit@FreeBSD.org
Subject: /usr/local/etc/rc.d/arpwatch.sh start only for one interface (patch attached)
X-Send-Pr-Version: www-2.3

>Number:         103941
>Category:       ports
>Synopsis:       /usr/local/etc/rc.d/arpwatch.sh start only for one interface (patch attached)
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    clsung
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Oct 03 14:20:25 GMT 2006
>Closed-Date:    Wed Oct 04 00:59:08 GMT 2006
>Last-Modified:  Wed Oct  4 01:00:34 GMT 2006
>Originator:     Fabian Wenk
>Release:        5.4-RELEASE
>Organization:
>Environment:
FreeBSD superman.wenks.ch 5.4-RELEASE-p20 FreeBSD 5.4-RELEASE-p20 #23: Thu Sep 28 23:15:14 CEST 2006     root@superman.wenks.ch:/usr/obj/usr/src/sys/SUPERMAN  i386
>Description:
Did a portupgrade from arpwatch-2.1.a15 to arpwatch-2.1.a15_2 and afterwards with the a manual restart of arpwatch I got this:

root@superman:~# /usr/local/etc/rc.d/arpwatch.sh restart
Stopping arpwatch.
Waiting for PIDS: 587 590 593.
Starting arpwatch.
arpwatch already running? (pid=44695).
root@superman:~#

root@superman:~# ps auxwww|grep arpwatch
root  44695  3.7  1.0  3172  2476  p1  S     3:49PM   0:00.20 /usr/local/sbin/arpwatch -i dc0 -f arp.dc0.dat
root@superman:~#

I have the following in my /etc/rc.conf:
arpwatch_enable="YES"
arpwatch_dir="/usr/local/arpwatch/"
arpwatch_interfaces="dc0 de0 rl0"

>How-To-Repeat:
Restart arpwatch with '/usr/local/etc/rc.d/arpwatch.sh restart' or '/usr/local/etc/rc.d/arpwatch.sh stop' and '/usr/local/etc/rc.d/arpwatch.sh start'
>Fix:
Did a diff to the old arpwatch.sh and created the following patch, now it is working again:

--- etc/rc.d/arpwatch.sh.orig   Tue Oct  3 15:48:38 2006
+++ etc/rc.d/arpwatch.sh        Tue Oct  3 15:57:03 2006
@@ -67,6 +67,7 @@
             for interface in ${arpwatch_interfaces}; do
                 eval options=\$arpwatch_${interface}_options
                 command_args="-i ${interface} ${options} -f arp.${interface}.dat"
+                pidfile="/var/run/arpwatch-${interface}.pid"
                 run_rc_command "$1"
             done
             ;;

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Tue Oct 3 22:58:05 UTC 2006 
State-Changed-Why:  
Awaiting maintainers feedback 

http://www.freebsd.org/cgi/query-pr.cgi?pr=103941 

From: "Thomas Abthorpe" <thomas@goodking.ca>
To: <bug-followup@FreeBSD.org>, <fabian@wenks.ch>
Cc:  
Subject: Re: ports/103941: /usr/local/etc/rc.d/arpwatch.sh start only for one interface (patch attached)
Date: Tue, 3 Oct 2006 20:17:14 -0400

 I concur with this patch, please commit.
 
 Thomas
Responsible-Changed-From-To: freebsd-ports-bugs->clsung 
Responsible-Changed-By: clsung 
Responsible-Changed-When: Wed Oct 4 00:50:26 UTC 2006 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=103941 
State-Changed-From-To: feedback->closed 
State-Changed-By: clsung 
State-Changed-When: Wed Oct 4 00:59:06 UTC 2006 
State-Changed-Why:  
Committed. Thank You. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=103941 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/103941: commit references a PR
Date: Wed,  4 Oct 2006 00:59:02 +0000 (UTC)

 clsung      2006-10-04 00:58:55 UTC
 
   FreeBSD ports repository
 
   Modified files:
     net-mgmt/arpwatch    Makefile 
     net-mgmt/arpwatch/files arpwatch.sh.in 
   Log:
   - make arpwatch work fine with multiple interfaces.
   - bump PORTREVISION
   
   PR:             103941
   Submitted by:   Fabian Wenk <fabian_AT_wenks dot ch>
   Approved by:    maintainer (Thomas Abthorpe)
   
   Revision  Changes    Path
   1.47      +1 -1      ports/net-mgmt/arpwatch/Makefile
   1.7       +2 -1      ports/net-mgmt/arpwatch/files/arpwatch.sh.in
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
