From torfinn.ingolfsen@broadpark.no  Sun Oct  1 16:09:41 2006
Return-Path: <torfinn.ingolfsen@broadpark.no>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 4D65216A403
	for <FreeBSD-gnats-submit@freebsd.org>; Sun,  1 Oct 2006 16:09:41 +0000 (UTC)
	(envelope-from torfinn.ingolfsen@broadpark.no)
Received: from osl1smout1.broadpark.no (osl1smout1.broadpark.no [80.202.4.58])
	by mx1.FreeBSD.org (Postfix) with ESMTP id D61E143D45
	for <FreeBSD-gnats-submit@freebsd.org>; Sun,  1 Oct 2006 16:09:40 +0000 (GMT)
	(envelope-from torfinn.ingolfsen@broadpark.no)
Received: from osl1sminn1.broadpark.no ([80.202.4.59])
 by osl1smout1.broadpark.no
 (Sun Java System Messaging Server 6.1 HotFix 0.05 (built Oct 21 2004))
 with ESMTP id <0J6G00GE3SW3JB50@osl1smout1.broadpark.no> for
 FreeBSD-gnats-submit@freebsd.org; Sun, 01 Oct 2006 18:09:39 +0200 (CEST)
Received: from kg-work.kg4.no ([80.203.21.224]) by osl1sminn1.broadpark.no
 (Sun Java System Messaging Server 6.1 HotFix 0.05 (built Oct 21 2004))
 with ESMTP id <0J6G009GLSW3PX40@osl1sminn1.broadpark.no> for
 FreeBSD-gnats-submit@freebsd.org; Sun, 01 Oct 2006 18:09:39 +0200 (CEST)
Message-Id: <1159718979.33134@kg-work.kg4.no>
Date: Sun, 01 Oct 2006 18:09:39 +0200
From: Torfinn Ingolfsen <torfinn.ingolfsen@broadpark.no>
To: FreeBSD gnats submit <FreeBSD-gnats-submit@freebsd.org>
Subject: sysutils/bsdstats adds items to /etc/periodic.conf even if the items
 exist in that file already
X-Send-Pr-Version: gtk-send-pr 0.4.7
X-GNATS-Notify:

>Number:         103870
>Category:       ports
>Synopsis:       sysutils/bsdstats adds items to /etc/periodic.conf even if the items exist in that file already
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    scrappy
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Oct 01 16:10:19 GMT 2006
>Closed-Date:    Mon Oct 23 13:05:56 GMT 2006
>Last-Modified:  Mon Oct 23 13:05:56 GMT 2006
>Originator:     Torfinn Ingolfsen
>Release:        FreeBSD 5.5-STABLE i386
>Organization:
LNSF 
>Environment:


System: FreeBSD 5.5-STABLE #9: Tue Aug 22 17:26:30 CEST 2006
    root@kg-work.kg4.no:/usr/obj/usr/src/sys/SS51G

bsdstats version 3.9 and 4.2 at least (probably others too).


>Description:


When you install (or upgrade) the bsdstats port, you are asked if you wnat to add flags to /etc/periodic.conf
(the flags in question are monthly_statistics_enable="YES" and monthly_statistics_report_devices="YES")
If you answer yes to one of the questions, the corresponding flag is added to /etc/periodic.conf, WITHOUT checking if the flag exists in the file already. It doesn't harm, but it clutters the file uneccesarily.


>How-To-Repeat:


1) install bsdstats, answer yes to all questions.
2) upgrade bsdstats, nswer yes to all questions
(note the final quuestion (running bsdstats now) have no impact)


>Fix:


Change the install procedure so that it checks /etc/periodic.conf for existing flags, and only install flags if the user answers "yes" AND the flag doesn't already exist in the file.


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->scrappy 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Sun Oct 1 16:10:26 UTC 2006 
Responsible-Changed-Why:  
Over to maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=103870 
State-Changed-From-To: open->closed 
State-Changed-By: scrappy 
State-Changed-When: Mon Oct 23 13:05:41 UTC 2006 
State-Changed-Why:  

fixed 


http://www.freebsd.org/cgi/query-pr.cgi?pr=103870 
>Unformatted:
