From wblock@wonkity.com  Tue Sep 26 00:07:39 2006
Return-Path: <wblock@wonkity.com>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 22E5016A40F
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 26 Sep 2006 00:07:39 +0000 (UTC)
	(envelope-from wblock@wonkity.com)
Received: from wonkity.com (wonkity.com [67.158.26.137])
	by mx1.FreeBSD.org (Postfix) with ESMTP id B6AB043D55
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 26 Sep 2006 00:07:38 +0000 (GMT)
	(envelope-from wblock@wonkity.com)
Received: from speedy.wonkity.com (speedy [10.0.0.7])
	by wonkity.com (8.13.8/8.13.8) with ESMTP id k8Q07XZ5020989
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 25 Sep 2006 18:07:38 -0600 (MDT)
	(envelope-from wblock@speedy.wonkity.com)
Received: from speedy.wonkity.com (localhost [127.0.0.1])
	by speedy.wonkity.com (8.13.8/8.13.8) with ESMTP id k8Q07XM4010331
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 25 Sep 2006 18:07:33 -0600 (MDT)
	(envelope-from wblock@speedy.wonkity.com)
Received: (from wblock@localhost)
	by speedy.wonkity.com (8.13.8/8.13.8/Submit) id k8Q07X85010330;
	Mon, 25 Sep 2006 18:07:33 -0600 (MDT)
	(envelope-from wblock)
Message-Id: <200609260007.k8Q07X85010330@speedy.wonkity.com>
Date: Mon, 25 Sep 2006 18:07:33 -0600 (MDT)
From: Warren Block <wblock@wonkity.com>
Reply-To: Warren Block <wblock@wonkity.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [patch] Bug in p5-Number-Format
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         103653
>Category:       ports
>Synopsis:       [patch] Bug in p5-Number-Format
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    clsung
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Sep 26 00:10:14 GMT 2006
>Closed-Date:    Tue Sep 26 07:29:11 GMT 2006
>Last-Modified:  Tue Sep 26 14:10:26 GMT 2006
>Originator:     Warren Block
>Release:        FreeBSD 6.1-STABLE i386
>Organization:
>Environment:
System: FreeBSD speedy.wonkity.com 6.1-STABLE FreeBSD 6.1-STABLE #0: Wed Aug 30 19:06:32 MDT 2006 root@speedy.wonkity.com:/usr/obj/usr/src/sys/SPEEDY i386


	
>Description:
	An extra single-quoted space is present on line 647 of Format.pm, causing a syntax 
error when compiling the module.  The space is not present in the current version 1.52 of 
Format::Number on CPAN.  Maybe this bug was fixed after the port was updated to 1.52?
>How-To-Repeat:
	use Number::Format;
	syntax error at /usr/local/lib/perl5/site_perl/5.8.8/Number/Format.pm line 648, near "("
>Fix:
	The best fix would be to get the latest version of Format.pm from CPAN.  This patch
	fixes the only current difference, but other changes may happen.

--- /tmp/Format.pm	Mon Sep 25 17:50:02 2006
+++ /usr/local/lib/perl5/site_perl/5.8.8/Number/Format.pm	Mon Sep 25 17:50:10 2006
@@ -644,7 +644,7 @@
 
     # Combine it all back together and return it.
     $self->{int_curr_symbol} =~ s/\s*$/ /;
-    my $result = ($self->{int_curr_symbol} . ' '
+    my $result = ($self->{int_curr_symbol} .
                   ($precision ?
                    join($self->{mon_decimal_point}, $integer, $decimal) :
                    $integer));
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->clsung 
Responsible-Changed-By: clsung 
Responsible-Changed-When: Tue Sep 26 03:28:15 UTC 2006 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=103653 
State-Changed-From-To: open->closed 
State-Changed-By: clsung 
State-Changed-When: Tue Sep 26 07:28:29 UTC 2006 
State-Changed-Why:  
v 1.52 has updated recently, and the bug was fixed, too. Thank you. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=103653 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/103653: commit references a PR
Date: Tue, 26 Sep 2006 14:00:52 +0000 (UTC)

 clsung      2006-09-26 14:00:08 UTC
 
   FreeBSD ports repository
 
   Modified files:
     textproc/p5-Number-Format Makefile 
   Removed files:
     textproc/p5-Number-Format/files patch-Format.pm 
   Log:
   - the patch should be removed (tested via 'make test')
   - bump PORTREVISION
   
   PR:             ports/103653
   Submitted by:   Warren Block <wblock_AT_wonkity dot com>
   
   Revision  Changes    Path
   1.10      +2 -1      ports/textproc/p5-Number-Format/Makefile
   1.3       +0 -11     ports/textproc/p5-Number-Format/files/patch-Format.pm (dead)
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
