From nobody@FreeBSD.org  Mon Sep 18 14:23:31 2006
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 44B7B16A403
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 18 Sep 2006 14:23:31 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id A0FCA43D9C
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 18 Sep 2006 14:23:13 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id k8IENCsJ038819
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 18 Sep 2006 14:23:12 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id k8IENCgx038796;
	Mon, 18 Sep 2006 14:23:12 GMT
	(envelope-from nobody)
Message-Id: <200609181423.k8IENCgx038796@www.freebsd.org>
Date: Mon, 18 Sep 2006 14:23:12 GMT
From: Artem Naluzhny <tut@nhamon.com.ua>
To: freebsd-gnats-submit@FreeBSD.org
Subject: [patch] Broken FlickrExport plugin from graphics/kipi-plugins
X-Send-Pr-Version: www-2.3

>Number:         103355
>Category:       ports
>Synopsis:       [patch] Broken FlickrExport plugin from graphics/kipi-plugins
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    markus
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Mon Sep 18 14:30:16 GMT 2006
>Closed-Date:    Tue Oct 24 19:15:55 GMT 2006
>Last-Modified:  Tue Oct 24 19:20:19 GMT 2006
>Originator:     Artem Naluzhny
>Release:        6.2-PRERELEASE
>Organization:
>Environment:
FreeBSD tut.sweet.home 6.2-PRERELEASE FreeBSD 6.2-PRERELEASE #5: Sat Sep 16 04:00:32 EEST 2006     root@tut.sweet.home:/usr/obj/usr/src/sys/TUT  i386
>Description:
FlickrExport plugin from kipi-plugins-0.1.0.r1_4,1 (graphics/kipi-plugins) does not work: "missing signature" message on console.

This is known bug caused by Flickr API changes - http://bugs.kde.org/show_bug.cgi?id=132659

Suggested patch resolves the issue.
>How-To-Repeat:

>Fix:
--- kipi-plugins/flickrexport/flickrtalker.cpp.orig
+++ kipi-plugins/flickrexport/flickrtalker.cpp
@@ -277,7 +277,7 @@
 
 		QString isfriend=(info.is_friend==1)?"1":"0";
 		form.addPair("is_friend",isfriend);
-		headers.append("api_key="+ isfriend);
+		headers.append("is_friend="+ isfriend);
 
 		QString tags=info.tags.join(" ");
 		if(tags.length()>0){	
@@ -297,6 +297,7 @@
 		}
 
 		QString md5=getApiSig(m_secret,headers);
+		form.addPair("api_sig", md5);
 		headers.append("api_sig="+ md5);
 		QString queryStr=headers.join("&");
 		QString postUrl=url+queryStr;

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Mon Sep 18 14:30:44 UTC 2006 
State-Changed-Why:  
Awaiting maintainers feedback 

http://www.freebsd.org/cgi/query-pr.cgi?pr=103355 
Responsible-Changed-From-To: freebsd-ports-bugs->markus 
Responsible-Changed-By: markus 
Responsible-Changed-When: Tue Oct 24 13:01:54 UTC 2006 
Responsible-Changed-Why:  
I'll handle this one. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=103355 
State-Changed-From-To: feedback->closed 
State-Changed-By: markus 
State-Changed-When: Tue Oct 24 19:15:11 UTC 2006 
State-Changed-Why:  
Committed, thanks! 

The maintainer approved the patch via private mail. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=103355 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/103355: commit references a PR
Date: Tue, 24 Oct 2006 19:16:24 +0000 (UTC)

 markus      2006-10-24 19:14:51 UTC
 
   FreeBSD ports repository
 
   Modified files:
     graphics/kipi-plugins Makefile pkg-plist 
   Added files:
     graphics/kipi-plugins/files 
                                 patch-kipi-plugins-flickrexport-flickrtalker.cpp 
   Log:
   - Fix pkg-plist and unbreak
   - Fix Flickr export plugin [1]
   - Bump PORTREVISION
   
   PR:             ports/103355 [1]
   Submitted by:   Artem Naluzhny <tut@nhamon.com.ua> [1]
   Approved by:    portmgr (marcus), maintainer
   
   Revision  Changes    Path
   1.20      +1 -3      ports/graphics/kipi-plugins/Makefile
   1.1       +19 -0     ports/graphics/kipi-plugins/files/patch-kipi-plugins-flickrexport-flickrtalker.cpp (new)
   1.7       +17 -0     ports/graphics/kipi-plugins/pkg-plist
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
