From ijliao@FreeBSD.csie.nctu.edu.tw  Mon Sep  4 16:33:50 2006
Return-Path: <ijliao@FreeBSD.csie.nctu.edu.tw>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 601D416A4DF
	for <FreeBSD-gnats-submit@freebsd.org>; Mon,  4 Sep 2006 16:33:50 +0000 (UTC)
	(envelope-from ijliao@FreeBSD.csie.nctu.edu.tw)
Received: from FreeBSD.csie.nctu.edu.tw (freebsd.csie.nctu.edu.tw [140.113.17.209])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 0003943D45
	for <FreeBSD-gnats-submit@freebsd.org>; Mon,  4 Sep 2006 16:33:49 +0000 (GMT)
	(envelope-from ijliao@FreeBSD.csie.nctu.edu.tw)
Received: from localhost (localhost.csie.nctu.edu.tw [127.0.0.1])
	by FreeBSD.csie.nctu.edu.tw (Postfix) with ESMTP id 2CDEB7E96F;
	Tue,  5 Sep 2006 00:36:05 +0800 (CST)
Received: from FreeBSD.csie.nctu.edu.tw ([127.0.0.1])
	by localhost (FreeBSD.csie.nctu.edu.tw [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id Pc+M7KB2mjnX; Tue,  5 Sep 2006 00:36:04 +0800 (CST)
Received: by FreeBSD.csie.nctu.edu.tw (Postfix, from userid 1041)
	id 8CD837E9A6; Tue,  5 Sep 2006 00:36:04 +0800 (CST)
Message-Id: <20060904163604.8CD837E9A6@FreeBSD.csie.nctu.edu.tw>
Date: Tue,  5 Sep 2006 00:36:04 +0800 (CST)
From: Ying-Chieh Liao <ijliao@csie.nctu.edu.tw>
To: FreeBSD-gnats-submit@freebsd.org
Cc: jw@innerewut.de
Subject: [PATCH] devel/ruby18-gems: customize GEM_NAME in Makefile.common
X-Send-Pr-Version: 3.113
X-GNATS-Notify: jw@innerewut.de

>Number:         102855
>Category:       ports
>Synopsis:       [PATCH] devel/ruby18-gems: customize GEM_NAME in Makefile.common
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    ijliao
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Sep 04 16:40:18 GMT 2006
>Closed-Date:    Sat Sep 23 08:15:47 GMT 2006
>Last-Modified:  Sat Sep 23 08:20:14 GMT 2006
>Originator:     Ying-Chieh Liao
>Release:        FreeBSD 6.1-STABLE i386
>Organization:
FreeBSD @ Taiwan
>Environment:
System: FreeBSD FreeBSD.csie.nctu.edu.tw 6.1-STABLE FreeBSD 6.1-STABLE #9: Thu May 11 14:31:45 CST 2006
>Description:
[DESCRIBE CHANGES]
I think it's better let users/porters define GEM_NAME in their Makefile

Port maintainer (jw@innerewut.de) is cc'd.

Generated with FreeBSD Port Tools 0.77
>How-To-Repeat:
>Fix:

--- ruby18-gems-0.8.11.patch begins here ---
Index: Makefile.common
===================================================================
RCS file: /home/pcvs/ports/devel/ruby-gems/Makefile.common,v
retrieving revision 1.5
diff -u -u -r1.5 Makefile.common
--- Makefile.common	4 May 2006 21:41:06 -0000	1.5
+++ Makefile.common	4 Sep 2006 16:28:43 -0000
@@ -18,7 +18,7 @@
 DOC_DIR=	${GEMS_BASE_DIR}/doc
 CACHE_DIR=	${GEMS_BASE_DIR}/cache
 SPEC_DIR=	${GEMS_BASE_DIR}/specifications
-GEM_NAME=	${PORTNAME}-${PORTVERSION}
+GEM_NAME?=	${PORTNAME}-${PORTVERSION}
 GEM_LIB_DIR=	${GEMS_DIR}/${GEM_NAME}
 GEM_DOC_DIR=	${DOC_DIR}/${GEM_NAME}
 GEM_SPEC=	${SPEC_DIR}/${GEM_NAME}.gemspec
--- ruby18-gems-0.8.11.patch ends here ---

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Mon Sep 4 16:40:26 UTC 2006 
State-Changed-Why:  
Awaiting maintainers feedback 

http://www.freebsd.org/cgi/query-pr.cgi?pr=102855 

From: Jonathan Weiss <jw@innerewut.de>
To: bug-followup@FreeBSD.org,  ijliao@csie.nctu.edu.tw
Cc:  
Subject: Re: ports/102855: [PATCH] devel/ruby18-gems: customize GEM_NAME in
 Makefile.common
Date: Fri, 22 Sep 2006 20:57:27 +0100

 This patch is fine with me!
 
 Regards,
 Jonathan
 -- 
 Jonathan Weiss
 http://blog.innerewut.de
State-Changed-From-To: feedback->open 
State-Changed-By: linimon 
State-Changed-When: Fri Sep 22 20:50:30 UTC 2006 
State-Changed-Why:  
Maintainer approved. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=102855 
Responsible-Changed-From-To: freebsd-ports-bugs->ijliao 
Responsible-Changed-By: clsung 
Responsible-Changed-When: Sat Sep 23 03:00:17 UTC 2006 
Responsible-Changed-Why:  
Submitter has GNATS access. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=102855 
State-Changed-From-To: open->closed 
State-Changed-By: ijliao 
State-Changed-When: Sat Sep 23 08:15:36 UTC 2006 
State-Changed-Why:  
committed 

http://www.freebsd.org/cgi/query-pr.cgi?pr=102855 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/102855: commit references a PR
Date: Sat, 23 Sep 2006 08:15:32 +0000 (UTC)

 ijliao      2006-09-23 08:15:26 UTC
 
   FreeBSD ports repository
 
   Modified files:
     devel/ruby-gems      Makefile.common 
   Log:
   let users/porters define GEM_NAME in their Makefile
   
   PR:             102855
   Approved by:    maintainer
   
   Revision  Changes    Path
   1.6       +2 -2      ports/devel/ruby-gems/Makefile.common
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
