From michael@factory.findbook.tw  Tue Aug 29 14:15:23 2006
Return-Path: <michael@factory.findbook.tw>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 6A49A16A4DA
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 29 Aug 2006 14:15:23 +0000 (UTC)
	(envelope-from michael@factory.findbook.tw)
Received: from factory.findbook.tw (ecowork.com.tw [59.124.230.82])
	by mx1.FreeBSD.org (Postfix) with ESMTP id D187C43D46
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 29 Aug 2006 14:15:22 +0000 (GMT)
	(envelope-from michael@factory.findbook.tw)
Received: from factory.findbook.tw (localhost.ecowork.com.tw [127.0.0.1])
	by factory.findbook.tw (8.13.6/8.13.6) with ESMTP id k7TCB88E010302
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 29 Aug 2006 20:11:09 +0800 (CST)
	(envelope-from michael@factory.findbook.tw)
Received: (from root@localhost)
	by factory.findbook.tw (8.13.6/8.13.6/Submit) id k7TCB8rS010301;
	Tue, 29 Aug 2006 20:11:08 +0800 (CST)
	(envelope-from michael)
Message-Id: <200608291211.k7TCB8rS010301@factory.findbook.tw>
Date: Tue, 29 Aug 2006 20:11:08 +0800 (CST)
From: Yen-Shuo Su <shuoshuo+pr@gmail.com>
Reply-To: Yen-Shuo Su <shuoshuo+pr@gmail.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: devel/p5-Decision-ACL: fix wrong decision when using zero as field value
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         102644
>Category:       ports
>Synopsis:       devel/p5-Decision-ACL: fix wrong decision when using zero as field value
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Aug 29 14:20:23 GMT 2006
>Closed-Date:    Mon May 19 05:03:45 UTC 2008
>Last-Modified:  Mon May 19 05:03:45 UTC 2008
>Originator:     Yen-Shuo Su
>Release:        FreeBSD 6.1-STABLE i386
>Organization:
Ecowork Inc.
>Environment:
	6.1-STABLE FreeBSD 6.1-STABLE #0: Sat Jun 10 03:53:35 CST 2006
>Description:
	This perl module will return wrong decision when using zero as field value
>How-To-Repeat:
	use zero as rule value or field value
>Fix:

files/patch-ACL.pm:


*** ACL.pm	Sat Jul 28 09:18:58 2001
--- ACL.pm	Fri Jul 28 17:32:18 2006
***************
*** 132,138 ****
  
  	foreach my $control_field (@{ $self->ControlFields() })	
  	{
! 		next if $args->{$control_field};
  		croak "Cannot run ACL, missing control field in arguments to RunACL() ($control_field)\n";
  	}
  	return 1;
--- 132,138 ----
  
  	foreach my $control_field (@{ $self->ControlFields() })	
  	{
! 		next if defined($args->{$control_field});
  		croak "Cannot run ACL, missing control field in arguments to RunACL() ($control_field)\n";
  	}
  	return 1;


files/patch-ACL-Rules.pm:


*** ACL/Rule.pm	Tue Jul 10 02:06:13 2001
--- ACL/Rule.pm	Tue Aug 29 20:05:40 2006
***************
*** 120,130 ****
  		print STDERR "$field control (".$field_value.")->" if $self->DEBUG_LEVEL();;
  	
  		return ACL_RULE_UNCONCERNED if(
! 						$field_value ne $args->{$field}
! 						&& $field_value
  						&& $field_value ne 'ALL'
  						&& $args->{$field} ne 'ALL'
! 						&& $args->{$field});
  		print STDERR " 1\n" if $self->DEBUG_LEVEL();;
  	}
  
--- 120,130 ----
  		print STDERR "$field control (".$field_value.")->" if $self->DEBUG_LEVEL();;
  	
  		return ACL_RULE_UNCONCERNED if(
! 						defined($field_value)
  						&& $field_value ne 'ALL'
+ 						&& defined($args->{$field});
  						&& $args->{$field} ne 'ALL'
! 						&& $field_value ne $args->{$field});
  		print STDERR " 1\n" if $self->DEBUG_LEVEL();;
  	}
  
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->aaron 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Tue Aug 29 14:20:43 UTC 2006 
Responsible-Changed-Why:  
Over to maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=102644 

From: "Michael Su" <shuoshuo@gmail.com>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/102644: devel/p5-Decision-ACL: fix wrong decision when using zero as field value
Date: Tue, 29 Aug 2006 22:30:55 +0800

 the patch file for ACL/Rule.pm should corrected as following content:
 
 patch-ACL-Rule.pm:
 
 *** ACL/Rule.pm Tue Jul 10 02:06:13 2001
 --- ACL/Rule.pm Tue Aug 29 20:05:40 2006
 ***************
 *** 120,130 ****
                 print STDERR "$field control (".$field_value.")->" if
 $self->DEBUG_LEVEL();;
 
                 return ACL_RULE_UNCONCERNED if(
 !                                               $field_value ne $args->{$field}
 !                                               && $field_value
                                                 && $field_value ne 'ALL'
                                                 && $args->{$field} ne 'ALL'
 !                                               && $args->{$field});
                 print STDERR " 1\n" if $self->DEBUG_LEVEL();;
         }
 
 --- 120,130 ----
                 print STDERR "$field control (".$field_value.")->" if
 $self->DEBUG_LEVEL();;
 
                 return ACL_RULE_UNCONCERNED if(
 !                                               defined($field_value)
                                                 && $field_value ne 'ALL'
 +                                               && defined($args->{$field})
                                                 && $args->{$field} ne 'ALL'
 !                                               && $field_value ne
 $args->{$field});
                 print STDERR " 1\n" if $self->DEBUG_LEVEL();;
         }
State-Changed-From-To: open->feedback 
State-Changed-By: aaron 
State-Changed-When: Sat Dec 23 20:54:46 UTC 2006 
State-Changed-Why:  
Ask for submitter fix. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=102644 

From: Aaron Dalton <aaron@FreeBSD.org>
To: bug-followup@FreeBSD.org, shuoshuo+pr@gmail.com
Cc:  
Subject: Re: ports/102644: devel/p5-Decision-ACL: fix wrong decision when
 using zero as field value
Date: Sat, 23 Dec 2006 13:55:12 -0700

 -----BEGIN PGP SIGNED MESSAGE-----
 Hash: SHA1
 
 Michael, I apologize for the extensive delay.  It would be appreciated
 if you could redo these diffs.  The ideal way to submit changes such as
 these is to:
 
 1) checkout the port
 2) modify it as you see fit
 3) then use PortTools and type '$ port submit'
 
 If you choose not to use porttools, then please run the following from
 one level up from your modified port:
 
 $ diff -ruN modifiedport /usr/ports/xxx/originalport > diff.txt
 
 and submit that diff.txt file.  In this case, I would be very
 appreciative if you could generate that diff file as above and simply
 attach it by using reply-to-all with this email.
 
 Let me know if you have any problems or questions!
 
 Cheers!
 - --
 Aaron Dalton
 aaron@FreeBSD.org
 FreeBSD Ports Committer
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.4 (MingW32)
 Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
 
 iD8DBQFFjZewvlYKTYgR0qQRAki/AJwMBbVN9LSqElPeGfrJyBmOny5MaQCgo+/S
 j80HsXkriurORa1arc4Au3s=
 =9ktd
 -----END PGP SIGNATURE-----
State-Changed-From-To: feedback->open 
State-Changed-By: linimon 
State-Changed-When: Tue Apr 29 05:26:49 UTC 2008 
State-Changed-Why:  
Maintainer was reset due to inactivity. 

To submitter: are you still interested in pursuing this bug? 


Responsible-Changed-From-To: aaron->freebsd-ports-bugs 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Tue Apr 29 05:26:49 UTC 2008 
Responsible-Changed-Why:  

http://www.freebsd.org/cgi/query-pr.cgi?pr=102644 
State-Changed-From-To: open->closed 
State-Changed-By: miwi 
State-Changed-When: Mon May 19 05:03:44 UTC 2008 
State-Changed-Why:  
Feedback timeout. If you want to Update this port, please feel free to 
follow-up this PR so that we can re-open it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=102644 
>Unformatted:
