From ssedov@mbsd.msk.ru  Tue Aug 22 21:47:23 2006
Return-Path: <ssedov@mbsd.msk.ru>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 983CC16A4DA;
	Tue, 22 Aug 2006 21:47:23 +0000 (UTC)
	(envelope-from ssedov@mbsd.msk.ru)
Received: from com1.ht-systems.ru (com1.ht-systems.ru [83.97.104.204])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 31D6A43D45;
	Tue, 22 Aug 2006 21:47:18 +0000 (GMT)
	(envelope-from ssedov@mbsd.msk.ru)
Received: from [213.87.86.27] (helo=fonon.realnet)
	by com1.ht-systems.ru with esmtpa (Exim 4.62)
	(envelope-from <ssedov@mbsd.msk.ru>)
	id 1GFe5Z-0004CH-BS; Wed, 23 Aug 2006 01:47:14 +0400
Received: by fonon.realnet (Postfix, from userid 1001)
	id 55EF211F38; Wed, 23 Aug 2006 01:46:48 +0600 (YEKST)
Message-Id: <20060822194648.55EF211F38@fonon.realnet>
Date: Wed, 23 Aug 2006 01:46:48 +0600 (YEKST)
From: Stanislav Sedov <ssedov@mbsd.msk.ru>
To: FreeBSD-gnats-submit@freebsd.org
Cc: clsung@FreeBSD.org
Subject: [PATCH] net-im/centericq: fix memory operation bug
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         102405
>Category:       ports
>Synopsis:       [PATCH] net-im/centericq: fix memory operation bug
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    clsung
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Aug 22 21:50:15 GMT 2006
>Closed-Date:    Wed Aug 23 02:27:07 GMT 2006
>Last-Modified:  Wed Aug 23 02:27:07 GMT 2006
>Originator:     Stanislav Sedov
>Release:        FreeBSD 7.0-CURRENT i386
>Organization:
MBSD labs, Inc.
>Environment:
System: FreeBSD fonon.realnet 7.0-CURRENT FreeBSD 7.0-CURRENT #1: Wed Aug  2 21:44:37 MSD
>Description:
 - Fix yet one bug in libicq code. We don't need to free "it", since it
was never allocated. This tends to core dumps.

I'll submit this patch to original developer.

The following files was added:
- files/patch-libicq2000-0.1_libicq2000_sigslot.h

Copy of this message was sent to (clsung@FreeBSD.org).

>How-To-Repeat:
>Fix:

--- centericq-4.21.0_5.patch begins here ---
diff -ruN --exclude=CVS /usr/ports/net-im/centericq/Makefile /var/tmp/centericq/Makefile
--- /usr/ports/net-im/centericq/Makefile	Wed Aug 23 01:42:49 2006
+++ /var/tmp/centericq/Makefile	Wed Aug 23 01:43:43 2006
@@ -8,7 +8,7 @@
 
 PORTNAME=	centericq
 PORTVERSION=	4.21.0
-PORTREVISION=	4
+PORTREVISION=	5
 CATEGORIES=	net-im
 MASTER_SITES=	http://centericq.de/archive/source/releases/ \
 		http://thekonst.net/download/
diff -ruN --exclude=CVS /usr/ports/net-im/centericq/files/patch-libicq2000-0.1_libicq2000_sigslot.h /var/tmp/centericq/files/patch-libicq2000-0.1_libicq2000_sigslot.h
--- /usr/ports/net-im/centericq/files/patch-libicq2000-0.1_libicq2000_sigslot.h	Thu Jan  1 05:00:00 1970
+++ /var/tmp/centericq/files/patch-libicq2000-0.1_libicq2000_sigslot.h	Wed Aug 23 01:41:17 2006
@@ -0,0 +1,10 @@
+--- ./libicq2000-0.1/libicq2000/sigslot.h.orig	Wed Aug 23 01:30:57 2006
++++ ./libicq2000-0.1/libicq2000/sigslot.h	Wed Aug 23 01:34:04 2006
+@@ -616,7 +616,6 @@
+ 				if((*it)->getdest() == pslot)
+ 				{
+ 					m_connected_slots.erase(it);
+-					delete *it;
+ 				}
+ 
+ 				it = itNext;
--- centericq-4.21.0_5.patch ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->clsung 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Tue Aug 22 21:50:25 UTC 2006 
Responsible-Changed-Why:  
Over to maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=102405 
State-Changed-From-To: open->closed 
State-Changed-By: clsung 
State-Changed-When: Wed Aug 23 02:27:03 UTC 2006 
State-Changed-Why:  
Committed. Thank You. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=102405 
>Unformatted:
