From ed@zonk.fxq.nl  Sat Aug 19 14:24:06 2006
Return-Path: <ed@zonk.fxq.nl>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 4C0B816A4DE
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 19 Aug 2006 14:24:06 +0000 (UTC)
	(envelope-from ed@zonk.fxq.nl)
Received: from swip.net (mailfe12.swip.net [212.247.155.97])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 1108B43D45
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 19 Aug 2006 14:24:02 +0000 (GMT)
	(envelope-from ed@zonk.fxq.nl)
Received: from [83.180.59.125] (HELO zonk.fxq.nl)
  by mailfe12.swip.net (CommuniGate Pro SMTP 5.0.8)
  with ESMTPS id 88431308 for FreeBSD-gnats-submit@freebsd.org; Sat, 19 Aug 2006 16:23:55 +0200
Received: from zonk.fxq.nl (localhost [127.0.0.1])
	by zonk.fxq.nl (8.13.6/8.13.6) with ESMTP id k7JEO3WI081397
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 19 Aug 2006 16:24:03 +0200 (CEST)
	(envelope-from ed@zonk.fxq.nl)
Received: (from ed@localhost)
	by zonk.fxq.nl (8.13.6/8.13.6/Submit) id k7JEO3ka081396;
	Sat, 19 Aug 2006 16:24:03 +0200 (CEST)
	(envelope-from ed)
Message-Id: <200608191424.k7JEO3ka081396@zonk.fxq.nl>
Date: Sat, 19 Aug 2006 16:24:03 +0200 (CEST)
From: Ed Schouten <ed@fxq.nl>
Reply-To: Ed Schouten <ed@fxq.nl>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [audio/herrie] Bump to 0.2
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         102273
>Category:       ports
>Synopsis:       [audio/herrie] Bump to 0.2
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    ehaupt
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Sat Aug 19 14:30:13 GMT 2006
>Closed-Date:    Thu Aug 31 14:12:18 CEST 2006
>Last-Modified:  Thu Aug 31 14:12:18 CEST 2006
>Originator:     Ed Schouten
>Release:        FreeBSD 6.1-STABLE i386
>Organization:
>Environment:
System: FreeBSD zonk.fxq.nl 6.1-STABLE FreeBSD 6.1-STABLE #0: Sat Jul 15 23:07:29 CEST 2006 root@zonk.fxq.nl:/usr/obj/usr/src/sys/ZONK i386

>Description:
A new version of the Herrie audio player is available. This version has
a lot of useful changes, including:

- The addition of a manual page.
- Usage of glib, resulting in a more portable (and safer) application.
- Improved threading, removing the need of semaphores. This makes Herrie
  work out of the box on FreeBSD. sem(4) is not needed anymore.
- AudioScrobbler, using libcurl.

>How-To-Repeat:
n/a

>Fix:
The patch below bumps the port to 0.2:

%%%
--- herrie/Makefile	Tue Aug  1 22:05:31 2006
+++ herrie/Makefile	Sat Aug 19 16:20:38 2006
@@ -6,7 +6,7 @@
 #
 
 PORTNAME=	herrie
-PORTVERSION=	0.1
+PORTVERSION=	0.2
 CATEGORIES=	audio
 MASTER_SITES=	http://www.il.fontys.nl/~ed/projects/herrie/distfiles/ \
 		http://www.stack.nl/~ed/projects/herrie/distfiles/
@@ -14,19 +14,42 @@
 MAINTAINER=	ed@fxq.nl
 COMMENT=	A small command line interface music player
 
-LIB_DEPENDS=	vorbis.3:${PORTSDIR}/audio/libvorbis \
-		mad.2:${PORTSDIR}/audio/mad \
-		sndfile.1:${PORTSDIR}/audio/libsndfile
-
-GNU_CONFIGURE=	yes
-CONFIGURE_ENV+=	CFLAGS="${PTHREAD_CFLAGS} -I${LOCALBASE}/include" LDFLAGS="-L${LOCALBASE}/lib ${PTHREAD_LIBS}"
+USE_GNOME=	glib20
+USE_OPENSSL=	yes
+USE_GMAKE=	yes
+MAKEFILE=	GNUmakefile
+ALL_TARGET=	herrie
+WRKSRC=		${WRKDIR}/${DISTNAME}/src
+
+OPTIONS=	MAD "MAD MP3 support" on \
+		VORBIS "Ogg Vorbis support" on \
+		SNDFILE "libsndfile support" off \
+		SCROBBLER "AudioScrobbler support" on
 
 PLIST_FILES=	bin/herrie
+MAN1=		herrie.1
 
 .include <bsd.port.pre.mk>
 
-.if ${OSVERSION} < 500000
-IGNORE=		doesn't like 4.x thread libs
+.if !defined(WITHOUT_MAD)
+LIB_DEPENDS+=	mad.2:${PORTSDIR}/audio/mad
+.else
+MAKE_ENV+=	NO_MP3=yes
+.endif
+.if !defined(WITHOUT_VORBIS)
+LIB_DEPENDS+=	vorbis.3:${PORTSDIR}/audio/libvorbis
+.else
+MAKE_ENV+=	NO_VORBIS=yes
+.endif
+.if !defined(WITHOUT_SNDFILE)
+LIB_DEPENDS+=	sndfile.1:${PORTSDIR}/audio/libsndfile
+.else
+MAKE_ENV+=	NO_SNDFILE=yes
+.endif
+.if !defined(WITHOUT_SCROBBLER)
+LIB_DEPENDS+=	curl:${PORTSDIR}/ftp/curl
+.else
+MAKE_ENV+=	NO_SCROBBLER=yes
 .endif
 
 .include <bsd.port.post.mk>
--- herrie/distinfo	Tue Aug  1 22:05:31 2006
+++ herrie/distinfo	Sat Aug 19 16:16:13 2006
@@ -1,3 +1,3 @@
-MD5 (herrie-0.1.tar.gz) = 895e18c071d41beef6b9806bfb7c97c7
-SHA256 (herrie-0.1.tar.gz) = b0858b939575155bb6b6da8160b27459099aa11d002564f40520edf106a8965e
-SIZE (herrie-0.1.tar.gz) = 128954
+MD5 (herrie-0.2.tar.gz) = dd29736faeae572bd4f21ea5b3fa9fb3
+SHA256 (herrie-0.2.tar.gz) = 6344d8471ddb1adb12cea5baa034bd064ecc7692ad8cc8a804d1d807b44be0f0
+SIZE (herrie-0.2.tar.gz) = 37705
--- herrie/pkg-descr	Tue Aug  1 22:05:31 2006
+++ herrie/pkg-descr	Sat Aug 19 16:13:29 2006
@@ -1,5 +1,6 @@
 Herrie is a small command line music player. It has vim-like controls
 and has some unique features, like chroot()'ing and dropping privileges.
-This makes it an ideal application for low-end jukeboxes.
+It also supports submission of songs to AudioScrobbler. This makes it an
+ideal application for low-end jukeboxes.
  
 WWW: http://g-rave.nl/projects/herrie/
%%%
>Release-Note:
>Audit-Trail:

From: Ed Schouten <ed@fxq.nl>
To: FreeBSD-gnats-submit@FreeBSD.org, freebsd-ports-bugs@FreeBSD.org
Cc:  
Subject: Re: ports/102273: [audio/herrie] Bump to 0.2
Date: Sat, 19 Aug 2006 17:28:47 +0200

 Ouch!
 
 Looks like the latest Herrie doesn't build on FreeBSD 4.x because of a
 missing #include. Please use the following patch:
 
 %%%
 --- herrie/Makefile	Tue Aug  1 22:05:31 2006
 +++ herrie/Makefile	Sat Aug 19 17:24:16 2006
 @@ -6,7 +6,7 @@
  #
  
  PORTNAME=	herrie
 -PORTVERSION=	0.1
 +PORTVERSION=	0.2
  CATEGORIES=	audio
  MASTER_SITES=	http://www.il.fontys.nl/~ed/projects/herrie/distfiles/ \
  		http://www.stack.nl/~ed/projects/herrie/distfiles/
 @@ -14,19 +14,42 @@
  MAINTAINER=	ed@fxq.nl
  COMMENT=	A small command line interface music player
  
 -LIB_DEPENDS=	vorbis.3:${PORTSDIR}/audio/libvorbis \
 -		mad.2:${PORTSDIR}/audio/mad \
 -		sndfile.1:${PORTSDIR}/audio/libsndfile
 -
 -GNU_CONFIGURE=	yes
 -CONFIGURE_ENV+=	CFLAGS="${PTHREAD_CFLAGS} -I${LOCALBASE}/include" LDFLAGS="-L${LOCALBASE}/lib ${PTHREAD_LIBS}"
 +USE_GNOME=	glib20
 +USE_OPENSSL=	yes
 +USE_GMAKE=	yes
 +MAKEFILE=	GNUmakefile
 +ALL_TARGET=	herrie
 +WRKSRC=		${WRKDIR}/${DISTNAME}/src
 +
 +OPTIONS=	MAD "MAD MP3 support" on \
 +		VORBIS "Ogg Vorbis support" on \
 +		SNDFILE "libsndfile support" off \
 +		SCROBBLER "AudioScrobbler support" on
  
  PLIST_FILES=	bin/herrie
 +MAN1=		herrie.1
  
  .include <bsd.port.pre.mk>
  
 -.if ${OSVERSION} < 500000
 -IGNORE=		doesn't like 4.x thread libs
 +.if !defined(WITHOUT_MAD)
 +LIB_DEPENDS+=	mad.2:${PORTSDIR}/audio/mad
 +.else
 +MAKE_ENV+=	NO_MP3=yes
 +.endif
 +.if !defined(WITHOUT_VORBIS)
 +LIB_DEPENDS+=	vorbis.3:${PORTSDIR}/audio/libvorbis
 +.else
 +MAKE_ENV+=	NO_VORBIS=yes
 +.endif
 +.if !defined(WITHOUT_SNDFILE)
 +LIB_DEPENDS+=	sndfile.1:${PORTSDIR}/audio/libsndfile
 +.else
 +MAKE_ENV+=	NO_SNDFILE=yes
 +.endif
 +.if !defined(WITHOUT_SCROBBLER)
 +LIB_DEPENDS+=	curl:${PORTSDIR}/ftp/curl
 +.else
 +MAKE_ENV+=	NO_SCROBBLER=yes
  .endif
  
  .include <bsd.port.post.mk>
 --- herrie/distinfo	Tue Aug  1 22:05:31 2006
 +++ herrie/distinfo	Sat Aug 19 17:24:25 2006
 @@ -1,3 +1,3 @@
 -MD5 (herrie-0.1.tar.gz) = 895e18c071d41beef6b9806bfb7c97c7
 -SHA256 (herrie-0.1.tar.gz) = b0858b939575155bb6b6da8160b27459099aa11d002564f40520edf106a8965e
 -SIZE (herrie-0.1.tar.gz) = 128954
 +MD5 (herrie-0.2.tar.gz) = dd29736faeae572bd4f21ea5b3fa9fb3
 +SHA256 (herrie-0.2.tar.gz) = 6344d8471ddb1adb12cea5baa034bd064ecc7692ad8cc8a804d1d807b44be0f0
 +SIZE (herrie-0.2.tar.gz) = 37705
 --- herrie/files/patch-scrobbler_hash.c	Thu Jan  1 01:00:00 1970
 +++ herrie/files/patch-scrobbler_hash.c	Sat Aug 19 17:25:52 2006
 @@ -0,0 +1,10 @@
 +--- scrobbler/scrobbler_hash.c	Sat Aug 19 15:52:12 2006
 ++++ scrobbler/scrobbler_hash.c	Sat Aug 19 17:25:13 2006
 +@@ -29,6 +29,7 @@
 +  * @file scrobbler/scrobbler_hash.c
 +  */
 + 
 ++#include <sys/types.h>
 + #include <openssl/md5.h>
 + 
 + #include <scrobbler/scrobbler.h>
 --- herrie/pkg-descr	Tue Aug  1 22:05:31 2006
 +++ herrie/pkg-descr	Sat Aug 19 17:24:25 2006
 @@ -1,5 +1,6 @@
  Herrie is a small command line music player. It has vim-like controls
  and has some unique features, like chroot()'ing and dropping privileges.
 -This makes it an ideal application for low-end jukeboxes.
 +It also supports submission of songs to AudioScrobbler. This makes it an
 +ideal application for low-end jukeboxes.
   
  WWW: http://g-rave.nl/projects/herrie/
 %%%
 
 Yours,
 -- 
  Ed Schouten <ed@fxq.nl>
  WWW: http://g-rave.nl/

From: Ed Schouten <ed@fxq.nl>
To: FreeBSD-gnats-submit@FreeBSD.org, freebsd-ports-bugs@FreeBSD.org
Cc:  
Subject: Re: ports/102273: [audio/herrie] Bump to 0.2
Date: Mon, 28 Aug 2006 21:31:11 +0200

 --wjoFZxbW4tu+iR6v
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable
 
 Hello,
 
 In the mean time Herrie got bumped to 0.3. Version 0.3 fixes a lot of
 small bugs, including compilation on FreeBSD 4.x. Also the support for
 libsndfile got improved.
 
 %%%
 --- audio/herrie/Makefile	Tue Aug  1 22:05:31 2006
 +++ audio/herrie/Makefile	Mon Aug 28 21:27:37 2006
 @@ -6,7 +6,7 @@
  #
 =20
  PORTNAME=3D	herrie
 -PORTVERSION=3D	0.1
 +PORTVERSION=3D	0.3
  CATEGORIES=3D	audio
  MASTER_SITES=3D	http://www.il.fontys.nl/~ed/projects/herrie/distfiles/ \
  		http://www.stack.nl/~ed/projects/herrie/distfiles/
 @@ -14,19 +14,42 @@
  MAINTAINER=3D	ed@fxq.nl
  COMMENT=3D	A small command line interface music player
 =20
 -LIB_DEPENDS=3D	vorbis.3:${PORTSDIR}/audio/libvorbis \
 -		mad.2:${PORTSDIR}/audio/mad \
 -		sndfile.1:${PORTSDIR}/audio/libsndfile
 -
 -GNU_CONFIGURE=3D	yes
 -CONFIGURE_ENV+=3D	CFLAGS=3D"${PTHREAD_CFLAGS} -I${LOCALBASE}/include" LDFL=
 AGS=3D"-L${LOCALBASE}/lib ${PTHREAD_LIBS}"
 +USE_GNOME=3D	glib20
 +USE_GMAKE=3D	yes
 +MAKEFILE=3D	GNUmakefile
 +ALL_TARGET=3D	herrie
 +WRKSRC=3D		${WRKDIR}/${DISTNAME}/src
 +
 +OPTIONS=3D	MAD "MAD MP3 support" on \
 +		VORBIS "Ogg Vorbis support" on \
 +		SNDFILE "libsndfile support" off \
 +		SCROBBLER "AudioScrobbler support" on
 =20
  PLIST_FILES=3D	bin/herrie
 +MAN1=3D		herrie.1
 =20
  .include <bsd.port.pre.mk>
 =20
 -.if ${OSVERSION} < 500000
 -IGNORE=3D		doesn't like 4.x thread libs
 +.if !defined(WITHOUT_MAD)
 +LIB_DEPENDS+=3D	mad.2:${PORTSDIR}/audio/mad
 +.else
 +MAKE_ENV+=3D	NO_MP3=3Dyes
 +.endif
 +.if !defined(WITHOUT_VORBIS)
 +LIB_DEPENDS+=3D	vorbis.3:${PORTSDIR}/audio/libvorbis
 +.else
 +MAKE_ENV+=3D	NO_VORBIS=3Dyes
 +.endif
 +.if !defined(WITHOUT_SNDFILE)
 +LIB_DEPENDS+=3D	sndfile.1:${PORTSDIR}/audio/libsndfile
 +.else
 +MAKE_ENV+=3D	NO_SNDFILE=3Dyes
 +.endif
 +.if !defined(WITHOUT_SCROBBLER)
 +LIB_DEPENDS+=3D	curl:${PORTSDIR}/ftp/curl
 +USE_OPENSSL=3D	yes
 +.else
 +MAKE_ENV+=3D	NO_SCROBBLER=3Dyes
  .endif
 =20
  .include <bsd.port.post.mk>
 --- audio/herrie/distinfo	Tue Aug  1 22:05:31 2006
 +++ audio/herrie/distinfo	Mon Aug 28 21:27:48 2006
 @@ -1,3 +1,3 @@
 -MD5 (herrie-0.1.tar.gz) =3D 895e18c071d41beef6b9806bfb7c97c7
 -SHA256 (herrie-0.1.tar.gz) =3D b0858b939575155bb6b6da8160b27459099aa11d002=
 564f40520edf106a8965e
 -SIZE (herrie-0.1.tar.gz) =3D 128954
 +MD5 (herrie-0.3.tar.gz) =3D b12c8552922ec9ef3dc66b4dacfc48a9
 +SHA256 (herrie-0.3.tar.gz) =3D e95714bf136b46f3ff593e3e33c21a99d078fe0465a=
 92fd2555a88173e4f4d69
 +SIZE (herrie-0.3.tar.gz) =3D 37967
 --- audio/herrie/pkg-descr	Tue Aug  1 22:05:31 2006
 +++ audio/herrie/pkg-descr	Mon Aug 28 21:27:04 2006
 @@ -1,5 +1,6 @@
  Herrie is a small command line music player. It has vim-like controls
  and has some unique features, like chroot()'ing and dropping privileges.
 -This makes it an ideal application for low-end jukeboxes.
 +It also supports submission of songs to AudioScrobbler. This makes it an
 +ideal application for low-end jukeboxes.
  =20
  WWW: http://g-rave.nl/projects/herrie/
 %%%
 
 Yours,
 --=20
  Ed Schouten <ed@fxq.nl>
  WWW: http://g-rave.nl/
 
 --wjoFZxbW4tu+iR6v
 Content-Type: application/pgp-signature
 Content-Disposition: inline
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.5 (FreeBSD)
 
 iD8DBQFE80R/52SDGA2eCwURAgsDAJ9dfgjNFVv5AYDr2DNMtedq63r2aQCfVEkk
 SSekRaaICTF4qduliUGhjCE=
 =3R5v
 -----END PGP SIGNATURE-----
 
 --wjoFZxbW4tu+iR6v--
Responsible-Changed-From-To: freebsd-ports-bugs->ehaupt 
Responsible-Changed-By: ehaupt 
Responsible-Changed-When: Wed Aug 30 19:14:12 CEST 2006 
Responsible-Changed-Why:  
I will take care of it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=102273 
State-Changed-From-To: open->feedback 
State-Changed-By: ehaupt 
State-Changed-When: Wed Aug 30 19:24:59 CEST 2006 
State-Changed-Why:  
Awaiting feedback from maintainer. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=102273 
State-Changed-From-To: feedback->closed 
State-Changed-By: ehaupt 
State-Changed-When: Thu Aug 31 14:12:16 CEST 2006 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=102273 
>Unformatted:
