From alex@foxybanana.com  Sun Aug 13 03:47:01 2006
Return-Path: <alex@foxybanana.com>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 206A016A4E0
	for <freebsd-gnats-submit@freebsd.org>; Sun, 13 Aug 2006 03:47:01 +0000 (UTC)
	(envelope-from alex@foxybanana.com)
Received: from centrmmtao04.cox.net (centrmmtao04.cox.net [70.168.83.80])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 366E643D58
	for <freebsd-gnats-submit@freebsd.org>; Sun, 13 Aug 2006 03:46:59 +0000 (GMT)
	(envelope-from alex@foxybanana.com)
Received: from eastrmimpo02.cox.net ([68.1.16.120]) by centrmmtao04.cox.net
          (InterMail vM.6.01.06.01 201-2131-130-101-20060113) with ESMTP
          id <20060813034659.TRSS14774.centrmmtao04.cox.net@eastrmimpo02.cox.net>
          for <freebsd-gnats-submit@freebsd.org>;
          Sat, 12 Aug 2006 23:46:59 -0400
Received: from Laptop.mine.box ([24.250.225.55])
	by eastrmimpo02.cox.net with bizsmtp
	id 9Fml1V0011CLYMk0000000
	Sat, 12 Aug 2006 23:46:45 -0400
Received: from Laptop.mine.box (localhost [127.0.0.1])
	by Laptop.mine.box (8.13.6/8.13.6) with ESMTP id k7D3klDA017241
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 12 Aug 2006 23:46:47 -0400 (EDT)
	(envelope-from alex@localhost.my.domain)
Received: (from alex@localhost)
	by Laptop.mine.box (8.13.6/8.13.6/Submit) id k7D3kl4H017240;
	Sat, 12 Aug 2006 23:46:47 -0400 (EDT)
	(envelope-from alex)
Message-Id: <200608130346.k7D3kl4H017240@Laptop.mine.box>
Date: Sat, 12 Aug 2006 23:46:47 -0400 (EDT)
From: Alexander Botero-Lowry <alex@foxybanana.com>
Reply-To: Alexander Botero-Lowry <alex@foxybanana.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [PATCH] bsd.scons.mk: remove DESTDIR
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         101952
>Category:       ports
>Synopsis:       [PATCH] bsd.scons.mk: remove DESTDIR
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    portmgr
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          maintainer-update
>Submitter-Id:   current-users
>Arrival-Date:   Sun Aug 13 03:50:16 GMT 2006
>Closed-Date:    Fri Sep 15 07:37:18 GMT 2006
>Last-Modified:  Fri Sep 15 08:10:19 GMT 2006
>Originator:     Alexander Botero-Lowry
>Release:        FreeBSD 6.1-STABLE i386
>Organization:
>Environment:
System: FreeBSD Laptop.mine.box 6.1-STABLE FreeBSD 6.1-STABLE #1: Mon Jul 10 22:43:23 CDT 2006 root@Laptop.mine.box:/usr/src/sys/i386/compile/LAPTOP i386


>Description:
	- SCons does not directly support any kind of destdir, so don't try
	  passing it on the enviornment. Ports will have to implement destdir
	  support by patching the SConstruct themselves, or hoping upstream
	  implemented the support.

>How-To-Repeat:
>Fix:

	

--- remove_destdir.patch begins here ---
? remove_destdir.patch
Index: bsd.scons.mk
===================================================================
RCS file: /home/ncvs/ports/Mk/bsd.scons.mk,v
retrieving revision 1.6
diff -u -r1.6 bsd.scons.mk
--- bsd.scons.mk	4 Aug 2006 12:34:41 -0000	1.6
+++ bsd.scons.mk	13 Aug 2006 03:43:25 -0000
@@ -57,7 +57,7 @@
 SCONS_ENV?=	CCFLAGS="${CCFLAGS}" CXXFLAGS="${CXXFLAGS}" \
 		LINKFLAGS="${LINKFLAGS}" PKGCONFIGDIR="${PKGCONFIGDIR}"  \
 		CPPPATH="${CPPPATH}" LIBPATH="${LIBPATH}" PREFIX="${PREFIX}" \
-		DESTDIR="${DESTDIR}" CC="${CC}" CXX="${CXX}"
+		CC="${CC}" CXX="${CXX}"
 SCONS_ARGS?=
 SCONS_BUILDENV?=
 SCONS_TARGET?=
--- remove_destdir.patch ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->portmgr 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Sun Aug 13 04:46:45 UTC 2006 
Responsible-Changed-Why:  
There are some other pending patches against this in the portmgr queue. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=101952 
State-Changed-From-To: open->analyzed 
State-Changed-By: linimon 
State-Changed-When: Mon Aug 28 04:46:18 UTC 2006 
State-Changed-Why:  
Accepted for a test build on the cluster. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=101952 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/101952: commit references a PR
Date: Fri, 15 Sep 2006 06:57:14 +0000 (UTC)

 linimon     2006-09-15 06:57:07 UTC
 
   FreeBSD ports repository
 
   Modified files:
     Mk                   bsd.port.mk 
     .                    CHANGES 
   Added files:
     Mk                   bsd.lua.mk 
   Log:
   * Add PKGVERSION to bsd.port.mk [1]
   
   * Add bsd.lua.mk to support for lua-based ports [2]
   
   * Remove DESTDIR from bsd.scons.mk [3]
   
   * Add some quotes in 'missing' target to improve handling of duplicate
     origins [4]
   
   PR:     98565 [1], 101612 [2], 101952 [3], 102100 [4]
   
   Submitted by:   ahze [1], alepulver [2], alexbl [3], shaun [4]
   
   Revision  Changes    Path
   1.60      +15 -1     ports/CHANGES
   1.1       +420 -0    ports/Mk/bsd.lua.mk (new)
   1.541     +23 -3     ports/Mk/bsd.port.mk
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
State-Changed-From-To: analyzed->closed 
State-Changed-By: linimon 
State-Changed-When: Fri Sep 15 07:37:07 UTC 2006 
State-Changed-Why:  
Committed, thanks. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=101952 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/101952: commit references a PR
Date: Fri, 15 Sep 2006 08:06:18 +0000 (UTC)

 linimon     2006-09-15 08:06:12 UTC
 
   FreeBSD ports repository
 
   Modified files:
     Mk                   bsd.scons.mk 
   Log:
   Remove DESTDIR as it is currently problematic.
   
   PR:             ports/101952
   Submitted by:   alexbl
   
   Revision  Changes    Path
   1.8       +2 -2      ports/Mk/bsd.scons.mk
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
