From bsam@ns.kfs.ru  Fri Aug 11 10:52:26 2006
Return-Path: <bsam@ns.kfs.ru>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 2EBCD16A4DF
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 11 Aug 2006 10:52:26 +0000 (UTC)
	(envelope-from bsam@ns.kfs.ru)
Received: from ns.kfs.ru (kfs.kfs.ru [62.183.117.194])
	by mx1.FreeBSD.org (Postfix) with ESMTP id A682443D46
	for <FreeBSD-gnats-submit@freebsd.org>; Fri, 11 Aug 2006 10:52:25 +0000 (GMT)
	(envelope-from bsam@ns.kfs.ru)
Received: from bsam by ns.kfs.ru with local (Exim 4.54 (FreeBSD))
	id 1GBUcp-000OPM-Km
	for FreeBSD-gnats-submit@freebsd.org; Fri, 11 Aug 2006 14:52:23 +0400
Message-Id: <E1GBUcp-000OPM-Km@ns.kfs.ru>
Date: Fri, 11 Aug 2006 14:52:23 +0400
From: Boris Samorodov <bsam@FreeBSD.org>
Sender: "Boris B. Samorodov" <bsam@ns.kfs.ru>
Reply-To: Boris Samorodov <bsam@FreeBSD.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [patch] bsd.port.mk: add missing "|| true" command
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         101809
>Category:       ports
>Synopsis:       [patch] bsd.port.mk: add missing "|| true" command
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    portmgr
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Aug 11 11:00:31 GMT 2006
>Closed-Date:    Wed Sep 20 04:06:10 GMT 2006
>Last-Modified:  Wed Sep 20 04:10:24 GMT 2006
>Originator:     Boris B. Samorodov
>Release:        FreeBSD 6.0-STABLE i386
>Organization:
InPharmTech Co., http://www.ipt.ru
>Environment:
System: FreeBSD serv3.int.kfs.ru 6.0-STABLE FreeBSD 6.0-STABLE #0: Wed Nov 23 23:34:00 MSK 2005 bsam@serv3.int.kfs.ru:/usr/obj/usr/src/sys/SERV3 i386

>Description:
	While testing a patch for lang/gnat-gcc34 to unbreak it at 4.x, I get
	an error at the thinderbox:
	====================<phase 7: make package>====================
	===>  Building package for gnat-gcc-3.4.6
	Creating package /tmp/packages/All/gnat-gcc-3.4.6.tgz
	Registering depends: ldconfig_compat-1.0_8 rc_subr-1.31_1.
	Registering conflicts: gcc-3.4.*.
	Creating gzip'd tar ball in '/tmp/packages/All/gnat-gcc-3.4.6.tgz'
	Deleting gnat-gcc-3.4.6
	pkg_delete: unexec command for 'rmdir libdata/ldconfig >/dev/null 2>&1' failed  [1]
	pkg_delete: couldn't entirely delete package (perhaps the packing list is
	incorrectly specified?)

	I assume that this command (@unexec) and it's output to STDOUT and
	STDERR redirecting to /dev/null were added to bsd.port.mk to
	avoid such errors. But the last part (|| true) was not added
	by accident.

>How-To-Repeat:
>Fix:
Index: bsd.port.mk
===================================================================
RCS file: /home/pcvs/ports/Mk/bsd.port.mk,v
retrieving revision 1.539
diff -u -r1.539 bsd.port.mk
--- bsd.port.mk	4 Aug 2006 12:34:41 -0000	1.539
+++ bsd.port.mk	11 Aug 2006 09:19:03 -0000
@@ -3858,7 +3858,7 @@
 		> ${PREFIX}/${LDCONFIG_DIR}/${UNIQUENAME}
 	@${ECHO_CMD} ${LDCONFIG_DIR}/${UNIQUENAME} >> ${TMPPLIST}
 .if defined(NO_LDCONFIG_MTREE)
-	@${ECHO_CMD} "@unexec rmdir ${LDCONFIG_DIR} >/dev/null 2>&1" >> ${TMPPLIST}
+	@${ECHO_CMD} "@unexec rmdir ${LDCONFIG_DIR} >/dev/null 2>&1 || true" >> ${TMPPLIST}
 .endif
 .endif
 .endif

WBR
-- 
bsam
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->portmgr 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Fri Aug 11 11:00:45 UTC 2006 
Responsible-Changed-Why:  
bsd.port.mk is port manager territory 

http://www.freebsd.org/cgi/query-pr.cgi?pr=101809 

From: "Boris B. Samorodov" <bsam@ipt.ru>
To: bug-followup@FreeBSD.org,bsam@FreeBSD.org
Cc:  
Subject: Re: ports/101809: [patch] bsd.port.mk: add missing "|| true" command?Gcc=INBOX.Sent
Date: Fri, 01 Sep 2006 13:03:57 +0400

 Testing http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/102727 I can
 confirm that this problem exists not only for 4.x but for 5.x as well
 (didn't test at 6.x, but I assume the same).
 
 WBR
 -- 
 bsam

From: "Boris B. Samorodov" <bsam@ipt.ru>
To: bug-followup@FreeBSD.org,bsam@FreeBSD.org
Cc:  
Subject: Re: ports/101809: [patch] bsd.port.mk: add missing "|| true" command?Gcc=INBOX.Sent
Date: Mon, 04 Sep 2006 11:39:50 +0400

 I think I should note here that the proposed patch is only a
 _cosmetic_ one as soon as those messages are redirected form stderr to
 stdout and an error does not occure when building a port.
 
 WBR
 -- 
 bsam
State-Changed-From-To: open->analyzed 
State-Changed-By: linimon 
State-Changed-When: Fri Sep 15 07:46:18 UTC 2006 
State-Changed-Why:  
kris is running a test build on the cluster with this one. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=101809 
State-Changed-From-To: open->closed 
State-Changed-By: kris 
State-Changed-When: Wed Sep 20 04:04:46 UTC 2006 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=96088 
State-Changed-From-To: analyzed->closed 
State-Changed-By: kris 
State-Changed-When: Wed Sep 20 04:04:46 UTC 2006 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=102750 
State-Changed-From-To: analyzed->closed 
State-Changed-By: kris 
State-Changed-When: Wed Sep 20 04:04:46 UTC 2006 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=102514 
State-Changed-From-To: analyzed->closed 
State-Changed-By: kris 
State-Changed-When: Wed Sep 20 04:04:46 UTC 2006 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=102300 
State-Changed-From-To: analyzed->closed 
State-Changed-By: kris 
State-Changed-When: Wed Sep 20 04:04:46 UTC 2006 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=101809 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/101809: commit references a PR
Date: Wed, 20 Sep 2006 04:02:15 +0000 (UTC)

 kris        2006-09-20 04:02:09 UTC
 
   FreeBSD ports repository
 
   Modified files:
     Mk                   bsd.port.mk 
   Log:
   * Add missing '|| true' to silence an @unexec rmdir [1]
   
   * Repair CONFLICTS, which was broken by previous DESTDIR changes [2]
   
   * Use "set --" instead of "set" for better robustness [3]
   
   * Avoid :L modifier in ${USE_LDCONFIG} which broke e.g. /usr/X11R6
     ports [4]
   
   * Correct a comment typo [4]
   
   * Force passive FTP mode by default (this is already the default with
     the standard login class, so this is a NOP for most users) [5].
   
   PR:             ports/101809 [1], ports/102300 [2], ports/102514 [3],
                   ports/102750 [4], ports/96088 [5]
   Submitted by:   bsam [1], Matthias Andree <matthias.andree@gmx.de> [2],
                   infofarmer [3], flz [4],
                   Darren Pilgrim <darren.pilgrim@bitfreak.org> [5]
   
   Revision  Changes    Path
   1.542     +14 -10    ports/Mk/bsd.port.mk
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
