From root@catv-50635cb6.catv.broadband.hu  Fri Aug 11 10:12:06 2006
Return-Path: <root@catv-50635cb6.catv.broadband.hu>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id CBDA816A4DA;
	Fri, 11 Aug 2006 10:12:06 +0000 (UTC)
	(envelope-from root@catv-50635cb6.catv.broadband.hu)
Received: from catv-50635cb6.catv.broadband.hu (catv-50635cb6.catv.broadband.hu [80.99.92.182])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 7006643D46;
	Fri, 11 Aug 2006 10:12:06 +0000 (GMT)
	(envelope-from root@catv-50635cb6.catv.broadband.hu)
Received: by catv-50635cb6.catv.broadband.hu (Postfix, from userid 0)
	id EDBD5289C27; Fri, 11 Aug 2006 12:12:04 +0200 (CEST)
Message-Id: <20060811101204.EDBD5289C27@catv-50635cb6.catv.broadband.hu>
Date: Fri, 11 Aug 2006 12:12:04 +0200 (CEST)
From: Gabor Kovesdan <gabor@FreeBSD.org>
Reply-To: Gabor Kovesdan <gabor@FreeBSD.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc: Gabor Kovesdan <gabor@FreeBSD.org>
Subject: [patch] archivers/lzma
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         101803
>Category:       ports
>Synopsis:       [patch] archivers/lzma
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    infofarmer
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Aug 11 10:20:15 GMT 2006
>Closed-Date:    Fri Aug 11 16:31:40 GMT 2006
>Last-Modified:  Fri Aug 11 16:31:40 GMT 2006
>Originator:     Gabor Kovesdan
>Release:        FreeBSD 6.1-STABLE i386
>Organization:
n/a
>Environment:
System: FreeBSD spitfire 6.1-STABLE FreeBSD 6.1-STABLE #0: Sat Jul 29 18:31:18 CEST 2006 gabor@spitfire:/usr/src/sys/i386/compile/SPITFIRE i386

>Description:

- Respect DESTDIR
- Remove an unnecessary trailing /

>How-To-Repeat:
>Fix:

--- archivers-lzma.diff begins here ---
Index: Makefile
===================================================================
RCS file: /usr/cvs/ports/archivers/lzma/Makefile,v
retrieving revision 1.7
diff -u -r1.7 Makefile
--- Makefile	30 Jul 2006 22:45:56 -0000	1.7
+++ Makefile	11 Aug 2006 10:08:43 -0000
@@ -33,10 +33,10 @@
 		${BUILD_WRKSRC}/${MAKEFILE}
 
 do-install:
-	${INSTALL_PROGRAM} ${BUILD_WRKSRC}/lzma ${PREFIX}/bin
+	${INSTALL_PROGRAM} ${BUILD_WRKSRC}/lzma ${TARGETDIR}/bin
 .if !defined(NOPORTDOCS)
 	${MKDIR} ${DOCSDIR}
-	${INSTALL_DATA} ${PORTDOCS:S,^,${WRKSRC}/,} ${DOCSDIR}/
+	${INSTALL_DATA} ${PORTDOCS:S,^,${WRKSRC}/,} ${DOCSDIR}
 .endif
 
 .include <bsd.port.mk>
--- archivers-lzma.diff ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->infofarmer 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Fri Aug 11 10:20:23 UTC 2006 
Responsible-Changed-Why:  
Over to maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=101803 

From: "Andrew Pantyukhin" <infofarmer@FreeBSD.org>
To: bug-followup@FreeBSD.org, gabor@FreeBSD.org, ports@FreeBSD.org
Cc:  
Subject: Re: ports/101803: [patch] archivers/lzma
Date: Fri, 11 Aug 2006 19:20:18 +0400

 IMHO trailing slashes are very good style:
 
 1. It's easier to see that destination is a directory
 2. In case the destination directory does not exist
 a trailing slash will save you from a nasty bug
State-Changed-From-To: open->closed 
State-Changed-By: sat 
State-Changed-When: Fri Aug 11 16:31:30 UTC 2006 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=101803 
>Unformatted:
