From root@catv-50635cb6.catv.broadband.hu  Fri Aug 11 09:48:44 2006
Return-Path: <root@catv-50635cb6.catv.broadband.hu>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 06E1616A4DA;
	Fri, 11 Aug 2006 09:48:44 +0000 (UTC)
	(envelope-from root@catv-50635cb6.catv.broadband.hu)
Received: from catv-50635cb6.catv.broadband.hu (catv-50635cb6.catv.broadband.hu [80.99.92.182])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 8270343D46;
	Fri, 11 Aug 2006 09:48:43 +0000 (GMT)
	(envelope-from root@catv-50635cb6.catv.broadband.hu)
Received: by catv-50635cb6.catv.broadband.hu (Postfix, from userid 0)
	id 760E9289D47; Fri, 11 Aug 2006 11:48:42 +0200 (CEST)
Message-Id: <20060811094842.760E9289D47@catv-50635cb6.catv.broadband.hu>
Date: Fri, 11 Aug 2006 11:48:42 +0200 (CEST)
From: Gabor Kovesdan <gabor@FreeBSD.org>
Reply-To: Gabor Kovesdan <gabor@FreeBSD.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc: Gabor Kovesdan <gabor@FreeBSD.org>
Subject: [patch] archivers/dzip
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         101798
>Category:       ports
>Synopsis:       [patch] archivers/dzip
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    danfe
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Fri Aug 11 09:50:13 GMT 2006
>Closed-Date:    Mon Dec 25 22:05:16 GMT 2006
>Last-Modified:  Mon Dec 25 22:05:16 GMT 2006
>Originator:     Gabor Kovesdan
>Release:        FreeBSD 6.1-STABLE i386
>Organization:
n/a
>Environment:
System: FreeBSD spitfire 6.1-STABLE FreeBSD 6.1-STABLE #0: Sat Jul 29 18:31:18 CEST 2006 gabor@spitfire:/usr/src/sys/i386/compile/SPITFIRE i386

>Description:

- Respect DESTDIR
- Don't override MAKE_ARGS, use reinplace edit instead
- Remove a -e where not necessary

>How-To-Repeat:
>Fix:

--- archivers-dzip.diff begins here ---
Index: Makefile
===================================================================
RCS file: /usr/cvs/ports/archivers/dzip/Makefile,v
retrieving revision 1.7
diff -u -r1.7 Makefile
--- Makefile	22 Mar 2006 09:56:34 -0000	1.7
+++ Makefile	11 Aug 2006 09:45:26 -0000
@@ -19,7 +19,6 @@
 
 WRKSRC=		${WRKDIR}
 MAKEFILE=	${WRKSRC}/Makefile.linux
-MAKE_ARGS=	CC="${CC}" CFLAGS="${CFLAGS}"
 ALL_TARGET=	${PORTNAME}
 
 PLIST_FILES=	bin/${PORTNAME}
@@ -28,11 +27,14 @@
 	${REINPLACE_CMD} -e 's/ifdef BIG_ENDIAN/if BYTE_ORDER == BIG_ENDIAN/' \
 		-e 's/ifndef BIG_ENDIAN/if BYTE_ORDER == LITTLE_ENDIAN/' \
 		${WRKSRC}/dzip.h ${WRKSRC}/conmain.c
-	${REINPLACE_CMD} -e '4s,^,#include <machine/endian.h>,' ${WRKSRC}/dzip.h
-	${REINPLACE_CMD} -e 's/) $$(OBJECTS/&:T/' ${MAKEFILE}
+	${REINPLACE_CMD} '4s,^,#include <machine/endian.h>,' ${WRKSRC}/dzip.h
+	${REINPLACE_CMD} -e 's/) $$(OBJECTS/&:T/' \
+		-e 's|CC =|CC ?=|' \
+		-e 's|CFLAGS =|CFLAGS ?=|' \
+		${MAKEFILE}
 	${REINPLACE_CMD} '21d;23d' ${WRKSRC}/dzipcon.h
 
 do-install:
-	${INSTALL_PROGRAM} ${WRKSRC}/${PORTNAME} ${PREFIX}/bin
+	${INSTALL_PROGRAM} ${WRKSRC}/${PORTNAME} ${TARGETDIR}/bin
 
 .include <bsd.port.mk>
--- archivers-dzip.diff ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->danfe 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Fri Aug 11 09:50:20 UTC 2006 
Responsible-Changed-Why:  
Over to maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=101798 

From: =?ISO-8859-1?Q?G=E1bor_K=F6vesd=E1n?= <gabor@FreeBSD.org>
To: bug-followup@FreeBSD.org,  gabor@FreeBSD.org
Cc:  
Subject: Re: ports/101798: [patch] archivers/dzip
Date: Mon, 04 Sep 2006 17:31:18 +0200

 The DESTDIR part of the patch should not be committed, since the new 
 nullfs-based DESTDIR implementation is being worked on as discussed on 
 ports@.
 
 -- 
 Cheers,
 
 Gabor
 

From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: bug-followup@FreeBSD.org, gabor@FreeBSD.org
Cc:  
Subject: Re: ports/101798: [patch] archivers/dzip
Date: Thu, 7 Sep 2006 12:25:51 +0000

 Could you please elaborate on why overriding MAKE_ARGS should be avoided
 here?  Thanks.

From: =?UTF-8?B?R8OhYm9yIEvDtnZlc2TDoW4=?= <gabor@FreeBSD.org>
To: Alexey Dokuchaev <danfe@FreeBSD.org>
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/101798: [patch] archivers/dzip
Date: Fri, 08 Sep 2006 15:52:42 +0200

 Alexey Dokuchaev wrote:
 > Could you please elaborate on why overriding MAKE_ARGS should be avoided
 > here?  Thanks.
 >   
 Hi,
 
 it was rather a suggestion, not a request. I think it is easier to read 
 and reinplace edit is used in most cases for this. It only makes sense 
 if MAKE_ARGS changes in bsd.port.mk, so you can ignore it, this was just 
 my opinion. The main feature was the DESTDIR support in this PR, which 
 is pointless now, since we will follow an another way.
 
 -- 
 Cheers,
 
 Gabor
 

From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: G??bor K??vesd??n <gabor@FreeBSD.org>
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/101798: [patch] archivers/dzip
Date: Fri, 8 Sep 2006 14:07:23 +0000

 On Fri, Sep 08, 2006 at 03:52:42PM +0200, G??bor K??vesd??n wrote:
 > Alexey Dokuchaev wrote:
 > >Could you please elaborate on why overriding MAKE_ARGS should be avoided
 > >here?  Thanks.
 > >  
 > Hi,
 > 
 > it was rather a suggestion, not a request. I think it is easier to read 
 > and reinplace edit is used in most cases for this. It only makes sense 
 > if MAKE_ARGS changes in bsd.port.mk, so you can ignore it, this was just 
 > my opinion. The main feature was the DESTDIR support in this PR, which 
 > is pointless now, since we will follow an another way.
 
 Well, if you don't mind, let's leave the things as they are now, for the
 sake of being easy on repo.  ;-)
 
 ./danfe
State-Changed-From-To: open->closed 
State-Changed-By: gabor 
State-Changed-When: Mon Dec 25 22:03:29 UTC 2006 
State-Changed-Why:  
This was my PR and we discussed that this can be closed, since it's irrelevant. 
I hope you don't mind that I'm closing this. 

Regards, 
Gabor 

http://www.freebsd.org/cgi/query-pr.cgi?pr=101798 
>Unformatted:
