From nobody@FreeBSD.org  Tue Aug  8 04:05:01 2006
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 66EF516A4E5
	for <freebsd-gnats-submit@FreeBSD.org>; Tue,  8 Aug 2006 04:05:01 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 0A98443D53
	for <freebsd-gnats-submit@FreeBSD.org>; Tue,  8 Aug 2006 04:05:01 +0000 (GMT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id k78450EE080674
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 8 Aug 2006 04:05:00 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id k78450hM080673;
	Tue, 8 Aug 2006 04:05:00 GMT
	(envelope-from nobody)
Message-Id: <200608080405.k78450hM080673@www.freebsd.org>
Date: Tue, 8 Aug 2006 04:05:00 GMT
From: Michael Metzger <mmetzger@mv-research.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: e16editmenu wrong path to file.menu - patch attached
X-Send-Pr-Version: www-2.3

>Number:         101623
>Category:       ports
>Synopsis:       e16editmenu wrong path to file.menu - patch attached
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    alepulver
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Aug 08 04:10:19 GMT 2006
>Closed-Date:    Wed Oct 04 21:23:28 GMT 2006
>Last-Modified:  Wed Oct  4 21:30:18 GMT 2006
>Originator:     Michael Metzger
>Release:        Freebsd 6.1 Release-p2
>Organization:
Marketvision Research
>Environment:
FreeBSD fireball.msquared.com 6.1-RELEASE-p2 FreeBSD 6.1-RELEASE-p2 #0: Wed Jun 21 01:37:43 EST 2006     root@fireball.msquared.com:/usr/obj/usr/src/sys/GENERIC  i38
>Description:
Port /usr/ports/x11-wm/e16utils/ assumes enlightenment window manager user has the following path to menu file for enlightenment.  But, after building enlightenment window manager this directory structure is not there.  

Bad file menu path:
/home/<username>/.enlightenment/file.menu 

Correct file menu path should be:
/home/<username>/.e16/menus/file.menu

Patch to fix port will be listed below.
>How-To-Repeat:
-Build and install /usr/ports/x11-wm/enlightenment/ --version 0.16.8.1  

-Build and install /usr/ports/x11-wm/e16utils/      --version 0.16

-Run from xterm e16editmenu

Output is this:

hmm. looks like you have some "issues" as you don't have
a /home/mmetzger/.enlightenment/file.menu file.  Sucks to be you
>Fix:
Patch proposed:

--- viewer_new.c        Mon Aug  7 23:29:16 2006
+++ viewer.c    Mon Aug  7 23:34:38 2006
@@ -34,7 +34,7 @@
   if (!file_to_load)
     return;
   if (file_to_load[0] != '/')
-    sprintf (buf, "%s/.enlightenment/%s", homedir (getuid ()), file_to_load);
+    sprintf (buf, "%s/.e16/menus/%s", homedir (getuid ()), file_to_load);
   else
     sprintf (buf, "%s", file_to_load);
 
@@ -108,7 +108,7 @@
   GtkCTreeNode *parent = NULL;
 
   /* currently hardcoded, but not a big issue to change later */
-  sprintf (buf, "%s/.enlightenment/file.menu", homedir (getuid ()));
+  sprintf (buf, "%s/.e16/menus/file.menu", homedir (getuid ()));
   menufile = fopen (buf, "r");
   if (!menufile)
     {
@@ -564,7 +564,7 @@
   gint retval = 0;
 
   buf =
-    g_strjoin ("/", homedir (getuid ()), ".enlightenment", "file.menu", NULL);
+    g_strjoin ("/", homedir (getuid ()), ".e16/menus", "file.menu", NULL);
 
   node =
     gtk_ctree_export_to_gnode (GTK_CTREE (ctree), NULL, NULL,
@@ -683,7 +683,7 @@
     {
       /* Tarnation! A relative path */
       realfile =
-       g_strjoin ("/", homedir (getuid ()), ".enlightenment", file, NULL);
+       g_strjoin ("/", homedir (getuid ()), ".e16/menus", file, NULL);
     }
   else
     realfile = g_strdup (file);
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->alepulver 
Responsible-Changed-By: alepulver 
Responsible-Changed-When: Wed Oct 4 20:37:27 UTC 2006 
Responsible-Changed-Why:  
Take PR. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=101623 
State-Changed-From-To: open->closed 
State-Changed-By: alepulver 
State-Changed-When: Wed Oct 4 21:23:16 UTC 2006 
State-Changed-Why:  
Committed, thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=101623 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/101623: commit references a PR
Date: Wed,  4 Oct 2006 21:23:13 +0000 (UTC)

 alepulver    2006-10-04 21:23:07 UTC
 
   FreeBSD ports repository
 
   Modified files:
     x11-wm/e16utils      Makefile 
     x11-wm/e16utils/files patch-e16menuedit-0.1 
   Log:
   - Fix wrong paths (~/.enlightenment/file.menu -> ~/.e16/menus/file.menu).
   - Bump PORTREVISION.
   
   PR:             ports/101623
   Submitted by:   Michael Metzger <mmetzger@mv-research.com>
   
   Revision  Changes    Path
   1.16      +1 -1      ports/x11-wm/e16utils/Makefile
   1.4       +39 -1     ports/x11-wm/e16utils/files/patch-e16menuedit-0.1
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
