From rsmith@xs4all.nl  Thu Aug  3 19:44:28 2006
Return-Path: <rsmith@xs4all.nl>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id EB0C216A58D
	for <FreeBSD-gnats-submit@freebsd.org>; Thu,  3 Aug 2006 19:44:27 +0000 (UTC)
	(envelope-from rsmith@xs4all.nl)
Received: from smtp-vbr9.xs4all.nl (smtp-vbr9.xs4all.nl [194.109.24.29])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 098BB43D49
	for <FreeBSD-gnats-submit@freebsd.org>; Thu,  3 Aug 2006 19:44:26 +0000 (GMT)
	(envelope-from rsmith@xs4all.nl)
Received: from slackbox.xs4all.nl (slackbox.xs4all.nl [213.84.242.160])
	by smtp-vbr9.xs4all.nl (8.13.6/8.13.6) with ESMTP id k73JiPFL094401
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 3 Aug 2006 21:44:25 +0200 (CEST)
	(envelope-from rsmith@xs4all.nl)
Received: by slackbox.xs4all.nl (Postfix, from userid 1001)
	id 39727B854; Thu,  3 Aug 2006 21:44:25 +0200 (CEST)
Message-Id: <20060803194425.39727B854@slackbox.xs4all.nl>
Date: Thu,  3 Aug 2006 21:44:25 +0200 (CEST)
From: Roland Smith <rsmith@xs4all.nl>
Reply-To: Roland Smith <rsmith@xs4all.nl>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [patch] games/tyrquake doesn't build on amd64.
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         101328
>Category:       ports
>Synopsis:       [patch] games/tyrquake doesn't build on amd64.
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    alepulver
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Aug 03 19:50:10 GMT 2006
>Closed-Date:    Thu Aug 03 23:23:58 GMT 2006
>Last-Modified:  Thu Aug 03 23:23:58 GMT 2006
>Originator:     Roland Smith
>Release:        FreeBSD 6.1-STABLE amd64
>Organization:
>Environment:
System: FreeBSD slackbox.xs4all.nl 6.1-STABLE FreeBSD 6.1-STABLE #0: Tue May 9 22:46:51 CEST 2006 rsmith@slackbox.xs4all.nl:/usr/obj/usr/src/sys/RFS amd64


	
>Description:
	tyrquake doesn't build on amd64. This is due to a bug in the
	makefile. The make environment flag NO_X86_ASM=YES is set when
	the WITHOUT_X86_ASM is _not_ set. 
>How-To-Repeat:
	Try building the code with the option X86_ASM set to off on amd64.
>Fix:

- Set WITHOUT_X86_ASM="yes" on every architecture != i386
- Fix the test.

See patch below:
-------- patch for /usr/ports/games/tyrquake/Makefile --------
--- Makefile.orig	Thu Aug  3 21:25:51 2006
+++ Makefile	Thu Aug  3 21:36:54 2006
@@ -26,11 +26,15 @@
 
 .include <bsd.port.pre.mk>
 
+.if ${ARCH} != i386
+WITHOUT_X86_ASM="yes"
+.endif
+
 .if !defined(WITHOUT_OPTIMIZED_CFLAGS)
 MAKE_ENV+=	OPTIMIZED_CFLAGS=YES
 .endif
 
-.if !defined(WITHOUT_X86_ASM)
+.if defined(WITHOUT_X86_ASM)
 MAKE_ENV+=	NO_X86_ASM=YES
 .endif
 
-------- patch for /usr/ports/games/tyrquake/Makefile --------

Maybe this bug should be marked critical for all the quake addicts out
there? ;-)
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->alepulver 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Thu Aug 3 19:50:21 UTC 2006 
Responsible-Changed-Why:  
Over to maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=101328 
State-Changed-From-To: open->closed 
State-Changed-By: alepulver 
State-Changed-When: Thu Aug 3 23:23:03 UTC 2006 
State-Changed-Why:  
Committed (changes merged into the same line), thanks. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=101328 
>Unformatted:
