From hashiz@tomba.meridiani.jp  Mon Jul 24 10:15:52 2006
Return-Path: <hashiz@tomba.meridiani.jp>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 887B116A4DA
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 24 Jul 2006 10:15:52 +0000 (UTC)
	(envelope-from hashiz@tomba.meridiani.jp)
Received: from tomba.meridiani.jp (221x245x15x82.ap221.ftth.ucom.ne.jp [221.245.15.82])
	by mx1.FreeBSD.org (Postfix) with ESMTP id F1FB343D49
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 24 Jul 2006 10:15:51 +0000 (GMT)
	(envelope-from hashiz@tomba.meridiani.jp)
Received: from tomba.meridiani.jp (localhost.meridiani.jp [127.0.0.1])
	by tomba.meridiani.jp (8.13.6/8.13.6) with ESMTP id k6OAFj2D017645
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 24 Jul 2006 19:15:45 +0900 (JST)
	(envelope-from hashiz@tomba.meridiani.jp)
Received: (from hashiz@localhost)
	by tomba.meridiani.jp (8.13.6/8.13.6/Submit) id k6OAFj94017640;
	Mon, 24 Jul 2006 19:15:45 +0900 (JST)
	(envelope-from hashiz)
Message-Id: <200607241015.k6OAFj94017640@tomba.meridiani.jp>
Date: Mon, 24 Jul 2006 19:15:45 +0900 (JST)
From: HASHI Hiroaki <hashiz@tomba.meridiani.jp>
Reply-To: HASHI Hiroaki <hashiz@tomba.meridiani.jp>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: port submit(devel/porttools) cannot parse multible options
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         100771
>Category:       ports
>Synopsis:       port submit (ports-mgmt/porttools) cannot parse multiple options
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    amdmi3
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jul 24 10:20:20 GMT 2006
>Closed-Date:    Tue Sep 23 13:36:29 UTC 2008
>Last-Modified:  Tue Sep 23 13:40:09 UTC 2008
>Originator:     HASHI Hiroaki
>Release:        FreeBSD 6.1-STABLE i386
>Organization:
>Environment:
System: FreeBSD tomba.meridiani.jp 6.1-STABLE FreeBSD 6.1-STABLE #1: Wed Jul 19 13:24:55 JST 2006 hashiz@tomba.meridiani.jp:/usr/obj/usr/src/sys/TOMBA i386


	porttools-0.77
>Description:
	port submit(devel/porttools) cannot parse multible options.
>How-To-Repeat:

	tomba# popd
	/usr/ports/mail/p5-Email-MIME-Creator 
	tomba# port submit -m update -d .orig
	===> Validating port with portlint
	WARN: no CVS directories. Use -N to check a new port.
	0 fatal errors and 1 warning found.
	Original version does not exist at /usr/ports/mail/p5-Email-MIME-Creator--
>Fix:

	A parse code of getopt's result is wrong.
	Is this a script's problem? (or /bin/sh's problem?)


diff -u porttools.orig/cmd_commit porttools/cmd_commit
--- porttools.orig/cmd_commit	Mon Jul 24 19:00:26 2006
+++ porttools/cmd_commit	Mon Jul 24 19:09:18 2006
@@ -61,9 +61,9 @@
 fi
 
 set -- $ARGS
-for i 
+while [ x"$1" != x"--" -a x"$1" != x"" ]
 do
-	case "$i" in
+	case "$1" in
 	# help
 	-h)
 		usage
diff -u porttools.orig/cmd_diff porttools/cmd_diff
--- porttools.orig/cmd_diff	Mon Jul 24 19:00:26 2006
+++ porttools/cmd_diff	Mon Jul 24 19:09:18 2006
@@ -65,9 +65,9 @@
 fi
 
 set -- $ARGS
-for i 
+while [ x"$1" != x"--" -a x"$1" != x"" ]
 do
-	case "$i" in
+	case "$1" in
 	# help
 	-h)
 		usage
diff -u porttools.orig/cmd_install porttools/cmd_install
--- porttools.orig/cmd_install	Mon Jul 24 19:00:26 2006
+++ porttools/cmd_install	Mon Jul 24 19:09:18 2006
@@ -64,9 +64,9 @@
 fi
 
 set -- $ARGS
-for i 
+while [ x"$1" != x"--" -a x"$1" != x"" ]
 do
-	case "$i" in
+	case "$1" in
 	# help
 	-h)
 		usage
diff -u porttools.orig/cmd_submit porttools/cmd_submit
--- porttools.orig/cmd_submit	Mon Jul 24 19:00:26 2006
+++ porttools/cmd_submit	Mon Jul 24 19:09:18 2006
@@ -80,9 +80,9 @@
 fi
 
 set -- $ARGS
-for i 
+while [ x"$1" != x"--" -a x"$1" != x"" ]
 do
-	case "$i" in
+	case "$1" in
 	# help
 	-h)
 		usage
diff -u porttools.orig/cmd_test porttools/cmd_test
--- porttools.orig/cmd_test	Mon Jul 24 19:00:26 2006
+++ porttools/cmd_test	Mon Jul 24 19:09:18 2006
@@ -72,9 +72,9 @@
 fi
 
 set -- $ARGS
-for i 
+while [ x"$1" != x"--" -a x"$1" != x"" ]
 do
-	case "$i" in
+	case "$1" in
 	-h)	# help
 		usage
 		exit 0
diff -u porttools.orig/cmd_upgrade porttools/cmd_upgrade
--- porttools.orig/cmd_upgrade	Mon Jul 24 19:00:26 2006
+++ porttools/cmd_upgrade	Mon Jul 24 19:09:18 2006
@@ -64,9 +64,9 @@
 fi
 
 set -- $ARGS
-for i 
+while [ x"$1" != x"--" -a x"$1" != x"" ]
 do
-	case "$i" in
+	case "$1" in
 	# help
 	-h)
 		usage

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->sergei 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Mon Jul 24 10:20:28 UTC 2006 
Responsible-Changed-Why:  
Over to maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=100771 
Responsible-Changed-From-To: sergei->freebsd-ports-bugs 
Responsible-Changed-By: linimon 
Responsible-Changed-When: Sun Jul 27 05:59:48 UTC 2008 
Responsible-Changed-Why:  
Maintainer was reset. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=100771 
Responsible-Changed-From-To: freebsd-ports-bugs->amdmi3 
Responsible-Changed-By: amdmi3 
Responsible-Changed-When: Fri Sep 12 16:33:41 UTC 2008 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=100771 

From: Dmitry Marakasov <amdmi3@amdmi3.ru>
To: bug-followup@FreeBSD.org
Cc: HASHI Hiroaki <hashiz@tomba.meridiani.jp>
Subject: Re: ports/100771: port submit (ports-mgmt/porttools) cannot parse
	multiple options
Date: Fri, 12 Sep 2008 21:11:06 +0400

 > Synopsis: port submit (ports-mgmt/porttools) cannot parse multiple options
 > 
 > http://www.freebsd.org/cgi/query-pr.cgi?pr=100771
 Sorry for the delay :))
 
 Does the patch attached work for you?
 
 --- porttools.patch begins here ---
 Index: Makefile
 ===================================================================
 RCS file: /home/pcvs/ports/ports-mgmt/porttools/Makefile,v
 retrieving revision 1.21
 diff -u -r1.21 Makefile
 --- Makefile	27 Jul 2008 07:40:01 -0000	1.21
 +++ Makefile	12 Sep 2008 17:09:51 -0000
 @@ -7,7 +7,7 @@
  
  PORTNAME=	porttools
  PORTVERSION=	0.77
 -PORTREVISION=	1
 +PORTREVISION=	2
  CATEGORIES=	ports-mgmt
  MASTER_SITES=	SF
  
 Index: files/patch-arguments-parsing
 ===================================================================
 RCS file: files/patch-arguments-parsing
 diff -N files/patch-arguments-parsing
 --- /dev/null	1 Jan 1970 00:00:00 -0000
 +++ files/patch-arguments-parsing	12 Sep 2008 17:09:51 -0000
 @@ -0,0 +1,90 @@
 +diff -ruN cmd_commit.in.orig cmd_commit.in
 +--- cmd_commit.in.orig	2006-05-06 15:31:58.000000000 +0400
 ++++ cmd_commit.in	2008-09-12 21:02:21.000000000 +0400
 +@@ -33,8 +33,9 @@
 + fi
 + 
 + set -- $ARGS
 +-for i 
 +-do
 ++while [ x"" != x"--" -a x"" != x"" ]
 ++do
 ++	i=$1
 + 	case "$i" in
 + 	# help
 + 	-h)
 +diff -ruN cmd_diff.in.orig cmd_diff.in
 +--- cmd_diff.in.orig	2006-05-06 15:31:58.000000000 +0400
 ++++ cmd_diff.in	2008-09-12 21:02:21.000000000 +0400
 +@@ -37,8 +37,9 @@
 + fi
 + 
 + set -- $ARGS
 +-for i 
 +-do
 ++while [ x"" != x"--" -a x"" != x"" ]
 ++do
 ++	i=$1
 + 	case "$i" in
 + 	# help
 + 	-h)
 +diff -ruN cmd_install.in.orig cmd_install.in
 +--- cmd_install.in.orig	2006-05-06 15:31:58.000000000 +0400
 ++++ cmd_install.in	2008-09-12 21:02:21.000000000 +0400
 +@@ -36,8 +36,9 @@
 + fi
 + 
 + set -- $ARGS
 +-for i 
 +-do
 ++while [ x"" != x"--" -a x"" != x"" ]
 ++do
 ++	i=$1
 + 	case "$i" in
 + 	# help
 + 	-h)
 +diff -ruN cmd_submit.in.orig cmd_submit.in
 +--- cmd_submit.in.orig	2006-05-06 15:31:58.000000000 +0400
 ++++ cmd_submit.in	2008-09-12 21:02:21.000000000 +0400
 +@@ -52,8 +52,9 @@
 + fi
 + 
 + set -- $ARGS
 +-for i 
 +-do
 ++while [ x"" != x"--" -a x"" != x"" ]
 ++do
 ++	i=$1
 + 	case "$i" in
 + 	# help
 + 	-h)
 +diff -ruN cmd_test.in.orig cmd_test.in
 +--- cmd_test.in.orig	2006-05-06 15:31:58.000000000 +0400
 ++++ cmd_test.in	2008-09-12 21:02:21.000000000 +0400
 +@@ -44,8 +44,9 @@
 + fi
 + 
 + set -- $ARGS
 +-for i 
 +-do
 ++while [ x"" != x"--" -a x"" != x"" ]
 ++do
 ++	i=$1
 + 	case "$i" in
 + 	-h)	# help
 + 		usage
 +diff -ruN cmd_upgrade.in.orig cmd_upgrade.in
 +--- cmd_upgrade.in.orig	2006-05-06 15:31:58.000000000 +0400
 ++++ cmd_upgrade.in	2008-09-12 21:02:21.000000000 +0400
 +@@ -36,8 +36,9 @@
 + fi
 + 
 + set -- $ARGS
 +-for i 
 +-do
 ++while [ x"" != x"--" -a x"" != x"" ]
 ++do
 ++	i=$1
 + 	case "$i" in
 + 	# help
 + 	-h)
 --- porttools.patch ends here ---
 
 -- 
 Dmitry Marakasov   .   55B5 0596 FF1E 8D84 5F56  9510 D35A 80DD F9D2 F77D
 amdmi3@amdmi3.ru  ..:  jabber: amdmi3@jabber.ru    http://www.amdmi3.ru
State-Changed-From-To: open->closed 
State-Changed-By: amdmi3 
State-Changed-When: Tue Sep 23 13:36:28 UTC 2008 
State-Changed-Why:  
Committed, with minor changes. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=100771 

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/100771: commit references a PR
Date: Tue, 23 Sep 2008 13:36:29 +0000 (UTC)

 amdmi3      2008-09-23 13:36:17 UTC
 
   FreeBSD ports repository
 
   Modified files:
     ports-mgmt/porttools Makefile 
   Added files:
     ports-mgmt/porttools/files patch-arguments-parsing 
   Log:
   - Fix commandline arguments handling for some cases (actualy any case when two or more flags are used simultaneously like `port submit -m update -d .orig`)
   
   PR:             100771
   Submitted by:   HASHI Hiroaki <hashiz at tomba dot meridiani dot jp>
   
   Revision  Changes    Path
   1.22      +1 -1      ports/ports-mgmt/porttools/Makefile
   1.1       +90 -0     ports/ports-mgmt/porttools/files/patch-arguments-parsing (new)
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
