From sven@serv7.ilse.net  Mon Jul 24 09:22:13 2006
Return-Path: <sven@serv7.ilse.net>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 2CEAE16A4DE
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 24 Jul 2006 09:22:13 +0000 (UTC)
	(envelope-from sven@serv7.ilse.net)
Received: from serv1.ilse.net (serv1.ilse.net [62.69.160.11])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 0B85E43D5A
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 24 Jul 2006 09:22:11 +0000 (GMT)
	(envelope-from sven@serv7.ilse.net)
Received: from serv7.ilse.net (serv7.ilse.net [10.1.8.17])
	by serv1.ilse.net (8.12.10/8.10.2) with ESMTP id k6O9M6DV065896
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 24 Jul 2006 11:22:06 +0200 (MEST)
Received: (from sven@localhost)
	by serv7.ilse.net (8.13.6/8.11.1) id k6O9M5wZ080272;
	Mon, 24 Jul 2006 11:22:05 +0200 (CEST)
	(envelope-from sven)
Message-Id: <200607240922.k6O9M5wZ080272@serv7.ilse.net>
Date: Mon, 24 Jul 2006 11:22:05 +0200 (CEST)
From: Sven Berkvens-Matthijsse <sven@ilse.net>
Reply-To: Sven Berkvens-Matthijsse <sven@ilse.net>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: [PATCH] Ports audio/libofa can build on FreeBSD 4.x
X-Send-Pr-Version: 3.113
X-GNATS-Notify: alex@foxybanana.com

>Number:         100768
>Category:       ports
>Synopsis:       [PATCH] Ports audio/libofa can build on FreeBSD 4.x
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    garga
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jul 24 09:30:15 GMT 2006
>Closed-Date:    Mon Jul 24 17:26:12 GMT 2006
>Last-Modified:  Mon Jul 24 17:26:12 GMT 2006
>Originator:     Sven Berkvens-Matthijsse
>Release:        FreeBSD 4.11-STABLE i386
>Organization:
ilse media BV
>Environment:
System: FreeBSD serv7.ilse.net 4.11-STABLE FreeBSD 4.11-STABLE #0: Mon May 22 17:02:01 CEST 2006 root@serv7.ilse.net:/extra1/usr_obj/extra1/usr_src/sys/BAROQUE i386


	
>Description:
	The port audio/libofa can, with very minimal patches, work fine on
	FreeBSD 4.x. Currently, it is disabled for FreeBSD 4.x.
>How-To-Repeat:
	Try to install on FreeBSD 4.x.
>Fix:
	Install the following patchfiles to work around the problem. Then,
	remove the FreeBSD 4.x disabler in the Makefile.

============== files/patch-examples::examples.cpp ====================

--- examples/example.cpp.orig	Mon Jul 24 11:09:39 2006
+++ examples/example.cpp	Mon Jul 24 11:09:50 2006
@@ -7,6 +7,8 @@
 
 -------------------------------------------------------------------*/
 
+#include <stdio.h>
+
 #include "protocol.h"
 
 AudioData* loadWaveFile(char *file);

============== files/patch-examples::uselame.cpp ====================

--- examples/uselame.cpp.orig	Mon Jul 24 11:11:58 2006
+++ examples/uselame.cpp	Mon Jul 24 11:12:09 2006
@@ -13,6 +13,8 @@
 #include <sys/wait.h>
 #endif
 
+#include <unistd.h>
+
 AudioData *loadWaveFile(char *file);
 
 //	loadDataUsingLAME

============== files/patch-examples::wavefile.cpp ====================

--- examples/wavefile.cpp.orig	Mon Jul 24 11:13:26 2006
+++ examples/wavefile.cpp	Mon Jul 24 11:13:05 2006
@@ -11,6 +11,7 @@
 #include "io.h"
 #endif
 #include <fcntl.h>
+#include <unistd.h>
 
 static bool readBytes(int fd, unsigned char *buf, int size) {
     int ct = 0;
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Mon Jul 24 09:30:23 UTC 2006 
State-Changed-Why:  
Awaiting maintainers feedback 

http://www.freebsd.org/cgi/query-pr.cgi?pr=100768 

From: Alexander Botero-Lowry <alex@foxybanana.com>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/100768: [PATCH] Ports audio/libofa can build on FreeBSD
 4.x
Date: Mon, 24 Jul 2006 04:49:18 -0500 (CDT)

 I'm cool with this patch. Thank you for taking the time to fix this, I was 
 too lazy to do anything about 4.x support.
 
 Alex
 
 On Mon, 24 Jul 2006, Edwin Groothuis wrote:
 
 > Maintainer of audio/libofa,
 >
 > Please note that PR ports/100768 has just been submitted.
 >
 > If it contains a patch for an upgrade, an enhancement or a bug fix
 > you agree on, reply to this email stating that you approve the patch
 > and a committer will take care of it.
 >
 > The full text of the PR can be found at:
 >    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/100768
 >
 > -- 
 > Edwin Groothuis
 > edwin@FreeBSD.org
 >
 > !DSPAM:4,44c4933f47927025561932!
 >
 >
 >
Responsible-Changed-From-To: freebsd-ports-bugs->garga 
Responsible-Changed-By: garga 
Responsible-Changed-When: Mon Jul 24 15:51:28 UTC 2006 
Responsible-Changed-Why:  
I'll take it. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=100768 
State-Changed-From-To: feedback->closed 
State-Changed-By: garga 
State-Changed-When: Mon Jul 24 17:26:10 UTC 2006 
State-Changed-Why:  
Committed. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=100768 
>Unformatted:
