From alex@foxybanana.com  Mon Jul 10 20:58:28 2006
Return-Path: <alex@foxybanana.com>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 033AC16A4E5;
	Mon, 10 Jul 2006 20:58:28 +0000 (UTC)
	(envelope-from alex@foxybanana.com)
Received: from imf21aec.mail.bellsouth.net (imf21aec.mail.bellsouth.net [205.152.59.69])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 8B9DA43D46;
	Mon, 10 Jul 2006 20:58:20 +0000 (GMT)
	(envelope-from alex@foxybanana.com)
Received: from ibm63aec.bellsouth.net ([68.209.153.178])
          by imf21aec.mail.bellsouth.net with ESMTP
          id <20060710205820.FNQI22787.imf21aec.mail.bellsouth.net@ibm63aec.bellsouth.net>;
          Mon, 10 Jul 2006 16:58:20 -0400
Received: from Laptop.mine.box ([68.209.153.178]) by ibm63aec.bellsouth.net
          with ESMTP
          id <20060710205815.QXSB1324.ibm63aec.bellsouth.net@Laptop.mine.box>;
          Mon, 10 Jul 2006 16:58:15 -0400
Received: from Laptop.mine.box (localhost [127.0.0.1])
	by Laptop.mine.box (8.13.6/8.13.6) with ESMTP id k6AKvmZX005012;
	Mon, 10 Jul 2006 15:57:48 -0500 (CDT)
	(envelope-from alex@localhost.my.domain)
Received: (from alex@localhost)
	by Laptop.mine.box (8.13.6/8.13.6/Submit) id k6AKvlQZ005011;
	Mon, 10 Jul 2006 15:57:47 -0500 (CDT)
	(envelope-from alex)
Message-Id: <200607102057.k6AKvlQZ005011@Laptop.mine.box>
Date: Mon, 10 Jul 2006 15:57:47 -0500 (CDT)
From: Alexander Botero-Lowry <alex@foxybanana.com>
To: FreeBSD-gnats-submit@freebsd.org
Cc: aaron@freebsd.org
Subject: [PATCH] lang/tolua++: update to 1.0.92
X-Send-Pr-Version: 3.113
X-GNATS-Notify: edwin@mavetju.org

>Number:         100042
>Category:       ports
>Synopsis:       [PATCH] lang/tolua++: update to 1.0.92
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    aaron
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          update
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jul 10 21:00:34 GMT 2006
>Closed-Date:    Sat Dec 23 22:09:09 GMT 2006
>Last-Modified:  Sat Dec 23 22:10:15 GMT 2006
>Originator:     Alexander Botero-Lowry
>Release:        FreeBSD 6.1-STABLE i386
>Organization:
>Environment:
System: FreeBSD Laptop.mine.box 6.1-STABLE FreeBSD 6.1-STABLE #0: Mon Jun 26 23:51:33 CDT 2006
>Description:
- Update to 1.0.92
- Convert to bsd.scons.mk which passes in the correct CCFLAGS making this port
  CFLAGS and LDFLAGS safe

Removed file(s):
- files/patch-config_posix.py

Port maintainer (aaron@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.77
>How-To-Repeat:
>Fix:

--- tolua++-1.0.92.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/lang/tolua++/Makefile,v
retrieving revision 1.2
diff -u -r1.2 Makefile
--- Makefile	3 May 2006 13:25:06 -0000	1.2
+++ Makefile	10 Jul 2006 20:56:29 -0000
@@ -6,26 +6,19 @@
 #
 
 PORTNAME=	tolua++
-PORTVERSION=	1.0.4
+PORTVERSION=	1.0.92
 CATEGORIES=	lang devel
 MASTER_SITES=	http://www.codenix.com/~tolua/
-DISTNAME=	tolua++-current
 
 MAINTAINER=	aaron@FreeBSD.org
 COMMENT=	An extended version of tolua, a tool to integrate C/C++ code with Lua
 
-BUILD_DEPENDS=	${LOCALBASE}/bin/scons:${PORTSDIR}/devel/scons
 LIB_DEPENDS=	lua:${PORTSDIR}/lang/lua50
 
-WRKSRC=		${WRKDIR}/tolua++-${PORTVERSION}
 USE_BZIP2=	yes
-INSTALLS_SHLIB=	yes
-NO_BUILD=	yes
+USE_LDCONFIG=	yes
+USE_SCONS=	yes
 
-do-build:
-	@cd ${WRKSRC} && scons
-
-do-install:
-	@cd ${WRKSRC} && scons prefix=${PREFIX} install
+SCONS_ARGS=	prefix=${PREFIX}
 
 .include <bsd.port.mk>
Index: distinfo
===================================================================
RCS file: /home/ncvs/ports/lang/tolua++/distinfo,v
retrieving revision 1.1
diff -u -r1.1 distinfo
--- distinfo	22 Jan 2006 23:42:31 -0000	1.1
+++ distinfo	10 Jul 2006 20:56:29 -0000
@@ -1,3 +1,3 @@
-MD5 (tolua++-current.tar.bz2) = 8785100f7c9d9253cb47b530d97a32f6
-SHA256 (tolua++-current.tar.bz2) = 557d8efd248ca3a9bdb3ed221abd4be2b71010d9463983ec804e20b4b888638c
-SIZE (tolua++-current.tar.bz2) = 171870
+MD5 (tolua++-1.0.92.tar.bz2) = f4682e065b7d6d4de5eec13e6b7d347c
+SHA256 (tolua++-1.0.92.tar.bz2) = fd2199f669d7d7c11f5451001ee1601add263203b2522363b3632411437e4fac
+SIZE (tolua++-1.0.92.tar.bz2) = 153961
Index: files/patch-config_posix.py
===================================================================
RCS file: files/patch-config_posix.py
diff -N files/patch-config_posix.py
--- files/patch-config_posix.py	22 Jan 2006 23:42:31 -0000	1.1
+++ /dev/null	1 Jan 1970 00:00:00 -0000
@@ -1,18 +0,0 @@
---- config_posix.py.orig	Thu Jan 20 20:01:08 2005
-+++ config_posix.py	Wed Jan 18 11:05:32 2006
-@@ -5,7 +5,7 @@
- 
- # flags for the compiler
- #CCFLAGS = []
--CCFLAGS = ['-O2', '-ansi', '-Wall']
-+CCFLAGS = ['-O2', '-ansi', '-Wall', '-I/usr/local/include']
- 
- # this is the default directory for installation. Files will be installed on
- # <prefix>/bin, <prefix>/lib and <prefix>/include when you run 'scons install'
-@@ -17,5 +17,5 @@
- 
- # libraries
- LIBS = ['lua', 'lualib', 'm']
--
-+LINKFLAGS = ['-L/usr/local/lib']
- 
--- tolua++-1.0.92.patch ends here ---

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-ports-bugs->edwin 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Mon Jul 10 21:00:45 UTC 2006 
Responsible-Changed-Why:  
edwin@mavetju.org => edwin@ 

http://www.freebsd.org/cgi/query-pr.cgi?pr=100042 
State-Changed-From-To: open->feedback 
State-Changed-By: edwin 
State-Changed-When: Mon Jul 10 21:00:51 UTC 2006 
State-Changed-Why:  
Awaiting maintainers feedback 

http://www.freebsd.org/cgi/query-pr.cgi?pr=100042 
Responsible-Changed-From-To: edwin->aaron 
Responsible-Changed-By: edwin 
Responsible-Changed-When: Mon Jul 10 22:35:42 UTC 2006 
Responsible-Changed-Why:  
Over to maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=100042 

From: Aaron Dalton <aaron@FreeBSD.org>
To: bug-followup@FreeBSD.org, alex@foxybanana.com
Cc: FreeBSD Ports <ports@freebsd.org>
Subject: Re: ports/100042: [PATCH] lang/tolua++: update to 1.0.92
Date: Fri, 14 Jul 2006 10:07:09 -0600

 -----BEGIN PGP SIGNED MESSAGE-----
 Hash: SHA1
 
 When testing this patch I get the following error:
 
 ===>   Registering installation for lua-5.0.2_1
 ===>   Returning to build of tolua++-1.0.92
 ===>  Configuring for tolua++-1.0.92
 ===>  Building for tolua++-1.0.92
 scons: Reading SConscript files ...
 TypeError: can only concatenate list (not "str") to list:
 *** Error code 2
 
 Stop in /usr/ports/lang/tolua++.
   File "SConstruct", line 131:
     env['LIBPATH'] =  ['#/lib'] + env['LIBPATH']
 
 Seems like an error in the more general USE_SCONS framework.
 
 - --
 Aaron Dalton
 aaron@FreeBSD.org
 FreeBSD Ports Committer
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.4 (MingW32)
 Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
 
 iD8DBQFEt8EtvlYKTYgR0qQRAtmuAJ9LBbn10LhBUdsuBXlmzoFaHlToWwCg1Xj4
 Azy4e+P7Eg+7m/5x/sbME9A=
 =5jHF
 -----END PGP SIGNATURE-----

From: Aaron Dalton <aaron@FreeBSD.org>
To: bug-followup@FreeBSD.org, alex@foxybanana.com
Cc:  
Subject: Re: ports/100042: [PATCH] lang/tolua++: update to 1.0.92
Date: Mon, 24 Jul 2006 13:17:04 -0600

 -----BEGIN PGP SIGNED MESSAGE-----
 Hash: SHA1
 
 Even after adding the following to the port Makefile, I still get an error:
 LIBPATH=	
 LDFLAGS+=	-L${LOCALBASE}/lib
 CFLAGS+=	-I${LOCALBASE}/include
 
 ===>   Returning to build of tolua++-1.0.92
 ===>  Configuring for tolua++-1.0.92
 ===>  Building for tolua++-1.0.92
 scons: Reading SConscript files ...
 TypeError: can only concatenate list (not "str") to list:
 *** Error code 2
 
 Stop in /usr/ports/lang/tolua++.
   File "SConstruct", line 131:
     env['LIBPATH'] =  ['#/lib'] + env['LIBPATH']
 A problem building things on releng5-56
 
 - --
 Aaron Dalton
 aaron@FreeBSD.org
 FreeBSD Ports Committer
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.4 (MingW32)
 Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
 
 iD8DBQFExRywvlYKTYgR0qQRAhG4AKDFZmjH402sxKLmZf8MUv5BW4cRKgCffSN4
 6pDvC/yzmyvOYtaAGj0ketE=
 =BuXq
 -----END PGP SIGNATURE-----

From: Alexander Botero-Lowry <alex@foxybanana.com>
To: Aaron Dalton <aaron@FreeBSD.org>
Cc: bug-followup@FreeBSD.org
Subject: Re: ports/100042: [PATCH] lang/tolua++: update to 1.0.92
Date: Mon, 24 Jul 2006 17:43:38 -0500 (CDT)

 Weird.. When I tinderbuilt it with that earlier it worked fine, but now 
 when I try to do it I get the same error. o.O
 
 Well, so I poked around the SConstruct file and it's a fairly easy fix:
 
 change:
     env['LIBPATH'] =  ['#/lib'] + env['LIBPATH']
 to:
     env['LIBPATH'] =  ['#/lib'] + env['LIBPATH'].split(" ")
 
 This is a bug in tolua++'s SConstruct as far as I'm concerned, since you 
 can't pass a python list in on the commandline. and it's accepting LIBPATH 
 from the command line. Either they should find a way to get a list (like 
 the split trick), or they should not accept from the commandline. 
 Incidentlly adding those search pathes to LIBPATH doesn't seem to fix 
 anything and LDFLAGS+= -L/usr/local/lib and CFLAGS+=/usr/local/include are 
 still needed. So since they don't help anyway you may be better of 
 changing:
     env['LIBPATH'] =  ['#/lib'] + env['LIBPATH']
 to:
     env['LIBPATH'] =  ['#/lib']
 
 It's up to you. I'm just happy to know it's not (entirely) my fault ;)
 
 Alex
 
State-Changed-From-To: feedback->closed 
State-Changed-By: aaron 
State-Changed-When: Sat Dec 23 22:09:07 UTC 2006 
State-Changed-Why:  
Committed, with minor changes. Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=100042 

From: Aaron Dalton <aaron@FreeBSD.org>
To: bug-followup@FreeBSD.org, alex@foxybanana.com
Cc:  
Subject: Re: ports/100042: [PATCH] lang/tolua++: update to 1.0.92
Date: Sat, 23 Dec 2006 15:09:30 -0700

 This is a multi-part message in MIME format.
 --------------080106000205040202020402
 Content-Type: text/plain; charset=ISO-8859-1
 Content-Transfer-Encoding: 7bit
 
 -----BEGIN PGP SIGNED MESSAGE-----
 Hash: SHA1
 
 Sorry for the long hiatus.  Attached is the final diff that seems to
 work.  I'm committing now.
 
 Merry Christmas!
 - --
 Aaron Dalton
 aaron@FreeBSD.org
 FreeBSD Ports Committer
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.4.4 (MingW32)
 Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
 
 iD8DBQFFjakavlYKTYgR0qQRAgwHAJ0a7IPIv+jNQ0Fn2oC2UBv4dW8zSQCfX1Vd
 pzKCNO4LldKXVAE9yrsV4O4=
 =n97X
 -----END PGP SIGNATURE-----
 
 --------------080106000205040202020402
 Content-Type: text/plain;
  name="diff.txt"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline;
  filename="diff.txt"
 
 ===> Updating from CVS
 M Makefile
 M distinfo
 A files/patch-SConstruct
 R files/patch-config_posix.py
 ===> Generating patch
 ===> Viewing diff with more
 Index: Makefile
 ===================================================================
 RCS file: /home/pcvs/ports/lang/tolua++/Makefile,v
 retrieving revision 1.4
 diff -u -u -r1.4 Makefile
 --- Makefile	15 Sep 2006 10:58:52 -0000	1.4
 +++ Makefile	23 Dec 2006 21:54:40 -0000
 @@ -6,31 +6,21 @@
  #
  
  PORTNAME=	tolua++
 -PORTVERSION=	1.0.4
 +PORTVERSION=	1.0.92
  CATEGORIES=	lang devel
  MASTER_SITES=	http://www.codenix.com/~tolua/
 -DISTFILES=	tolua++-current${EXTRACT_SUFX}
  
  MAINTAINER=	aaron@FreeBSD.org
  COMMENT=	An extended version of tolua, a tool to integrate C/C++ code with Lua
  
 -BUILD_DEPENDS=	${LOCALBASE}/bin/scons:${PORTSDIR}/devel/scons
 +LIB_DEPENDS=	lua:${PORTSDIR}/lang/lua50
  
  USE_BZIP2=	yes
  USE_LDCONFIG=	yes
 -USE_LUA=	5.0
 -NO_BUILD=	yes
 +USE_SCONS=	yes
 +SCONS_ARGS=	prefix=${PREFIX}
  
 -post-patch:
 -.for f in LOCALBASE LUA_VER LUA_INCDIR LUA_LIBDIR
 -	@${REINPLACE_CMD} -i "" -e 's|%%${f}%%|${${f}}|g' \
 -		${WRKSRC}/config_posix.py
 -.endfor
 -
 -do-build:
 -	@cd ${WRKSRC} && scons
 -
 -do-install:
 -	@cd ${WRKSRC} && scons prefix=${PREFIX} install
 +CFLAGS+=	-I/usr/local/include/lua50
 +LDFLAGS+=	-L/usr/local/lib/lua50
  
  .include <bsd.port.mk>
 Index: distinfo
 ===================================================================
 RCS file: /home/pcvs/ports/lang/tolua++/distinfo,v
 retrieving revision 1.1
 diff -u -u -r1.1 distinfo
 --- distinfo	22 Jan 2006 23:42:31 -0000	1.1
 +++ distinfo	23 Dec 2006 21:54:40 -0000
 @@ -1,3 +1,3 @@
 -MD5 (tolua++-current.tar.bz2) = 8785100f7c9d9253cb47b530d97a32f6
 -SHA256 (tolua++-current.tar.bz2) = 557d8efd248ca3a9bdb3ed221abd4be2b71010d9463983ec804e20b4b888638c
 -SIZE (tolua++-current.tar.bz2) = 171870
 +MD5 (tolua++-1.0.92.tar.bz2) = f4682e065b7d6d4de5eec13e6b7d347c
 +SHA256 (tolua++-1.0.92.tar.bz2) = fd2199f669d7d7c11f5451001ee1601add263203b2522363b3632411437e4fac
 +SIZE (tolua++-1.0.92.tar.bz2) = 153961
 Index: files/patch-SConstruct
 ===================================================================
 RCS file: files/patch-SConstruct
 diff -N files/patch-SConstruct
 --- /dev/null	1 Jan 1970 00:00:00 -0000
 +++ files/patch-SConstruct	23 Dec 2006 21:54:40 -0000
 @@ -0,0 +1,11 @@
 +--- SConstruct.orig	Sat Dec 23 14:21:33 2006
 ++++ SConstruct	Sat Dec 23 14:21:46 2006
 +@@ -128,7 +128,7 @@
 + ########### end of helper builders
 + 
 + env['CPPPATH'] = '#/include'
 +-env['LIBPATH'] =  ['#/lib'] + env['LIBPATH']
 ++env['LIBPATH'] =  ['#/lib'] + env['LIBPATH'].split(" ")
 + 
 + if env['no_cygwin']:
 + 
 Index: files/patch-config_posix.py
 ===================================================================
 RCS file: files/patch-config_posix.py
 diff -N files/patch-config_posix.py
 --- files/patch-config_posix.py	15 Sep 2006 08:17:09 -0000	1.2
 +++ /dev/null	1 Jan 1970 00:00:00 -0000
 @@ -1,20 +0,0 @@
 ---- ./config_posix.py.orig	Fri Jan 21 00:01:08 2005
 -+++ ./config_posix.py	Sun Aug 27 14:25:40 2006
 -@@ -5,7 +5,7 @@
 - 
 - # flags for the compiler
 - #CCFLAGS = []
 --CCFLAGS = ['-O2', '-ansi', '-Wall']
 -+CCFLAGS = ['-O2', '-ansi', '-Wall', '-I%%LOCALBASE%%/include', '-I%%LUA_INCDIR%%']
 - 
 - # this is the default directory for installation. Files will be installed on
 - # <prefix>/bin, <prefix>/lib and <prefix>/include when you run 'scons install'
 -@@ -16,6 +16,6 @@
 - prefix = '/usr/local'
 - 
 - # libraries
 --LIBS = ['lua', 'lualib', 'm']
 --
 -+LIBS = ['lua-%%LUA_VER%%', 'lualib-%%LUA_VER%%', 'm']
 -+LINKFLAGS = ['-L%%LOCALBASE%%/lib', '-L%%LUA_LIBDIR%%']
 - 
 ===> Done
 
 --------------080106000205040202020402--

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: ports/100042: commit references a PR
Date: Sat, 23 Dec 2006 22:09:39 +0000 (UTC)

 aaron       2006-12-23 22:09:32 UTC
 
   FreeBSD ports repository
 
   Modified files:
     lang/tolua++         Makefile distinfo 
   Added files:
     lang/tolua++/files   patch-SConstruct 
   Removed files:
     lang/tolua++/files   patch-config_posix.py 
   Log:
   Updated to 1.0.92
   
   PR:             100042
   Submitted by:   Alexander Botero-Lowry <alex@foxybanana.com>
   
   Revision  Changes    Path
   1.5       +6 -16     ports/lang/tolua++/Makefile
   1.2       +3 -3      ports/lang/tolua++/distinfo
   1.1       +11 -0     ports/lang/tolua++/files/patch-SConstruct (new)
   1.3       +0 -20     ports/lang/tolua++/files/patch-config_posix.py (dead)
 _______________________________________________
 cvs-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/cvs-all
 To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
 
>Unformatted:
