From peter.jeremy@auss2.alcatel.com.au  Thu Jan 14 21:24:18 1999
Received: from alcanet.com.au (border.alcanet.com.au [203.62.196.10])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id VAA18773
          for <FreeBSD-gnats-submit@FreeBSD.ORG>; Thu, 14 Jan 1999 21:24:16 -0800 (PST)
          (envelope-from peter.jeremy@auss2.alcatel.com.au)
Received: by border.alcanet.com.au id <40343>; Fri, 15 Jan 1999 16:22:02 +1100
Message-Id: <99Jan15.162202est.40343@border.alcanet.com.au>
Date: Fri, 15 Jan 1999 16:22:39 +1100
From: Peter Jeremy <peter.jeremy@auss2.alcatel.com.au>
Reply-To: peter.jeremy@alcatel.com.au
To: FreeBSD-gnats-submit@FreeBSD.ORG
Subject: `edithook' is not Y2K compliant
X-Send-Pr-Version: 3.2

>Number:         9500
>Category:       misc
>Synopsis:       `edithook' is not Y2K compliant
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jan 14 21:30:00 PST 1999
>Closed-Date:    Mon May 3 20:41:30 PDT 1999
>Last-Modified:  Mon May  3 20:43:50 PDT 1999
>Originator:     Peter Jeremy
>Release:        FreeBSD 3.0-CURRENT i386
>Organization:
Alcatel Australia
>Environment:

	

>Description:

The `edithook' script in the CVSROOT directory uses a raw tm_year and
will therefore display 01/01/100 for 2000-JAN-01.

>How-To-Repeat:

Code inspection

>Fix:
	
--- /3.0/CVSROOT/edithook	Tue Mar 28 17:57:13 1995
+++ ./edithook	Fri Jan 15 14:46:37 1999
@@ -276,7 +276,7 @@
 
 sub create_timestamps {
     ($sec,$min,$hour,$mday,$mon,$year) = localtime;
-    $today	= sprintf("%02d/%02d/%02d", $mon+1, $mday, $year);
+    $today	= sprintf("%02d/%02d/%04d", $mon+1, $mday, $year + 1900);
     $nowtime	= sprintf("%02d:%02d:%02d", $hour, $min, $sec);
     $date	= $today . ' ' . $nowtime;
 }

>Release-Note:
>Audit-Trail:

From: "Daniel O'Callaghan" <danny@hilink.com.au>
To: peter.jeremy@alcatel.com.au
Cc: FreeBSD-gnats-submit@FreeBSD.ORG
Subject: Re: misc/9500: `edithook' is not Y2K compliant
Date: Fri, 15 Jan 1999 21:36:16 +1100 (EST)

 On Fri, 15 Jan 1999, Peter Jeremy wrote:
 > >Number:         9500
 > >Category:       misc
 > >Synopsis:       `edithook' is not Y2K compliant
 > 
 > The `edithook' script in the CVSROOT directory uses a raw tm_year and
 > will therefore display 01/01/100 for 2000-JAN-01.
 
 > 	
 > --- /3.0/CVSROOT/edithook	Tue Mar 28 17:57:13 1995
 > +++ ./edithook	Fri Jan 15 14:46:37 1999
 > @@ -276,7 +276,7 @@
 >  
 >  sub create_timestamps {
 >      ($sec,$min,$hour,$mday,$mon,$year) = localtime;
 > -    $today	= sprintf("%02d/%02d/%02d", $mon+1, $mday, $year);
 > +    $today	= sprintf("%02d/%02d/%04d", $mon+1, $mday, $year + 1900);
 >      $nowtime	= sprintf("%02d:%02d:%02d", $hour, $min, $sec);
 >      $date	= $today . ' ' . $nowtime;
 
 This should really be
 
     $today	= sprintf("%d/%02d/%02d", $year + 1900, $mon+1, $mday);
 
 ie. yyyy/mm/dd, not mm/dd/yyyy
 
 Any objections to changing the log date format thus?
 

From: Tim Vanderhoek <vanderh@ecf.utoronto.ca>
To: Bill Fumerola <billf@jade.chc-chimes.com>
Cc: "Daniel O'Callaghan" <danny@hilink.com.au>,
        freebsd-gnats-submit@FreeBSD.ORG
Subject: Re: misc/9500: `edithook' is not Y2K compliant
Date: Fri, 15 Jan 1999 17:03:26 -0500

 On Fri, Jan 15, 1999 at 12:47:07PM -0500, Bill Fumerola wrote:
 > 
 > >      $today	= sprintf("%d/%02d/%02d", $year + 1900, $mon+1, $mday);
 > >  ie. yyyy/mm/dd, not mm/dd/yyyy
 > >  
 > >  Any objections to changing the log date format thus?
 > 
 > Yes. What is your foundation for the new format? Perhaps this is just my
 > American citizenship coming through, but mm/dd/yyyy is the way most people
 
 Which is really just a good argument for converting it to something
 that is (relatively) internationalization-neutral.
 
 
 -- 
 This .sig is not innovative, witty, or profund.
State-Changed-From-To: open->closed 
State-Changed-By: nrahlstr 
State-Changed-When: Mon May 3 20:41:30 PDT 1999 
State-Changed-Why:  
Fixed in revision 1.2 by danny@FreeBSD.org. 
>Unformatted:
