From nobody  Mon Sep 14 03:27:17 1998
Received: (from nobody@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id DAA14681;
          Mon, 14 Sep 1998 03:27:17 -0700 (PDT)
          (envelope-from nobody)
Message-Id: <199809141027.DAA14681@hub.freebsd.org>
Date: Mon, 14 Sep 1998 03:27:17 -0700 (PDT)
From: sp@alkor.ru
To: freebsd-gnats-submit@freebsd.org
Subject: Probable weak code /usr/bin/cksum
X-Send-Pr-Version: www-1.0

>Number:         7926
>Category:       misc
>Synopsis:       [MFC] Probable weak code /usr/bin/cksum
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    des
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Sep 14 03:30:00 PDT 1998
>Closed-Date:    Tue Sep 22 15:19:35 PDT 1998
>Last-Modified:  Tue Sep 22 15:20:49 PDT 1998
>Originator:     Sergey Potapov
>Release:        2.2.6-RELEASE
>Organization:
Alkor Telecom SPb Russia
>Environment:
FreeBSD ws.alkor.ru 2.2.6-RELEASE FreeBSD 2.2.6-RELEASE #0: Fri Apr  3 16:50:57 MSD 1998     sp@backup.alkor.ru:/usr/src/sys/compile/WORKSTAT  i386

>Description:
the code (/usr/src/usr.bin/cksum/crc32.c):

    while ((nr = read(fd, buf, sizeof(buf))))
        for (len += nr, p = buf; nr--; ++p) {
            CRC(crc, *p) ;
            CRC(crc32_total, *p) ;
        }
    if (nr < 0)
        return 1 ;

IMHO may cause infinite loop or crash of utility.
I cannot predict results if read(2) will return -1 everytime.
I did not check other modules there.
>How-To-Repeat:

>Fix:
Probably should use:

    while ((nr = read(fd, buf, sizeof(buf))) > 0)

instead of:

    while ((nr = read(fd, buf, sizeof(buf))))

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->suspended 
State-Changed-By: des 
State-Changed-When: Wed Sep 16 08:53:47 PDT 1998 
State-Changed-Why:  
Fixed in -CURRENT. 


Responsible-Changed-From-To: freebsd-bugs->des 
Responsible-Changed-By: des 
Responsible-Changed-When: Wed Sep 16 08:53:47 PDT 1998 
Responsible-Changed-Why:  
So I get the blame if it's wrong. 
State-Changed-From-To: suspended->closed 
State-Changed-By: des 
State-Changed-When: Tue Sep 22 15:19:35 PDT 1998 
State-Changed-Why:  
MFC 
>Unformatted:
