From matthias.andree@gmx.de  Wed Mar 10 15:53:41 2004
Return-Path: <matthias.andree@gmx.de>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 3A83316A4CE; Wed, 10 Mar 2004 15:53:41 -0800 (PST)
Received: from mail.dt.e-technik.uni-dortmund.de (mail.dt.E-Technik.Uni-Dortmund.DE [129.217.163.1])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id C8CF243D2D; Wed, 10 Mar 2004 15:53:40 -0800 (PST)
	(envelope-from matthias.andree@gmx.de)
Received: from m2a2.dyndns.org (krusty.dt.e-technik.uni-dortmund.de [129.217.163.1])
	by mail.dt.e-technik.uni-dortmund.de (Postfix) with ESMTP id D0AFB23D94;
	Thu, 11 Mar 2004 00:53:39 +0100 (CET)
Received: from localhost (localhost [127.0.0.1])
	by merlin.emma.line.org (Postfix) with ESMTP id DA1BF1CF0;
	Thu, 11 Mar 2004 00:53:36 +0100 (CET)
Received: from merlin.emma.line.org ([127.0.0.1])
 by localhost (m2a2.dyndns.org [127.0.0.1]) (amavisd-new, port 10024)
 with LMTP id 29212-03; Thu, 11 Mar 2004 00:53:36 +0100 (CET)
Received: from sigma.emma.line.org (sigma.emma.line.org [192.168.0.49])
	by merlin.emma.line.org (Postfix) with ESMTP id 56651DE7;
	Thu, 11 Mar 2004 00:53:36 +0100 (CET)
Received: by sigma.emma.line.org (Postfix, from userid 500)
	id 1C3AC5C33; Thu, 11 Mar 2004 00:53:36 +0100 (CET)
Message-Id: <20040310235336.1C3AC5C33@sigma.emma.line.org>
Date: Thu, 11 Mar 2004 00:53:36 +0100 (CET)
From: Matthias Andree <matthias.andree@gmx.de>
To: FreeBSD-gnats-submit@freebsd.org
Cc: current@freebsd.org, net@freebsd.org, gshapiro@freebsd.org,
	peter@freebsd.org, Max Laier <max@love2party.net>
Subject: PATCH: Makefile.inc1 r1.411 jams make installworld 
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         64073
>Category:       misc
>Synopsis:       PATCH: Makefile.inc1 r1.411 jams make installworld
>Confidential:   no
>Severity:       critical
>Priority:       low
>Responsible:    mlaier
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Mar 10 16:00:36 PST 2004
>Closed-Date:    Fri Mar 12 06:17:46 PST 2004
>Last-Modified:  Fri Mar 12 06:17:46 PST 2004
>Originator:     Matthias Andree
>Release:        FreeBSD 5.2-CURRENT i386
>Organization:
>Environment:
System: FreeBSD sigma.emma.line.org 5.2-CURRENT FreeBSD 5.2-CURRENT #3: Wed Mar 10 22:29:45 CET 2004 root@sigma.emma.line.org:/usr/src/sys/i386/compile/SIGMA i386


	
>Description:
"make installworld" fails, complaining the required authpf group was missing:

-bash-2.05b# grep -w authpf /etc/group
authpf:*:63:
-bash-2.05b# make installworld
id: authpf: no such user
ERROR: Required authpf group is missing, see /usr/src/UPDATING.
*** Error code 1

Cause: The recent Makefile.inc1 change in rev. 1.411 of that file is
bogus, it is a copy of a bogus line further up in the file that was
shadowed by a mandatory user account with the same name as the group
that was supposed to be checked.

"id -g authpf" does not check if a *group* "authpf" exists but returns the
primary group ID of the *user* "authpf". Result as above.

Looking closer, the same problem applies to the "id -g smmsp" check that used
to be fine (albeit inefficient) but was repaired broken in revision 1.376 on
2003-07-06 by gshapiro after suggestion from peter.

I am suggesting the patch below that checks /etc/group with grep and then NIS
with ypmatch. This is a bit ugly but will serve for now.

A more complex but nsswitch-proof alternative would be to create a dummy
file, for instance:
echo "delete me" >${DECENTPATH}/dummy$$
chgrp smmsp ${DECENTPATH}/dummy$$

DECENTPATH should be somewhere writable below the installation location,
it won't hurt there, or in a temporary directory that is not prone to
symlink attacks (i. e. that is not world writable).

	
>How-To-Repeat:
Update the FreeBSD -CURRENT base system as usual.
	
>Fix:

	
Patch /usr/src/Makefile.inc1 as follows:

--- Makefile.inc1~	Wed Mar 10 22:10:11 2004
+++ Makefile.inc1	Thu Mar 11 00:35:58 2004
@@ -409,25 +409,28 @@
 #
 installcheck: ${SPECIAL_INSTALLCHECKS}
 .if !defined(NO_SENDMAIL)
-	@if ! `id -u smmsp > /dev/null`; then \
+	@if ! id -u smmsp > /dev/null; then \
 		echo "ERROR: Required smmsp user is missing, see /usr/src/UPDATING."; \
 		false; \
 	fi
-	@if ! `id -g smmsp > /dev/null`; then \
+	@if ! grep '^smmsp:' /etc/group > /dev/null \
+	 && ! ypmatch smmsp group >/dev/null ; then \
 		echo "ERROR: Required smmsp group is missing, see /usr/src/UPDATING."; \
 		false; \
 	fi
 .endif
 .if !defined(NO_PF)
-	@if ! `id -u proxy > /dev/null`; then \
+	@if ! id -u proxy > /dev/null; then \
 		echo "ERROR: Required proxy user is missing, see /usr/src/UPDATING."; \
 		false; \
 	fi
-	@if ! `id -g proxy > /dev/null`; then \
+	@if ! grep '^proxy:' /etc/group > /dev/null \
+	 && ! ypmatch proxy group >/dev/null ; then \
 		echo "ERROR: Required proxy group is missing, see /usr/src/UPDATING."; \
 		false; \
 	fi
-	@if ! `id -g authpf > /dev/null`; then \
+	@if ! grep '^authpf:' /etc/group > /dev/null \
+	 && ! ypmatch authpf group >/dev/null ; then \
 		echo "ERROR: Required authpf group is missing, see /usr/src/UPDATING."; \
 		false; \
 	fi
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->mlaier  
Responsible-Changed-By: mlaier 
Responsible-Changed-When: Wed Mar 10 16:39:55 PST 2004 
Responsible-Changed-Why:  
I'll take this one and fix it all the way. Changes backed out atm. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=64073 
State-Changed-From-To: open->closed  
State-Changed-By: mlaier 
State-Changed-When: Fri Mar 12 06:16:07 PST 2004 
State-Changed-Why:  
Fixed by ru@ using find / -prune -group <grpname> 

http://www.freebsd.org/cgi/query-pr.cgi?pr=64073 
>Unformatted:
