From nobody@FreeBSD.org  Tue Jan 13 13:49:42 2004
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id D7DD916A4CE
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 13 Jan 2004 13:49:42 -0800 (PST)
Received: from www.freebsd.org (www.freebsd.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 94D4743D55
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 13 Jan 2004 13:49:37 -0800 (PST)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.12.10/8.12.10) with ESMTP id i0DLnbdL036898
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 13 Jan 2004 13:49:37 -0800 (PST)
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.12.10/8.12.10/Submit) id i0DLnb7v036897;
	Tue, 13 Jan 2004 13:49:37 -0800 (PST)
	(envelope-from nobody)
Message-Id: <200401132149.i0DLnb7v036897@www.freebsd.org>
Date: Tue, 13 Jan 2004 13:49:37 -0800 (PST)
From: Mike Hibler <mike@cs.utah.edu>
To: freebsd-gnats-submit@FreeBSD.org
Subject: traceroute doesn't work with more than 85 hops
X-Send-Pr-Version: www-2.0

>Number:         61336
>Category:       misc
>Synopsis:       traceroute doesn't work with more than 85 hops
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jan 13 13:50:21 PST 2004
>Closed-Date:    Thu Jan 22 22:56:11 PST 2004
>Last-Modified:  Thu Jan 22 22:56:11 PST 2004
>Originator:     Mike Hibler
>Release:        4.7-RELEASE
>Organization:
University of Utah
>Environment:
>Description:
Any combination of (nhops * nprobes per hop) > 255 will fail due to a sequence number placed in the packet as 8-bits but kept internally as 32-bits.  So comparison
of what comes back in the packet (8-bits) with the internal counter (32-bits) fails.
With the default of 3 probes per hop, 85 * 3 == 255.

I know, I know, who gives a .... :-)



>How-To-Repeat:
Traceroute a host 86 hops away!
>Fix:
 Ensure that the "check" performed upon reply only uses 8-bits of sequence,
as the "prepare" function does implicitly by using outdata->seq

1060c1060
<           && (*proto->check)((u_char *)icp,seq))
---
>           && (*proto->check)((u_char *)icp, (u_char)seq))
1072c1072
<                   && (*proto->check)(inner, seq))
---
>                   && (*proto->check)(inner, (u_char)seq))

>Release-Note:
>Audit-Trail:

From: Colin Percival <colin.percival@wadham.ox.ac.uk>
To: freebsd-gnats-submit@FreeBSD.org
Cc:  
Subject: Re: misc/61336: traceroute doesn't work with more than 85 hops
Date: Fri, 23 Jan 2004 05:10:12 +0000

    This is more of a problem than the submitter noted: If the -q option
 is used to increase the number of packets per hop, the packet number > 255
 problem will occur correspondingly earlier.
 
 Colin Percival
 
State-Changed-From-To: open->closed 
State-Changed-By: cperciva 
State-Changed-When: Thu Jan 22 22:55:51 PST 2004 
State-Changed-Why:  
Committed, thanks! 


http://www.freebsd.org/cgi/query-pr.cgi?pr=61336 
>Unformatted:
