From bland@mail.ru  Wed Nov  5 07:53:41 2003
Return-Path: <bland@mail.ru>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id BA09616A4CE
	for <FreeBSD-gnats-submit@freebsd.org>; Wed,  5 Nov 2003 07:53:41 -0800 (PST)
Received: from bbnest.net (t116213.ap.plala.or.jp [220.220.116.213])
	by mx1.FreeBSD.org (Postfix) with ESMTP id AD92D43FE3
	for <FreeBSD-gnats-submit@freebsd.org>; Wed,  5 Nov 2003 07:53:40 -0800 (PST)
	(envelope-from bland@mail.ru)
Received: from bbnest.net (bland@localhost [127.0.0.1])
	by bbnest.net (8.12.10/8.12.10) with ESMTP id hA5FrdGj001490
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 6 Nov 2003 00:53:39 +0900 (JST)
	(envelope-from bland@mail.ru)
Received: (from bland@localhost)
	by bbnest.net (8.12.10/8.12.10/Submit) id hA5Frd6j001489;
	Thu, 6 Nov 2003 00:53:39 +0900 (JST)
	(envelope-from bland)
Message-Id: <200311051553.hA5Frd6j001489@bbnest.net>
Date: Thu, 6 Nov 2003 00:53:39 +0900 (JST)
From: Alexander Nedotsukov <bland@freebsd.org>
Reply-To: Alexander Nedotsukov <bland@freebsd.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: bug in libusbhid descriptor parser code.
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         58971
>Category:       misc
>Synopsis:       bug in libusbhid descriptor parser code.
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    joe
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Nov 05 08:00:38 PST 2003
>Closed-Date:    Tue Jan 27 16:07:24 PST 2004
>Last-Modified:  Tue Jan 27 16:07:24 PST 2004
>Originator:     Alexander Nedotsukov
>Release:        FreeBSD 5.1-CURRENT i386
>Organization:
>Environment:
System: FreeBSD bbnest.net 5.1-CURRENT FreeBSD 5.1-CURRENT #4: Mon Nov 3 16:13:21 JST 2003 bland@bbnest.net:/usr/obj/usr/src/sys/BBNEST i386


	
>Description:
According to specs "Report Size" is global item attribute therefore it should not be
cleared in hid_clear_local() wich supposed to clear local attributes only.
I have usb joystick wich report descriptor can not be properly parsed due this bug.
	
>How-To-Repeat:
	
>Fix:
Apply the patch attached.
	

--- libusbhid.patch begins here ---
Index: parse.c
===================================================================
RCS file: /home/ncvs/src/lib/libusbhid/parse.c,v
retrieving revision 1.8
diff -u -p -r1.8 parse.c
--- lib/libusbhid/parse.c	9 Apr 2003 01:52:48 -0000	1.8
+++ lib/libusbhid/parse.c	29 Oct 2003 05:51:12 -0000
@@ -86,7 +86,6 @@ hid_clear_local(hid_item_t *c)
 	c->string_minimum = 0;
 	c->string_maximum = 0;
 	c->set_delimiter = 0;
-	c->report_size = 0;
 }
 
 hid_data_t
--- libusbhid.patch ends here ---


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->joe 
Responsible-Changed-By: kris 
Responsible-Changed-When: Fri Nov 7 14:24:29 PST 2003 
Responsible-Changed-Why:  
Assign to usb maintainer 

http://www.freebsd.org/cgi/query-pr.cgi?pr=58971 
State-Changed-From-To: open->closed 
State-Changed-By: emax 
State-Changed-When: Tue Jan 27 16:06:46 PST 2004 
State-Changed-Why:  
Patch committed 

http://www.freebsd.org/cgi/query-pr.cgi?pr=58971 
>Unformatted:
