From rssh@cam.grad.kiev.ua  Wed Feb 18 22:00:24 1998
Received: from cam.grad.kiev.ua (grad-UTC-28k8.ukrtel.net [195.5.25.54])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id WAA11712
          for <FreeBSD-gnats-submit@freebsd.org>; Wed, 18 Feb 1998 22:00:20 -0800 (PST)
          (envelope-from rssh@cam.grad.kiev.ua)
Received: (from rssh@localhost)
	by cam.grad.kiev.ua (8.8.8/8.8.5) id JAA25029;
	Wed, 18 Feb 1998 09:56:02 +0200 (EET)
Message-Id: <199802180756.JAA25029@cam.grad.kiev.ua>
Date: Wed, 18 Feb 1998 09:56:02 +0200 (EET)
From: rssh@cam.grad.kiev.ua
Reply-To: rssh@cam.grad.kiev.ua
To: FreeBSD-gnats-submit@freebsd.org
Subject:
X-Send-Pr-Version: 3.2

>Number:         5786
>Category:       misc
>Synopsis:       definition of speed_t in termios.h is not unsigned, as POSIX requiare
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Feb 18 22:10:05 PST 1998
>Closed-Date:    Sat Jan 23 10:46:31 PST 1999
>Last-Modified:  Sat Jan 23 10:48:56 PST 1999
>Originator:     Ruslan Shevchenko
>Release:        FreeBSD 2.2.5-STABLE i386
>Organization:
>Environment:

  -stable

>Description:

  According to the POSIX specification, speed_t in termios.h must be defined
 as "unsigned integral type".

  currently, on FreeBSD speed_t is long, which is not unsigned.

>How-To-Repeat:

  Compare POSIX spec and /usr/include/termios.h

>Fix:

--- /usr/include/termios.h.old	Wed Feb 18 09:53:37 1998
+++ /usr/include/termios.h	Wed Feb 18 09:54:11 1998
@@ -177,7 +177,7 @@
 
 typedef unsigned long	tcflag_t;
 typedef unsigned char	cc_t;
-typedef long		speed_t;	/* XXX should be unsigned long */
+typedef unsigned long	speed_t;	/* XXX should be unsigned long */
 
 struct termios {
 	tcflag_t	c_iflag;	/* input flags */

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: gnats-admin->bde 
Responsible-Changed-By: jkh 
Responsible-Changed-When: Thu Feb 19 08:44:45 PST 1998 
Responsible-Changed-Why:  
Bruce is Mr. Header Files. 
State-Changed-From-To: open->analyzed 
State-Changed-By: bde 
State-Changed-When: Thu Mar 12 06:10:11 PST 1998 
State-Changed-Why:  
Fixed in -currrent. 


Responsible-Changed-From-To: bde->freebsd-bugs 
Responsible-Changed-By: bde 
Responsible-Changed-When: Thu Mar 12 06:10:11 PST 1998 
Responsible-Changed-Why:  
I don't plan to fix it in -stable.  Fixing it might cause different 
sign extension bugs. 
State-Changed-From-To: analyzed->closed 
State-Changed-By: rnordier 
State-Changed-When: Sat Jan 23 10:46:31 PST 1999 
State-Changed-Why:  
Was already fixed in -current; now fixed in -stable. 
>Unformatted:
