From xander@reserve.phaze-III.sec.nl  Thu May  8 01:41:27 2003
Return-Path: <xander@reserve.phaze-III.sec.nl>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 520C137B401
	for <FreeBSD-gnats-submit@freebsd.org>; Thu,  8 May 2003 01:41:27 -0700 (PDT)
Received: from triplex.phaze-III.sec.nl (x55.flex.surfnet.nl [192.87.117.55])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 1DAF943FE5
	for <FreeBSD-gnats-submit@freebsd.org>; Thu,  8 May 2003 01:41:23 -0700 (PDT)
	(envelope-from xander@reserve.phaze-III.sec.nl)
Received: from triplex.phaze-III.sec.nl (localhost [127.0.0.1])
	by triplex.phaze-III.sec.nl (8.12.9/8.12.8) with ESMTP id h488fDXA017082;
	Thu, 8 May 2003 10:41:13 +0200 (CEST)
	(envelope-from xander@reserve.phaze-III.sec.nl)
Received: (from xander@localhost)
	by triplex.phaze-III.sec.nl (8.12.9/8.12.9/Submit) id h487rWOS016059;
	Thu, 8 May 2003 09:53:32 +0200 (CEST)
Message-Id: <200305080753.h487rWOS016059@triplex.phaze-III.sec.nl>
Date: Thu, 8 May 2003 09:53:32 +0200 (CEST)
From: Xander <x+freebsd-gnats@surfnet.nl>
To: FreeBSD-gnats-submit@freebsd.org
Subject: pccard_ether textual errors
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         51955
>Category:       misc
>Synopsis:       pccard_ether textual errors
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    maxim
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu May 08 01:50:13 PDT 2003
>Closed-Date:    Mon Jun 23 00:30:12 PDT 2003
>Last-Modified:  Mon Jun 23 00:30:12 PDT 2003
>Originator:     Xander
>Release:        FreeBSD 5.1-BETA i386
>Organization:
SURFnet
>Environment:
System: FreeBSD triplex.phaze-III.sec.nl 5.1-BETA FreeBSD 5.1-BETA #2: Wed May 7 21:03:24 CEST 2003 

>Description:
The comment in pccard_ether (rev 1.29) at the top mentions a third argument
for 'ifconfig_option'. This argument appears to be unused in the script.
There's also a typo (delelte) elsewhere in the script.
>How-To-Repeat:
	
>Fix:
The following patch removes the remarks about the ifconfig_option and fixes
the typo. Whether removing the ifconfig_option explanation is the best way
to go is left to the maintainer of course.

--- pccard_ether.rev1.29	Tue May  6 13:38:48 2003
+++ pccard_ether	Thu May  8 09:31:31 2003
@@ -2,9 +2,9 @@
 #
 # $FreeBSD: src/etc/pccard_ether,v 1.29 2003/05/05 19:06:46 ume Exp $
 #
-# pccard_ether interfacename [start|stop] [ifconfig option]
+# pccard_ether interfacename [start|stop]
 #
-# example: pccard_ether ep0 start -link0
+# example: pccard_ether ep0 start
 #
 
 stop_dhcp() {
@@ -156,7 +157,7 @@
 		stop_dhcp
 		;;
 	*)
-		# Delelte static route if specified
+		# Delete static route if specified
 		eval ifx_routes=\$static_routes_${interface}
 		if [ -n "${ifx_routes}" ]; then
 			for i in ${ifx_routes}; do


>Release-Note:
>Audit-Trail:

From: Xander <x+freebsd-gnats@surfnet.nl>
To: FreeBSD-gnats-submit@FreeBSD.org
Cc:  
Subject: misc/51955: pccard_ether textual errors
Date: Thu, 8 May 2003 09:53:32 +0200 (CEST)

 >Number:         51955
 >Category:       misc
 >Synopsis:       pccard_ether textual errors
 >Confidential:   no
 >Severity:       non-critical
 >Priority:       low
 >Responsible:    freebsd-bugs
 >State:          open
 >Quarter:        
 >Keywords:       
 >Date-Required:
 >Class:          sw-bug
 >Submitter-Id:   current-users
 >Arrival-Date:   Thu May 08 01:50:13 PDT 2003
 >Closed-Date:
 >Last-Modified:
 >Originator:     Xander
 >Release:        FreeBSD 5.1-BETA i386
 >Organization:
 SURFnet
 >Environment:
 System: FreeBSD triplex.phaze-III.sec.nl 5.1-BETA FreeBSD 5.1-BETA #2: Wed May 7 21:03:24 CEST 2003 
 
 >Description:
 The comment in pccard_ether (rev 1.29) at the top mentions a third argument
 for 'ifconfig_option'. This argument appears to be unused in the script.
 There's also a typo (delelte) elsewhere in the script.
 >How-To-Repeat:
 	
 >Fix:
 The following patch removes the remarks about the ifconfig_option and fixes
 the typo. Whether removing the ifconfig_option explanation is the best way
 to go is left to the maintainer of course.
 
 --- pccard_ether.rev1.29	Tue May  6 13:38:48 2003
 +++ pccard_ether	Thu May  8 09:31:31 2003
 @@ -2,9 +2,9 @@
  #
  # $FreeBSD: src/etc/pccard_ether,v 1.29 2003/05/05 19:06:46 ume Exp $
  #
 -# pccard_ether interfacename [start|stop] [ifconfig option]
 +# pccard_ether interfacename [start|stop]
  #
 -# example: pccard_ether ep0 start -link0
 +# example: pccard_ether ep0 start
  #
  
  stop_dhcp() {
 @@ -156,7 +157,7 @@
  		stop_dhcp
  		;;
  	*)
 -		# Delelte static route if specified
 +		# Delete static route if specified
  		eval ifx_routes=\$static_routes_${interface}
  		if [ -n "${ifx_routes}" ]; then
  			for i in ${ifx_routes}; do
 
 
 >Release-Note:
 >Audit-Trail:
 >Unformatted:
 _______________________________________________
 freebsd-bugs@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/freebsd-bugs
 To unsubscribe, send any mail to "freebsd-bugs-unsubscribe@freebsd.org"

From: Maxim Konovalov <maxim@macomnet.ru>
To: Xander <x+freebsd-gnats@surfnet.nl>
Cc: bug-followup@freebsd.org
Subject: Re: misc/51955: pccard_ether textual errors
Date: Thu, 5 Jun 2003 12:32:26 +0400 (MSD)

 On Thu, 8 May 2003, 10:20-0700, Xander wrote:
 [...]
 >  >Description:
 >  The comment in pccard_ether (rev 1.29) at the top mentions a third argument
 >  for 'ifconfig_option'. This argument appears to be unused in the script.
 
 It is used, actually.  Take a look at the line #87:
 
                 # Do the primary ifconfig if specified
                 ifconfig ${interface} ${ifconfig_args} $*
 -------------------------------------------------------^^
 
 >  There's also a typo (delelte) elsewhere in the script.
 >  >How-To-Repeat:
 >
 >  >Fix:
 >  The following patch removes the remarks about the ifconfig_option and fixes
 >  the typo. Whether removing the ifconfig_option explanation is the best way
 >  to go is left to the maintainer of course.
 >
 >  --- pccard_ether.rev1.29	Tue May  6 13:38:48 2003
 >  +++ pccard_ether	Thu May  8 09:31:31 2003
 >  @@ -2,9 +2,9 @@
 >   #
 >   # $FreeBSD: src/etc/pccard_ether,v 1.29 2003/05/05 19:06:46 ume Exp $
 >   #
 >  -# pccard_ether interfacename [start|stop] [ifconfig option]
 >  +# pccard_ether interfacename [start|stop]
 >   #
 >  -# example: pccard_ether ep0 start -link0
 >  +# example: pccard_ether ep0 start
 
 Funny but ep(4) does not support link0 option.
 
 What do you think about following patch:
 
 Index: etc/pccard_ether
 ===================================================================
 RCS file: /home/ncvs/src/etc/pccard_ether,v
 retrieving revision 1.30
 diff -u -r1.30 pccard_ether
 --- etc/pccard_ether	12 May 2003 11:36:49 -0000	1.30
 +++ etc/pccard_ether	5 Jun 2003 08:28:12 -0000
 @@ -4,7 +4,7 @@
  #
  # pccard_ether interfacename [start|stop] [ifconfig option]
  #
 -# example: pccard_ether ep0 start -link0
 +# example: pccard_ether fxp0 start -link0
  #
 
  stop_dhcp() {
 @@ -156,7 +156,7 @@
  		stop_dhcp
  		;;
  	*)
 -		# Delelte static route if specified
 +		# Delete static route if specified
  		eval ifx_routes=\$static_routes_${interface}
  		if [ -n "${ifx_routes}" ]; then
  			for i in ${ifx_routes}; do
 
 %%%
 
 -- 
 Maxim Konovalov, maxim@macomnet.ru, maxim@FreeBSD.org

From: Maxim Konovalov <maxim@macomnet.ru>
To: bug-followup@freebsd.org
Cc:  
Subject: Re: misc/51955: pccard_ether textual errors (fwd)
Date: Sun, 8 Jun 2003 19:23:29 +0400 (MSD)

 Add to the audit trail.
 
 -- 
 Maxim Konovalov, maxim@macomnet.ru, maxim@FreeBSD.org
 
 ---------- Forwarded message ----------
 Date: Sun, 8 Jun 2003 17:05:42 +0200 (CEST)
 From: Xander <x+freebsd-gnats@surfnet.nl>
 To: Maxim Konovalov <maxim@macomnet.ru>
 Subject: Re: misc/51955: pccard_ether textual errors
 
 On Thu, 5 Jun 2003, Maxim Konovalov wrote:
 
 + On Thu, 8 May 2003, 10:20-0700, Xander wrote:
 + [...]
 + >  >Description:
 + >  The comment in pccard_ether (rev 1.29) at the top mentions a third argument
 + >  for 'ifconfig_option'. This argument appears to be unused in the script.
 +
 + It is used, actually.  Take a look at the line #87:
 +
 +                 # Do the primary ifconfig if specified
 +                 ifconfig ${interface} ${ifconfig_args} $*
 + -------------------------------------------------------^^
 
 Ah yes, I must have missed that one, wishful thinking probably, I needed
 the argument array ($*) for a quick'n dirty fix later on in the script.
 Since ume-san since then provided a much better solution for the problem I
 had (rcNG didn't setup IPv6 networking) that's not needed anymore.
 
 + >  -# example: pccard_ether ep0 start -link0
 + >  +# example: pccard_ether ep0 start
 +
 + Funny but ep(4) does not support link0 option.
 +
 + What do you think about following patch:
 +
 + Index: etc/pccard_ether
 + ===================================================================
 + RCS file: /home/ncvs/src/etc/pccard_ether,v
 + retrieving revision 1.30
 + diff -u -r1.30 pccard_ether
 + --- etc/pccard_ether	12 May 2003 11:36:49 -0000	1.30
 + +++ etc/pccard_ether	5 Jun 2003 08:28:12 -0000
 + @@ -4,7 +4,7 @@
 +  #
 +  # pccard_ether interfacename [start|stop] [ifconfig option]
 +  #
 + -# example: pccard_ether ep0 start -link0
 + +# example: pccard_ether fxp0 start -link0
 +  #
 +
 +  stop_dhcp() {
 + @@ -156,7 +156,7 @@
 +  		stop_dhcp
 +  		;;
 +  	*)
 + -		# Delelte static route if specified
 + +		# Delete static route if specified
 +  		eval ifx_routes=\$static_routes_${interface}
 +  		if [ -n "${ifx_routes}" ]; then
 +  			for i in ${ifx_routes}; do
 +
 + %%%
 
 Looks fine to me. Thanks for looking into this.
 -- 
 Xander
State-Changed-From-To: open->patched 
State-Changed-By: maxim 
State-Changed-When: Mon Jun 16 02:11:45 PDT 2003 
State-Changed-Why:  
Fixed in -CURRENT, thanks! 


Responsible-Changed-From-To: freebsd-bugs->maxim 
Responsible-Changed-By: maxim 
Responsible-Changed-When: Mon Jun 16 02:11:45 PDT 2003 
Responsible-Changed-Why:  
MFC reminder. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=51955 
State-Changed-From-To: patched->closed 
State-Changed-By: maxim 
State-Changed-When: Mon Jun 23 00:29:36 PDT 2003 
State-Changed-Why:  
Fixed in -STABLE as well. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=51955 
>Unformatted:
