From razor@ldc.ro  Sat Apr 19 18:45:00 2003
Return-Path: <razor@ldc.ro>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id B609E37B401
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 19 Apr 2003 18:45:00 -0700 (PDT)
Received: from ldc.ro (ldc-gw.rdsnet.ro [213.157.163.8])
	by mx1.FreeBSD.org (Postfix) with SMTP id 919ED43FE3
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 19 Apr 2003 18:44:59 -0700 (PDT)
	(envelope-from razor@ldc.ro)
Received: (qmail 23096 invoked by uid 666); 20 Apr 2003 01:44:58 -0000
Message-Id: <20030420014458.23093.qmail@ldc.ro>
Date: 20 Apr 2003 01:44:58 -0000
From: Alex Popa <razor@ldc.ro>
Reply-To: Alex Popa <razor@ldc.ro>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: Improving background fsck logging
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         51174
>Category:       misc
>Synopsis:       Improving background fsck logging
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sat Apr 19 18:50:18 PDT 2003
>Closed-Date:    Wed Apr 23 08:39:50 PDT 2003
>Last-Modified:  Wed Apr 23 08:39:50 PDT 2003
>Originator:     Alex Popa
>Release:        FreeBSD 5.0-CURRENT i386
>Organization:
None
>Environment:
System: FreeBSD wabbit5.ldc.ro 5.0-CURRENT FreeBSD 5.0-CURRENT #1: Sat Apr 19 23:25:02 GMT 2003 root@wabbit5.ldc.ro:/usr/obj/usr/src/sys/WABBIT i386

	Athlon XP 1700+, FreeBSD 5.0-CURRENT

>Description:
	The background fsck process started from /etc/rc logs to syslog using this format:

Apr 20 00:20:13 wabbit5 root: /dev/ad0s3d: 116 files, 218 used, 64189 free (45 frags, 8018 blocks, 0.1% fragmentation)

	The "root:" label is a little misleading, so I am suggesting a
	change that would make the above line look like:

Apr 20 00:20:13 wabbit5 fsck: /dev/ad0s3d: 116 files, 218 used, 64189 free (45 frags, 8018 blocks, 0.1% fragmentation)

>How-To-Repeat:
	Boot the machine with dirty filesystems and watch /var/log/messages.
>Fix:

	Apply the following patch to /etc/rc (or /usr/src/etc/rc):

--- rc.orig	Sun Apr 20 00:27:24 2003
+++ rc	Sun Apr 20 00:38:06 2003
@@ -1001,7 +1001,7 @@
 	echo "${bgfsck_msg}."
 
 	(sleep ${background_fsck_delay}; nice -4 fsck -B -p) 2>&1 | \
-	    logger -p daemon.notice &
+	    logger -p daemon.notice -t fsck &
 	;;
 esac
 

>Release-Note:
>Audit-Trail:

From: Makoto Matsushita <matusita@jp.FreeBSD.org>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: misc/51174: Improving background fsck logging
Date: Sun, 20 Apr 2003 16:53:15 +0900

 razor> 	Apply the following patch to /etc/rc (or /usr/src/etc/rc):
 
 Didn't you fail to add following patch also? or would you please check
 following patch that your idea also works on rc_ng="YES" world?
 
 -- -
 Makoto `MAR' Matsushita
 
 Index: bgfsck
 ===================================================================
 RCS file: /home/ncvs/src/etc/rc.d/bgfsck,v
 retrieving revision 1.3
 diff -u -r1.3 bgfsck
 --- bgfsck	18 Dec 2002 07:21:30 -0000	1.3
 +++ bgfsck	20 Apr 2003 07:49:05 -0000
 @@ -23,7 +23,7 @@
  	echo "${bgfsck_msg}."
  
  	(sleep ${background_fsck_delay}; nice -4 fsck -B -p) 2>&1 | \
 -	    logger -p daemon.notice &
 +	    logger -p daemon.notice -t fsck &
  }
  
  load_rc_config $name

From: Alex Popa <razor@ldc.ro>
To: freebsd-gnats-submit@FreeBSD.org
Cc: Makoto Matsushita <matusita@jp.FreeBSD.org>
Subject: Re: misc/51174: Improving background fsck logging
Date: Wed, 23 Apr 2003 17:46:00 +0300

 Tested your patch with rc_ng="YES", and it produces the expected result,
 namely the logging now looks like this:
 
 Apr 23 14:38:21 wabbit5 fsck: /dev/ad0s3e: 79691 files, 708131 used, 651318 free (27118 frags, 78025 blocks, 2.0% fragmentation)
 
 Thank you.
 
 ------------+-------------------------------------------------------
 Alex Popa,  |  "Computer science is no more about computers than
 razor@ldc.ro|     astronomy is about telescopes" -- E. W. Dijkstra
 ------------+------------------------------------------------------
State-Changed-From-To: open->closed 
State-Changed-By: matusita 
State-Changed-When: Wed Apr 23 08:38:12 PDT 2003 
State-Changed-Why:  
Committed to src/etc/rc rev 1.327 and src/etc/rc.d/bgfsck rev 1.4, Thanks! 

http://www.freebsd.org/cgi/query-pr.cgi?pr=51174 
>Unformatted:
