From joost@bps.jodocus.org  Sat Jan 18 09:41:23 2003
Return-Path: <joost@bps.jodocus.org>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 38D5B37B401
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 18 Jan 2003 09:41:23 -0800 (PST)
Received: from bps.jodocus.org (c115139.upc-c.chello.nl [212.187.115.139])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 429A843F1E
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 18 Jan 2003 09:41:15 -0800 (PST)
	(envelope-from joost@bps.jodocus.org)
Received: (from joost@localhost)
	by bps.jodocus.org (8.11.6/8.11.6) id h0IHfBT78680;
	Sat, 18 Jan 2003 18:41:11 +0100 (CET)
	(envelope-from joost)
Message-Id: <200301181741.h0IHfBT78680@bps.jodocus.org>
Date: Sat, 18 Jan 2003 18:41:11 +0100 (CET)
From: Joost Bekkers <joost@bps.jodocus.org>
Reply-To: Joost Bekkers <joost@bps.jodocus.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: 'make iso.1' in /usr/src/release: iso's are not bootable
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         47191
>Category:       misc
>Synopsis:       'make iso.1' in /usr/src/release: iso's are not bootable
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    murray
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Jan 18 09:50:02 PST 2003
>Closed-Date:    Sat May 10 16:02:06 PDT 2003
>Last-Modified:  Sat May 10 16:02:06 PDT 2003
>Originator:     Joost Bekkers
>Release:        FreeBSD 4.5-RELEASE-p2 i386
>Organization:
>Environment:
System: FreeBSD bps.jodocus.org 4.5-RELEASE-p2 FreeBSD 4.5-RELEASE-p2 #1: Wed Aug 7 10:13:09 CEST 2002 joost@bps.jodocus.org:/usr/src/sys/compile/bps i386


>Description:

When you do a 'make iso.1' in /usr/src/release of the chroot-ed environment created
by make release. The iso images it creates are only bootable if you define MAKE_ISOS.
This doesn't seem right to me, because you shouldn't need to tell it twice to make iso's.
(ie 'make iso.1 -DMAKE_ISOS')

>How-To-Repeat:

start a 'make release' and "forget" to include -DMAKE_ISOS
chroot /usr/release (or whatever)
cd /usr/src/release
make iso.1

>Fix:

***************
*** 234,242 ****
  EXTRAS= cdrom.1 ftp.1
  .if defined(MAKE_ISOS)
  EXTRAS+= iso.1
  .if ${TARGET} != "pc98"
  BOOTABLE="-b"
- .endif
  .endif
  
  .if !defined(NODOC)
--- 234,244 ----
  EXTRAS= cdrom.1 ftp.1
  .if defined(MAKE_ISOS)
  EXTRAS+= iso.1
+ .endif
+ #moved out of previous .if to make the iso.1 target work properly when
+ #not 'called' through release
  .if ${TARGET} != "pc98"
  BOOTABLE="-b"
  .endif
  
  .if !defined(NODOC)

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->patched 
State-Changed-By: murray 
State-Changed-When: Sun May 4 22:29:16 PDT 2003 
State-Changed-Why:  
I have committed this change to -CURRENT.  Thanks for the submission. 
I will MFC this in a week. 



Responsible-Changed-From-To: freebsd-bugs->murray 
Responsible-Changed-By: murray 
Responsible-Changed-When: Sun May 4 22:29:16 PDT 2003 
Responsible-Changed-Why:  
I have committed this change to -CURRENT.  Thanks for the submission. 
I will MFC this in a week. 


http://www.freebsd.org/cgi/query-pr.cgi?pr=47191 
State-Changed-From-To: patched->closed 
State-Changed-By: murray 
State-Changed-When: Sat May 10 16:01:49 PDT 2003 
State-Changed-Why:  
I've merged this to -STABLE.  Thanks for the submission. 


http://www.freebsd.org/cgi/query-pr.cgi?pr=47191 
>Unformatted:
