From kogane@syd.odn.ne.jp  Sun Sep 29 13:12:13 2002
Return-Path: <kogane@syd.odn.ne.jp>
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id ADDB737B401
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 29 Sep 2002 13:12:13 -0700 (PDT)
Received: from t-mta2.odn.ne.jp (mfep2.odn.ne.jp [143.90.131.180])
	by mx1.FreeBSD.org (Postfix) with ESMTP id F231943E75
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 29 Sep 2002 13:12:11 -0700 (PDT)
	(envelope-from kogane@syd.odn.ne.jp)
Received: from kces1.koganemaru.co.jp ([61.123.189.43]) by t-mta2.odn.ne.jp
          with ESMTP
          id <20020929201210247.VMWI.789.t-mta2.odn.ne.jp@mta2.odn.ne.jp>
          for <FreeBSD-gnats-submit@freebsd.org>;
          Mon, 30 Sep 2002 05:12:10 +0900
Received: (from kogane@localhost)
	by kces1.koganemaru.co.jp (8.8.8/3.6W) id FAA00916;
	Mon, 30 Sep 2002 05:14:35 +0900 (JST)
Message-Id: <200209292014.FAA00916@kces1.koganemaru.co.jp>
Date: Mon, 30 Sep 2002 05:14:35 +0900 (JST)
From: n-kogane@syd.odn.ne.jp
Reply-To: n-kogane@syd.odn.ne.jp
To: FreeBSD-gnats-submit@freebsd.org
Subject: installation: missing '\n' (newline) in debug messeages.
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         43483
>Category:       misc
>Synopsis:       installation: missing '\n' (newline) in debug messeages.
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    re
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Sep 29 13:20:01 PDT 2002
>Closed-Date:    Sun Jul 13 00:11:08 PDT 2003
>Last-Modified:  Sun Jul 13 00:11:08 PDT 2003
>Originator:     Nobuyuki Koganemaru
>Release:        FreeBSD 4.7-RC i386
>Organization:
KOGANEMARU Computer Engineering Service Corporation.
>Environment:
System: FreeBSD kcesx20.koganemaru.co.jp 4.7-RC FreeBSD 4.7-RC #2: Sun Sep 22 23:57:58 JST 2002 root@kcesx20.koganemaru.co.jp:/usr/obj/usr/src.stable/sys/GENERIC i386


>Description:
	at installation,
	missing '\n' (newline) in debug messeages.
>How-To-Repeat:
	select network installation, and see debug messeage in ALT&F2 console.
>Fix:

--- src/release/sysinstall/network.c.orig	Thu Jul 19 10:33:02 2001
+++ src/release/sysinstall/network.c	Mon Sep 30 04:53:32 2002
@@ -127,7 +127,7 @@
     cp = variable_get(ifconfig);
     if (cp) {
 	if (strcmp(cp, "DHCP")) {
-	    msgDebug("ifconfig %s %s", dev->name, cp);
+	    msgDebug("ifconfig %s %s\n", dev->name, cp);
 	    i = vsystem("ifconfig %s %s", dev->name, cp);
 	    if (i) {
 		msgConfirm("Unable to configure the %s interface!\n"
@@ -141,7 +141,7 @@
 			   "not on your local network");
 	    }
 	    else {
-		msgDebug("Adding default route to %s.", rp);
+		msgDebug("Adding default route to %s.\n", rp);
 		vsystem("route -n add default %s", rp);
 	    }
 	}
@@ -175,13 +175,13 @@
 	cp = variable_get(ifconfig);
 	if (!cp)
 	    return;
-	msgDebug("ifconfig %s down", dev->name);
+	msgDebug("ifconfig %s down\n", dev->name);
 	i = vsystem("ifconfig %s down", dev->name);
 	if (i)
 	    msgConfirm("Warning: Unable to down the %s interface properly", dev->name);
 	cp = variable_get(VAR_GATEWAY);
 	if (cp) {
-	    msgDebug("Deleting default route.");
+	    msgDebug("Deleting default route.\n");
 	    vsystem("route -n delete default");
 	}
     }


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->re 
Responsible-Changed-By: kris 
Responsible-Changed-When: Sat Jul 12 20:57:19 PDT 2003 
Responsible-Changed-Why:  
Assign to release engineers 

http://www.freebsd.org/cgi/query-pr.cgi?pr=43483 
State-Changed-From-To: open->closed 
State-Changed-By: murray 
State-Changed-When: Sun Jul 13 00:10:34 PDT 2003 
State-Changed-Why:  
kuriyama-san fixed this in -CURRENT months ago.  I have just MFCed the 
change to 4.X-STABLE.  Thanks for the submission! 


http://www.freebsd.org/cgi/query-pr.cgi?pr=43483 
>Unformatted:
