From nobody@FreeBSD.org  Wed Aug 28 12:07:44 2002
Return-Path: <nobody@FreeBSD.org>
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id AE52437B400
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 28 Aug 2002 12:07:44 -0700 (PDT)
Received: from www.freebsd.org (www.FreeBSD.org [216.136.204.117])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 6867B43E81
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 28 Aug 2002 12:05:52 -0700 (PDT)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.12.4/8.12.4) with ESMTP id g7SJ5eOT080663
	for <freebsd-gnats-submit@FreeBSD.org>; Wed, 28 Aug 2002 12:05:40 -0700 (PDT)
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.12.4/8.12.4/Submit) id g7SJ5eua080662;
	Wed, 28 Aug 2002 12:05:40 -0700 (PDT)
Message-Id: <200208281905.g7SJ5eua080662@www.freebsd.org>
Date: Wed, 28 Aug 2002 12:05:40 -0700 (PDT)
From: Randy Zach <zach@zach.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: Truss dumps core printing socket address
X-Send-Pr-Version: www-1.0

>Number:         42135
>Category:       misc
>Synopsis:       Truss dumps core printing socket address
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    mdodd
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Aug 28 12:10:01 PDT 2002
>Closed-Date:    Mon Apr 14 11:24:59 PDT 2003
>Last-Modified:  Mon Apr 14 11:24:59 PDT 2003
>Originator:     Randy Zach
>Release:        4.6.2
>Organization:
Randy Zach Consulting
>Environment:
FreeBSD freeb.zach.com 4.6.2-RELEASE FreeBSD 4.6.2-RELEASE #0: Wed Aug 21 00:38:50 PDT 2002     zach@freeb.zach.com:/usr/obj/usr/src/sys/RZ  i386

>Description:
The pretty print code for Sockaddrs copies the target's socket structure using the target's socket len, regardless of whether or not it will fit in the sockaddr_storage struct.
>How-To-Repeat:
The following debug target will exercise the problem:

#include <sys/types.h>
#include <sys/socket.h>
#include <netinet/in.h>
#include <arpa/inet.h>

main()

{
    struct sockaddr_in addr;

    addr.sin_len = 250;
    addr.sin_family = AF_INET;
    addr.sin_port = htons(1234);
    addr.sin_addr.s_addr = 0x12345678;

    connect(123, (struct sockaddr *)&addr, 16);
}

truss ./a.out will terminate with truss dumping core.
>Fix:
In /usr/src/usr.bin/truss/syscalls.c

*** syscalls.c  Wed Aug 28 11:27:00 2002
--- syscalls.c.orig     Wed Aug 28 11:39:12 2002
***************
*** 308,315 ****
          == -1)
          err(2, "get_struct %p", (void *)args[sc->offset]);
        } else {
!       if (get_struct(fd, (void *)args[sc->offset], (void *)&ss,
!                       ss.ss_len < sizeof(ss) ? ss.ss_len : sizeof(ss))
          == -1)
          err(2, "get_struct %p", (void *)args[sc->offset]);
        }
--- 308,314 ----
          == -1)
          err(2, "get_struct %p", (void *)args[sc->offset]);
        } else {
!       if (get_struct(fd, (void *)args[sc->offset], (void *)&ss, ss.ss_len)
          == -1)
          err(2, "get_struct %p", (void *)args[sc->offset]);
        }


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->mdodd 
Responsible-Changed-By: mdodd 
Responsible-Changed-When: Thu Aug 29 13:41:18 PDT 2002 
Responsible-Changed-Why:  
I'll handle this. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=42135 
State-Changed-From-To: open->closed 
State-Changed-By: mdodd 
State-Changed-When: Mon Apr 14 11:24:42 PDT 2003 
State-Changed-Why:  
Committed.  Thanks. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=42135 
>Unformatted:
