From perky@kornet.hanirc.org  Sun Jun 30 09:47:35 2002
Return-Path: <perky@kornet.hanirc.org>
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 1804F37B401
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 30 Jun 2002 09:47:35 -0700 (PDT)
Received: from kornet.hanirc.org (alfenheim.net [211.216.53.129])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 19EE143E0A
	for <FreeBSD-gnats-submit@freebsd.org>; Sun, 30 Jun 2002 09:47:34 -0700 (PDT)
	(envelope-from perky@kornet.hanirc.org)
Received: from kornet.hanirc.org (perky@localhost [127.0.0.1])
	by kornet.hanirc.org (8.12.3/8.12.3) with ESMTP id g5UGlXr5023893
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 1 Jul 2002 01:47:33 +0900 (KST)
	(envelope-from perky@kornet.hanirc.org)
Received: (from perky@localhost)
	by kornet.hanirc.org (8.12.3/8.12.3/Submit) id g5UGlWUW023883;
	Mon, 1 Jul 2002 01:47:32 +0900 (KST)
Message-Id: <200206301647.g5UGlWUW023883@kornet.hanirc.org>
Date: Mon, 1 Jul 2002 01:47:32 +0900 (KST)
From: Hye-Shik Chang <perky@freebsd.org>
Reply-To: Hye-Shik Chang <perky@freebsd.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: src/share/man/man4/ifmib.4 : syntax error on example code
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         40038
>Category:       misc
>Synopsis:       src/share/man/man4/ifmib.4 : syntax error on example code
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    johan
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sun Jun 30 09:50:01 PDT 2002
>Closed-Date:    Thu Oct 10 11:40:24 PDT 2002
>Last-Modified:  Thu Oct 10 11:40:24 PDT 2002
>Originator:     Hye-Shik Chang
>Release:        FreeBSD 5.0-CURRENT i386
>Organization:
Yonsei University
>Environment:
FreeBSD sbtm.yonsei.net 5.0-CURRENT FreeBSD 5.0-CURRENT #0: Tue Jun  4 20:20:35 KST 2002     perky@akaraka.yonsei.ac.kr:/usr/src/sys/i386/compile/JOARRA  i386

>Description:
arg 3 of sysctl(2) cannot be a constant.

>How-To-Repeat:
>Fix:

--- ifmib.4.orig	Mon Jul  1 01:23:48 2002
+++ ifmib.4	Mon Jul  1 01:26:46 2002
@@ -101,6 +101,7 @@
 get_ifmib_general(int row, struct ifmibdata *ifmd)
 {
 	int name[6];
+	int len = sizeof *ifmd;
 
 	name[0] = CTL_NET;
 	name[1] = PF_LINK;
@@ -109,7 +110,7 @@
 	name[4] = row;
 	name[5] = IFDATA_GENERAL;
 
-	return sysctl(name, 6, ifmd, sizeof *ifmd, (void *)0, 0);
+	return sysctl(name, 6, ifmd, &len, (void *)0, 0);
 }
 .Ed
 .Pp
>Release-Note:
>Audit-Trail:

From: Hye-Shik Chang <perky@fallin.lv>
To: Hye-Shik Chang <perky@FreeBSD.org>
Cc: FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: docs/40038: src/share/man/man4/ifmib.4 : syntax error on example code
Date: Mon, 1 Jul 2002 07:21:50 +0900

 > --- ifmib.4.orig	Mon Jul  1 01:23:48 2002
 > +++ ifmib.4	Mon Jul  1 01:26:46 2002
 > @@ -101,6 +101,7 @@
 >  get_ifmib_general(int row, struct ifmibdata *ifmd)
 >  {
 >  	int name[6];
 > +	int len = sizeof *ifmd;
 >  
 >  	name[0] = CTL_NET;
 >  	name[1] = PF_LINK;
 
 Oh. sorry, len's type must be changed to size_t.
 
 -- 
 Hye-Shik Chang <perky@fallin.lv>
 Yonsei University, Seoul
 ^D
Responsible-Changed-From-To: freebsd-doc->freebsd-bugs 
Responsible-Changed-By: perky 
Responsible-Changed-When: Sun Jun 30 23:19:32 GMT 2002 
Responsible-Changed-Why:  
ooh terribly sorry. I selected wrong category. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=40038 
Responsible-Changed-From-To: freebsd-bugs->johan 
Responsible-Changed-By: johan 
Responsible-Changed-When: Sat Aug 24 05:59:11 PDT 2002 
Responsible-Changed-Why:  
I will take a look at this. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=40038 
State-Changed-From-To: open->patched 
State-Changed-By: johan 
State-Changed-When: Fri Aug 30 03:53:45 PDT 2002 
State-Changed-Why:  
Committed to current. Thanks for pointing this out. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=40038 
State-Changed-From-To: patched->closed 
State-Changed-By: johan 
State-Changed-When: Thu Oct 10 11:39:34 PDT 2002 
State-Changed-Why:  
Has been MFC:ed. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=40038 
>Unformatted:
