From ijliao@Terry.Dorm11.NCTU.edu.tw  Mon Jun 24 01:38:56 2002
Return-Path: <ijliao@Terry.Dorm11.NCTU.edu.tw>
Received: from Www.HCRC.edu.tw (www.HCRC.edu.tw [163.28.64.11])
	by hub.freebsd.org (Postfix) with ESMTP id 5311137B497
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 24 Jun 2002 00:18:40 -0700 (PDT)
Received: from Terry.Dorm11.NCTU.edu.tw (root@Terry.Dorm11.NCTU.edu.tw [140.113.192.99])
	by Www.HCRC.edu.tw (8.12.3/8.12.3) with ESMTP id g5O7Ic3a021029
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 24 Jun 2002 15:18:38 +0800 (CST)
	(envelope-from ijliao@Terry.Dorm11.NCTU.edu.tw)
Received: from Terry.Dorm11.NCTU.edu.tw (ijliao@localhost [127.0.0.1])
	by Terry.Dorm11.NCTU.edu.tw (8.12.3/8.12.3) with ESMTP id g5O7IfL2001178
	for <FreeBSD-gnats-submit@freebsd.org>; Mon, 24 Jun 2002 15:18:41 +0800 (CST)
	(envelope-from ijliao@Terry.Dorm11.NCTU.edu.tw)
Received: (from ijliao@localhost)
	by Terry.Dorm11.NCTU.edu.tw (8.12.3/8.12.3/Submit) id g5O7IeCr001177;
	Mon, 24 Jun 2002 15:18:40 +0800 (CST)
Message-Id: <200206240718.g5O7IeCr001177@Terry.Dorm11.NCTU.edu.tw>
Date: Mon, 24 Jun 2002 15:18:40 +0800 (CST)
From: Ying-Chieh Liao <ijliao@terry.dragon2.net>
Reply-To: Ying-Chieh Liao <ijliao@terry.dragon2.net>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: bsd.incs.mk, INCDIR or INCSDIR ?
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         39765
>Category:       misc
>Synopsis:       bsd.incs.mk, INCDIR or INCSDIR ?
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    ru
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jun 24 01:40:01 PDT 2002
>Closed-Date:    Sun Aug 04 23:55:23 PDT 2002
>Last-Modified:  Sun Aug 04 23:55:23 PDT 2002
>Originator:     Ying-Chieh Liao
>Release:        FreeBSD 5.0-CURRENT i386
>Organization:
NCTU CSIE
>Environment:
System: FreeBSD Terry.Dorm11.NCTU.edu.tw 5.0-CURRENT FreeBSD 5.0-CURRENT #13: Mon Jun 10 20:42:43 CST 2002 root@Terry.Dorm11.NCTU.edu.tw:/ad0/usr.obj/usr/src/sys/TERRY i386


	
>Description:

ports/graphics/libmng uses bsd.lib.mk, which uses bsd.incs.mk
if we use INCDIR to specify where to install include files
	stable will install them into /usr/local/include	<- correct
	but current installs into /usr/include
if we use INCSDIR ,
	stable will install them into /usr/include
	but current installs into /usr/local/include		<- correct

>How-To-Repeat:
	
>Fix:

	


>Release-Note:
>Audit-Trail:

From: Ruslan Ermilov <ru@FreeBSD.org>
To: Ying-Chieh Liao <ijliao@terry.dragon2.net>
Cc: bug-followup@FreeBSD.org
Subject: Re: misc/39765: bsd.incs.mk, INCDIR or INCSDIR ?
Date: Mon, 1 Jul 2002 18:16:34 +0300

 On Mon, Jun 24, 2002 at 03:18:40PM +0800, Ying-Chieh Liao wrote:
 > 
 > ports/graphics/libmng uses bsd.lib.mk, which uses bsd.incs.mk
 > if we use INCDIR to specify where to install include files
 > 	stable will install them into /usr/local/include	<- correct
 > 	but current installs into /usr/include
 > if we use INCSDIR ,
 > 	stable will install them into /usr/include
 > 	but current installs into /usr/local/include		<- correct
 > 
 Here's the technique we used with many similar ports:
 
 %%%
 Index: Makefile.bsd
 ===================================================================
 RCS file: /home/ncvs/ports/graphics/libmng/files/Makefile.bsd,v
 retrieving revision 1.4
 diff -u -r1.4 Makefile.bsd
 --- Makefile.bsd	16 Jul 2001 21:23:11 -0000	1.4
 +++ Makefile.bsd	1 Jul 2002 15:14:12 -0000
 @@ -11,7 +11,8 @@
  CFLAGS+=	-I${INCDIR} -DMNG_FULL_CMS
  
  INCS=		libmng.h libmng_conf.h libmng_types.h
 -INCDIR=		${LOCALBASE}/include
 +INCSDIR=	${LOCALBASE}/include
 +INCDIR=		${INCSDIR}		# for 4.x bsd.lib.mk
  LIBDIR=		${LOCALBASE}/lib
  
  .include <bsd.lib.mk>
 %%%
 
 
 Cheers,
 -- 
 Ruslan Ermilov		Sysadmin and DBA,
 ru@sunbay.com		Sunbay Software AG,
 ru@FreeBSD.org		FreeBSD committer,
 +380.652.512.251	Simferopol, Ukraine
 
 http://www.FreeBSD.org	The Power To Serve
 http://www.oracle.com	Enabling The Information Age

From: Johan Karlsson <johan@freebsd.org>
To: ru@freebsd.org, freebsd-gnats-submit@freebsd.org
Cc: ijliao@terry.dragon2.net
Subject: Re: misc/39765: bsd.incs.mk, INCDIR or INCSDIR ?
Date: Fri, 2 Aug 2002 22:11:06 +0200

 Hi Ruslan,
 
 I think that your MFC of bsd.incs.mk took care of this
 problem. However, since I'm not 100% sure I would like 
 to get a confirmation from you before closing it.
 
 Take care
 /Johan
 
 -- 
 Johan Karlsson		mailto:johan@FreeBSD.org
State-Changed-From-To: open->closed 
State-Changed-By: ru 
State-Changed-When: Sun Aug 4 23:54:05 PDT 2002 
State-Changed-Why:  
Fixed in ports/graphics/libmng/files/Makefile.bsd,v 1.5. 


Responsible-Changed-From-To: freebsd-bugs->ru 
Responsible-Changed-By: ru 
Responsible-Changed-When: Sun Aug 4 23:54:05 PDT 2002 
Responsible-Changed-Why:  

http://www.freebsd.org/cgi/query-pr.cgi?pr=39765 
>Unformatted:
