From nobody@www.freebsd.org  Mon May 27 21:14:35 2002
Return-Path: <nobody@www.freebsd.org>
Received: from nwww.freebsd.org (www.FreeBSD.org [216.136.204.117])
	by hub.freebsd.org (Postfix) with ESMTP id 2104937B405
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 27 May 2002 21:14:35 -0700 (PDT)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by nwww.freebsd.org (8.12.2/8.12.2) with ESMTP id g4S4EZhG092690
	for <freebsd-gnats-submit@FreeBSD.org>; Mon, 27 May 2002 21:14:35 -0700 (PDT)
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.12.2/8.12.2/Submit) id g4S4EY1S092689;
	Mon, 27 May 2002 21:14:34 -0700 (PDT)
Message-Id: <200205280414.g4S4EY1S092689@www.freebsd.org>
Date: Mon, 27 May 2002 21:14:34 -0700 (PDT)
From: Chris Pepper <pepper@rockefeller.edu>
To: freebsd-gnats-submit@FreeBSD.org
Subject: cvsupit generates bad supfiles -- overrides selected release with "tag=." (CVS current)
X-Send-Pr-Version: www-1.0

>Number:         38648
>Category:       misc
>Synopsis:       cvsupit generates bad supfiles -- overrides selected release with "tag=." (CVS current)
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon May 27 21:20:01 PDT 2002
>Closed-Date:    Tue Jun 04 19:37:37 PDT 2002
>Last-Modified:  Tue Jun 04 19:37:37 PDT 2002
>Originator:     Chris Pepper
>Release:        4.5-RELEASE
>Organization:
Rockefeller University
>Environment:
FreeBSD guest.reppep.com 4.5-RELEASE FreeBSD 4.5-RELEASE #0: Mon Jan 28 14:31:56 GMT 2002     murray@builder.freebsdmall.com:/usr/src/sys/compile/GENERIC  i386

>Description:
When installing cvsupit (from ports/net/cvsupit on a fresh 4.5-R system, or from <ftp://ftp.FreeBSD.org/pub/FreeBSD/development/CVSup/cvsupit.tgz>), the specified release tag (e.g., "*default  tag=RELENG_4") is overriden by a "*default tag=." line lower in the file. According to the man page, lower lines override higher lines in case of a conflict.
>How-To-Repeat:
Run cvsupit from ports (or ftp site). Select RELENG_4, full source, ports, and docs. View /etc/cvsupfile, and observe something like the following:

*default  host=cvsup4.FreeBSD.org
*default  base=/usr
*default  prefix=/usr
*default  release=cvs
*default  tag=RELENG_4
*default  delete use-rel-suffix

src-all
src-crypto
src-secure
*default tag=.
ports-all
doc-all

>Fix:
Don't generate the "*default tag=." line unless desired by the user.
>Release-Note:
>Audit-Trail:

From: Giorgos Keramidas <keramida@FreeBSD.ORG>
To: Chris Pepper <pepper@rockefeller.edu>
Cc: bug-followup@FreeBSD.ORG
Subject: Re: misc/38648: cvsupit generates bad supfiles -- overrides selected release with "tag=." (CVS current)
Date: Tue, 28 May 2002 17:57:21 +0300

 On 2002-05-27 21:14, Chris Pepper wrote:
 >
 > *default  tag=RELENG_4
 >
 > src-all
 > src-crypto
 > src-secure
 > *default tag=.
 > ports-all
 > doc-all
 
 This is correct.  The doc/ and ports/ trees are not branched.
 Therefore, cvsupit chooses to download the MAIN branch of these trees,
 which is the only branch in the CVS repository anyway :)
 
 -- 
 Giorgos Keramidas    - http://www.FreeBSD.org
 keramida@FreeBSD.org - The Power to Serve

From: Chris Pepper <pepper@reppep.com>
To: Giorgos Keramidas <keramida@FreeBSD.ORG>
Cc: bug-followup@FreeBSD.ORG
Subject: Re: misc/38648: cvsupit generates bad supfiles -- overrides
 selected release with "tag=." (CVS current)
Date: Tue, 28 May 2002 11:39:05 -0400

 At 5:57 PM +0300 2002/05/28, Giorgos Keramidas wrote:
 >On 2002-05-27 21:14, Chris Pepper wrote:
 >>
 >>  *default  tag=RELENG_4
 >>
 >>  src-all
 >>  src-crypto
 >>  src-secure
 >>  *default tag=.
 >>  ports-all
 >>  doc-all
 >
 >This is correct.  The doc/ and ports/ trees are not branched.
 >Therefore, cvsupit chooses to download the MAIN branch of these trees,
 >which is the only branch in the CVS repository anyway :)
 
 	If it's correct, then the man page should be corrected; as 
 currently written, it gave the impression that earlier entries are 
 always ignored, regardless of relative positions of collection lines. 
 So are lines below the last collection line (i.e. 'src-all') ignored?
 
 
 						Chris
 -- 
 Chris Pepper:               <http://www.reppep.com/~pepper/>
 Rockefeller University:        <http://www.rockefeller.edu/>

From: "Crist J. Clark" <crist.clark@attbi.com>
To: Chris Pepper <pepper@reppep.com>
Cc: freebsd-bugs@freebsd.org
Subject: Re: misc/38648: cvsupit generates bad supfiles -- overrides selected release with "tag=." (CVS current)
Date: Sat, 1 Jun 2002 18:15:37 -0700

 On Tue, May 28, 2002 at 08:50:07AM -0700, Chris Pepper wrote:
 > The following reply was made to PR misc/38648; it has been noted by GNATS.
 > 
 > From: Chris Pepper <pepper@reppep.com>
 > To: Giorgos Keramidas <keramida@FreeBSD.ORG>
 > Cc: bug-followup@FreeBSD.ORG
 > Subject: Re: misc/38648: cvsupit generates bad supfiles -- overrides
 >  selected release with "tag=." (CVS current)
 > Date: Tue, 28 May 2002 11:39:05 -0400
 > 
 >  At 5:57 PM +0300 2002/05/28, Giorgos Keramidas wrote:
 >  >On 2002-05-27 21:14, Chris Pepper wrote:
 >  >>
 >  >>  *default  tag=RELENG_4
 >  >>
 >  >>  src-all
 >  >>  src-crypto
 >  >>  src-secure
 >  >>  *default tag=.
 >  >>  ports-all
 >  >>  doc-all
 >  >
 >  >This is correct.  The doc/ and ports/ trees are not branched.
 >  >Therefore, cvsupit chooses to download the MAIN branch of these trees,
 >  >which is the only branch in the CVS repository anyway :)
 >  
 >  	If it's correct, then the man page should be corrected; as 
 >  currently written, it gave the impression that earlier entries are 
 >  always ignored, regardless of relative positions of collection lines. 
 
 Which manpage? cvsup(1) says,
 
      Default settings may be specified in lines whose collection name is
      *default.  Such defaults will apply to subsequent lines in the supfile.
      Multiple *default lines may be present.  New values augment or override
      any defaults specified earlier in the supfile.  Values specified explic-
      itly for a collection override any default values.
 
 >  So are lines below the last collection line (i.e. 'src-all') ignored?
 
 No.
 
 Anyway, if there even is a bug somewhere, it is a ports, cvsupit or
 cvsup, issue.
 -- 
 Crist J. Clark                     |     cjclark@alum.mit.edu
                                    |     cjclark@jhu.edu
 http://people.freebsd.org/~cjc/    |     cjc@freebsd.org
State-Changed-From-To: open->feedback 
State-Changed-By: johan 
State-Changed-When: Tue Jun 4 17:49:32 PDT 2002 
State-Changed-Why:  
Are you satisfied with Crists explanation? 


Responsible-Changed-From-To: freebsd-bugs->freebsd-ports 
Responsible-Changed-By: johan 
Responsible-Changed-When: Tue Jun 4 17:49:32 PDT 2002 
Responsible-Changed-Why:  
ports issue 

http://www.freebsd.org/cgi/query-pr.cgi?pr=38648 
State-Changed-From-To: feedback->closed 
State-Changed-By: johan 
State-Changed-When: Tue Jun 4 19:36:22 PDT 2002 
State-Changed-Why:  
Submitter confirms that this can be closed 

http://www.freebsd.org/cgi/query-pr.cgi?pr=38648 
>Unformatted:
