From k@numeri.campus.luth.se  Sat Apr 27 18:41:46 2002
Return-Path: <k@numeri.campus.luth.se>
Received: from numeri.campus.luth.se (numeri.campus.luth.se [130.240.197.103])
	by hub.freebsd.org (Postfix) with ESMTP id 5233437B404
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 27 Apr 2002 18:41:45 -0700 (PDT)
Received: (from k@localhost)
	by numeri.campus.luth.se (8.11.6/8.11.6) id g3S1fhW46914;
	Sun, 28 Apr 2002 03:41:43 +0200 (CEST)
	(envelope-from k)
Message-Id: <200204280141.g3S1fhW46914@numeri.campus.luth.se>
Date: Sun, 28 Apr 2002 03:41:43 +0200 (CEST)
From: Johan Karlsson <k@numeri.campus.luth.se>
Reply-To: Johan Karlsson <k@numeri.campus.luth.se>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: installworld fails in usr.bin/strip if NOMAN=true
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         37516
>Category:       misc
>Synopsis:       installworld fails in usr.bin/strip if NOMAN=true
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    ru
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Apr 27 18:50:01 PDT 2002
>Closed-Date:    Tue Jul 16 07:28:43 PDT 2002
>Last-Modified:  Tue Jul 16 07:28:43 PDT 2002
>Originator:     Johan Karlsson
>Release:        FreeBSD 4.5-RC i386
>Organization:
>Environment:
System: FreeBSD numeri.campus.luth.se 4.5-RC FreeBSD 4.5-RC #1: Sat Jan 19 14:40:08 CET 2002 k@numeri.campus.luth.se:/usr/home/builds/usr/src/sys/NUMERI i386


	
>Description:
	strip/Makefile uses 'maninstall' unconditioned
	bsd.man.mk is not included in bsd.prog.mk if 
	NOMAN is defined. Hence install fails in strip if NOMAN=true
	
>How-To-Repeat:
	make -DNOMAN installworld
	
>Fix:

Index: usr.bin/strip/Makefile
===================================================================
RCS file: /home/ncvs/src/usr.bin/strip/Makefile,v
retrieving revision 1.13
diff -u -r1.13 Makefile
--- usr.bin/strip/Makefile	2001/12/12 23:29:13	1.13
+++ usr.bin/strip/Makefile	2002/04/27 23:55:35
@@ -16,7 +16,10 @@
 .endif
 .endif
 
-install: maninstall
+.if !defined(NOMAN)
+_maninstall = maninstall
+.endif
+install: ${_maninstall}
 	${INSTALL} ${COPY} -o ${BINOWN} -g ${BINGRP} -m ${BINMODE} \
 	    maybe_stripped ${DESTDIR}${BINDIR}/strip
 

	


>Release-Note:
>Audit-Trail:

From: Johan Karlsson <k@numeri.campus.luth.se>
To: FreeBSD-gnats-submit@FreeBSD.org
Cc:  
Subject: misc/37516: installworld fails in usr.bin/strip if NOMAN=true
Date: Sun, 28 Apr 2002 03:41:43 +0200 (CEST)

 >Number:         37516
 >Category:       misc
 >Synopsis:       installworld fails in usr.bin/strip if NOMAN=true
 >Confidential:   no
 >Severity:       non-critical
 >Priority:       medium
 >Responsible:    freebsd-bugs
 >State:          open
 >Quarter:        
 >Keywords:       
 >Date-Required:
 >Class:          sw-bug
 >Submitter-Id:   current-users
 >Arrival-Date:   Sat Apr 27 18:50:01 PDT 2002
 >Closed-Date:
 >Last-Modified:
 >Originator:     Johan Karlsson
 >Release:        FreeBSD 4.5-RC i386
 >Organization:
 >Environment:
 System: FreeBSD numeri.campus.luth.se 4.5-RC FreeBSD 4.5-RC #1: Sat Jan 19 14:40:08 CET 2002 k@numeri.campus.luth.se:/usr/home/builds/usr/src/sys/NUMERI i386
 
 
 	
 >Description:
 	strip/Makefile uses 'maninstall' unconditioned
 	bsd.man.mk is not included in bsd.prog.mk if 
 	NOMAN is defined. Hence install fails in strip if NOMAN=true
 	
 >How-To-Repeat:
 	make -DNOMAN installworld
 	
 >Fix:
 
 Index: usr.bin/strip/Makefile
 ===================================================================
 RCS file: /home/ncvs/src/usr.bin/strip/Makefile,v
 retrieving revision 1.13
 diff -u -r1.13 Makefile
 --- usr.bin/strip/Makefile	2001/12/12 23:29:13	1.13
 +++ usr.bin/strip/Makefile	2002/04/27 23:55:35
 @@ -16,7 +16,10 @@
  .endif
  .endif
  
 -install: maninstall
 +.if !defined(NOMAN)
 +_maninstall = maninstall
 +.endif
 +install: ${_maninstall}
  	${INSTALL} ${COPY} -o ${BINOWN} -g ${BINGRP} -m ${BINMODE} \
  	    maybe_stripped ${DESTDIR}${BINDIR}/strip
  
 
 	
 
 
 >Release-Note:
 >Audit-Trail:
 >Unformatted:
 
 To Unsubscribe: send mail to majordomo@FreeBSD.org
 with "unsubscribe freebsd-bugs" in the body of the message
 
State-Changed-From-To: open->patched 
State-Changed-By: johan 
State-Changed-When: Mon Apr 29 08:17:34 PDT 2002 
State-Changed-Why:  
Ruslan fixed this in another way in rev 1.14. 

This get to serve as a MFC reminder. 


Responsible-Changed-From-To: freebsd-bugs->ru 
Responsible-Changed-By: johan 
Responsible-Changed-When: Mon Apr 29 08:17:34 PDT 2002 
Responsible-Changed-Why:  
Ruslan fixed this in another way in rev 1.14. 

This get to serve as a MFC reminder. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=37516 

From: Ruslan Ermilov <ru@FreeBSD.org>
To: Murray Stokely <murray@FreeBSD.org>, johan@FreeBSD.org
Cc: bug-followup@FreeBSD.org
Subject: Re: misc/37516: installworld fails in usr.bin/strip if NOMAN=true
Date: Mon, 29 Apr 2002 19:13:29 +0300

 --fUYQa+Pmc3FrFX/N
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 Content-Transfer-Encoding: quoted-printable
 
 Murray,
 
 The mistery is now gone.  :-)
 
 So that was indeed it.  The first "installworld" during "make
 installworld" is -DNOMAN install, and "maninstall" is no longer
 a standard target (standard targets are always defined).
 
 The unstandardization of maninstall means it now only defined
 if bsd.man.mk is included by bsd.prog.mk (which only happens
 if NOMAN is _not_ set).
 
 The bug was in usr.bin/strip/Makefile.  Initially the bug was
 non-fatal but became fatal after this change.  An alternative,
 less effective, but easier to undestand fix might look like
 this (for demo purposes only):
 
 %%%
 Index: Makefile
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
 RCS file: /home/ncvs/src/usr.bin/strip/Makefile,v
 retrieving revision 1.10.6.1
 diff -u -r1.10.6.1 Makefile
 --- Makefile	25 Apr 2001 11:29:41 -0000	1.10.6.1
 +++ Makefile	29 Apr 2002 16:06:33 -0000
 @@ -16,8 +16,11 @@
  .endif
  .endif
 =20
 -install: maninstall
 +install:
  	${INSTALL} ${COPY} -o ${BINOWN} -g ${BINGRP} -m ${BINMODE} \
  	    maybe_stripped ${DESTDIR}${BINDIR}/strip
 +.if !defined(NOMAN)
 +install: maninstall
 +.endif
 =20
  .include <bsd.prog.mk>
 %%%
 
 I didn't notice the problem because I had this patch developed
 locally before my share/mk changes that caused the breakage.
 
 On Mon, Apr 29, 2002 at 08:20:07AM -0700, johan@FreeBSD.org wrote:
 > Synopsis: installworld fails in usr.bin/strip if NOMAN=3Dtrue
 >=20
 > State-Changed-From-To: open->patched
 > State-Changed-By: johan
 > State-Changed-When: Mon Apr 29 08:17:34 PDT 2002
 > State-Changed-Why:=20
 > 	Ruslan fixed this in another way in rev 1.14.
 >=20
 > 	This get to serve as a MFC reminder.
 >=20
 >=20
 > Responsible-Changed-From-To: freebsd-bugs->ru
 > Responsible-Changed-By: johan
 > Responsible-Changed-When: Mon Apr 29 08:17:34 PDT 2002
 > Responsible-Changed-Why:=20
 > 	Ruslan fixed this in another way in rev 1.14.
 >=20
 > 	This get to serve as a MFC reminder.
 >=20
 > http://www.freebsd.org/cgi/query-pr.cgi?pr=3D37516
 
 --=20
 Ruslan Ermilov		Sysadmin and DBA,
 ru@sunbay.com		Sunbay Software AG,
 ru@FreeBSD.org		FreeBSD committer,
 +380.652.512.251	Simferopol, Ukraine
 
 http://www.FreeBSD.org	The Power To Serve
 http://www.oracle.com	Enabling The Information Age
 
 --fUYQa+Pmc3FrFX/N
 Content-Type: application/pgp-signature
 Content-Disposition: inline
 
 -----BEGIN PGP SIGNATURE-----
 Version: GnuPG v1.0.6 (FreeBSD)
 Comment: For info see http://www.gnupg.org
 
 iD8DBQE8zXEpUkv4P6juNwoRAgz0AJ9NkE2yvvBSTobWjuKruvPtk1W0/ACeNQn6
 h6YtDOQpJ+GgIw0TZSiMw5I=
 =SCvE
 -----END PGP SIGNATURE-----
 
 --fUYQa+Pmc3FrFX/N--
State-Changed-From-To: patched->closed 
State-Changed-By: ru 
State-Changed-When: Tue Jul 16 07:27:35 PDT 2002 
State-Changed-Why:  
Fix was merged. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=37516 
>Unformatted:
