From nobody@FreeBSD.org  Fri Jan 18 11:11:14 2002
Return-Path: <nobody@FreeBSD.org>
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 285CD37B405
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 18 Jan 2002 11:11:14 -0800 (PST)
Received: (from nobody@localhost)
	by freefall.freebsd.org (8.11.6/8.11.6) id g0IJBEm01669;
	Fri, 18 Jan 2002 11:11:14 -0800 (PST)
	(envelope-from nobody)
Message-Id: <200201181911.g0IJBEm01669@freefall.freebsd.org>
Date: Fri, 18 Jan 2002 11:11:14 -0800 (PST)
From: Mike Abbott <mike.abbott@cacheflow.com>
To: freebsd-gnats-submit@FreeBSD.org
Subject: libfetch FTP upload is broken
X-Send-Pr-Version: www-1.0

>Number:         34043
>Category:       misc
>Synopsis:       libfetch FTP upload is broken
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    des
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jan 18 11:20:00 PST 2002
>Closed-Date:    Sun Feb 3 04:30:29 PST 2002
>Last-Modified:  Sun Feb 03 04:30:30 PST 2002
>Originator:     Mike Abbott
>Release:        
>Organization:
CacheFlow, Inc.
>Environment:
>Description:
Revision 1.72 to src/lib/libfetch/ftp.c broke FTP upload.
_ftp_request() always passes O_RDONLY to _ftp_transfer() as the mode
even with STOR or APPE requests.  This causes _ftp_writefn() to fail
because io->dir == O_RDONLY.  In revision 1.71 the mode was
O_WRONLY for STOR and APPE and O_RDONLY for everything else.
>How-To-Repeat:

>Fix:
Make _ftp_request() pass mode O_WRONLY for STOR and APPE and O_RDONLY
for all other requests.
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->des 
Responsible-Changed-By: dwmalone 
Responsible-Changed-When: Fri Jan 18 13:19:41 PST 2002 
Responsible-Changed-Why:  
Over to libfetch's maintainer. 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=34043 

From: Dag-Erling Smorgrav <des@ofug.org>
To: Mike Abbott <mike.abbott@cacheflow.com>
Cc: freebsd-gnats-submit@FreeBSD.org
Subject: Re: misc/34043: libfetch FTP upload is broken
Date: 20 Jan 2002 20:47:09 +0100

 Try the attached patch:
 
 Index: ftp.c
 ===================================================================
 RCS file: /home/ncvs/src/lib/libfetch/ftp.c,v
 retrieving revision 1.73
 diff -u -r1.73 ftp.c
 --- ftp.c	1 Jan 2002 14:48:09 -0000	1.73
 +++ ftp.c	20 Jan 2002 19:44:16 -0000
 @@ -911,7 +911,7 @@
  _ftp_request(struct url *url, const char *op, struct url_stat *us,
  	     struct url *purl, const char *flags)
  {
 -    int cd;
 +    int cd, oflag;
      
      /* check if we should use HTTP instead */
      if (purl && strcasecmp(purl->scheme, SCHEME_HTTP) == 0) {
 @@ -945,9 +945,13 @@
      /* just a stat */
      if (strcmp(op, "STAT") == 0)
  	return (FILE *)1; /* bogus return value */
 +    if (strcmp(op, "STOR") == 0 || strcmp(op, "APPE") == 0)
 +	oflag = O_WRONLY;
 +    else
 +	oflag = O_RDONLY;
      
      /* initiate the transfer */
 -    return _ftp_transfer(cd, op, url->doc, O_RDONLY, url->offset, flags);
 +    return _ftp_transfer(cd, op, url->doc, oflag, url->offset, flags);
  }
  
  /*
 
 DES
 -- 
 Dag-Erling Smorgrav - des@ofug.org
State-Changed-From-To: open->feedback 
State-Changed-By: des 
State-Changed-When: Sun Jan 20 11:53:50 PST 2002 
State-Changed-Why:  
Fixed in -CURRENT, awaiting MFC. 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=34043 
State-Changed-From-To: feedback->closed 
State-Changed-By: des 
State-Changed-When: Sun Feb 3 04:30:29 PST 2002 
State-Changed-Why:  
MFCed. 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=34043 
>Unformatted:
