From nobody@FreeBSD.org  Tue Sep 18 08:00:37 2001
Return-Path: <nobody@FreeBSD.org>
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 2112237B410
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 18 Sep 2001 08:00:37 -0700 (PDT)
Received: (from nobody@localhost)
	by freefall.freebsd.org (8.11.4/8.11.4) id f8IF0bt70787;
	Tue, 18 Sep 2001 08:00:37 -0700 (PDT)
	(envelope-from nobody)
Message-Id: <200109181500.f8IF0bt70787@freefall.freebsd.org>
Date: Tue, 18 Sep 2001 08:00:37 -0700 (PDT)
From: NIIMI Satoshi <sa2c@and.or.jp>
To: freebsd-gnats-submit@FreeBSD.org
Subject: "make release" in src/release/ creates ports.tgz that includes distfiles
X-Send-Pr-Version: www-1.0

>Number:         30647
>Category:       misc
>Synopsis:       "make release" in src/release/ creates ports.tgz that includes distfiles
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Sep 18 08:10:00 PDT 2001
>Closed-Date:    Mon Mar 25 20:05:24 PST 2002
>Last-Modified:  Mon Mar 25 20:05:24 PST 2002
>Originator:     NIIMI Satoshi
>Release:        4.4-RELEASE
>Organization:
>Environment:
FreeBSD berkeley.sa2c.net 4.4-RELEASE FreeBSD 4.4-RELEASE #1: Sun Sep 16 13:03:19 JST 2001     sa2c@berkeley.sa2c.net:/usr/obj/usr/src/sys/BERKELEY  i386
>Description:
"make release" in src/relase with very large /usr/ports/distfiles,
cdrom.1 target in src/relase/Makefile failes to remove distfile.
This causes very large (for me, over 5GB)
${CHROOT}/R/cdrom/disc1/ports/ports.tgz.

>How-To-Repeat:
cd /usr/ports; make -k BATCH=yes fetch
cd /usr/src/release; make release RELEASETAG=RELENG_4_4_0_RELEASE blah blah...

>Fix:
Index: Makefile
===================================================================
RCS file: /home/ncvs/src/release/Makefile,v
retrieving revision 1.536.2.56
diff -u -r1.536.2.56 Makefile
--- Makefile    2001/09/13 06:58:31     1.536.2.56
+++ Makefile    2001/09/18 14:57:39
@@ -756,6 +756,7 @@
        @cp ${CD_DISC1}/floppies/boot.flp ${CD_DISC2}/floppies
 .endif
 .if !defined(NOPORTS)
+       @find /usr/ports/distfiles -type f -print0 | xargs -0 rm -rf --
        @-rm -rf /usr/ports/distfiles/*
        @mkdir -p ${CD_DISC1}/ports && \
          tar --exclude CVS -czf ${CD_DISC1}/ports/ports.tgz -C /usr ports && \

>Release-Note:
>Audit-Trail:

From: Peter Pentchev <roam@ringlet.net>
To: NIIMI Satoshi <sa2c@and.or.jp>
Cc: freebsd-gnats-submit@FreeBSD.org
Subject: Re: misc/30647: "make release" in src/release/ creates ports.tgz that includes distfiles
Date: Tue, 18 Sep 2001 18:33:45 +0300

 On Tue, Sep 18, 2001 at 08:00:37AM -0700, NIIMI Satoshi wrote:
 > 
 > >Number:         30647
 > >Category:       misc
 > >Synopsis:       "make release" in src/release/ creates ports.tgz that includes distfiles
 > >Originator:     NIIMI Satoshi
 > >Release:        4.4-RELEASE
 > >Organization:
 > >Environment:
 > FreeBSD berkeley.sa2c.net 4.4-RELEASE FreeBSD 4.4-RELEASE #1: Sun Sep 16 13:03:19 JST 2001     sa2c@berkeley.sa2c.net:/usr/obj/usr/src/sys/BERKELEY  i386
 > >Description:
 > "make release" in src/relase with very large /usr/ports/distfiles,
 > cdrom.1 target in src/relase/Makefile failes to remove distfile.
 > This causes very large (for me, over 5GB)
 > ${CHROOT}/R/cdrom/disc1/ports/ports.tgz.
 > 
 > >How-To-Repeat:
 > cd /usr/ports; make -k BATCH=yes fetch
 > cd /usr/src/release; make release RELEASETAG=RELENG_4_4_0_RELEASE blah blah...
 > 
 > >Fix:
 > Index: Makefile
 > ===================================================================
 > RCS file: /home/ncvs/src/release/Makefile,v
 > retrieving revision 1.536.2.56
 > diff -u -r1.536.2.56 Makefile
 > --- Makefile    2001/09/13 06:58:31     1.536.2.56
 > +++ Makefile    2001/09/18 14:57:39
 > @@ -756,6 +756,7 @@
 >         @cp ${CD_DISC1}/floppies/boot.flp ${CD_DISC2}/floppies
 >  .endif
 >  .if !defined(NOPORTS)
 > +       @find /usr/ports/distfiles -type f -print0 | xargs -0 rm -rf --
 >         @-rm -rf /usr/ports/distfiles/*
 >         @mkdir -p ${CD_DISC1}/ports && \
 >           tar --exclude CVS -czf ${CD_DISC1}/ports/ports.tgz -C /usr ports && \
 
 Without actually having looked at the problem (the 'rm -rf' at the next
 line is supposed to do the trick), the line you added could be also
 written as:
 
 	@find /usr/ports/distfiles -type f -delete
 
 It is another question just why the rm -rf cannot really delete things..
 
 G'luck,
 Peter
 
 -- 
 Hey, out there - is it *you* reading me, or is it someone else?

From: NIIMI Satoshi <sa2c@and.or.jp>
To: Peter Pentchev <roam@ringlet.net>
Cc: freebsd-gnats-submit@FreeBSD.org
Subject: Re: misc/30647: "make release" in src/release/ creates ports.tgz that includes distfiles
Date: 19 Sep 2001 00:49:11 +0900

 Peter Pentchev <roam@ringlet.net> writes:
 
 > Without actually having looked at the problem (the 'rm -rf' at the next
 > line is supposed to do the trick), the line you added could be also
 > written as:
 > 
 > 	@find /usr/ports/distfiles -type f -delete
 
 Yes.
 
 > It is another question just why the rm -rf cannot really delete things..
 
 I'm sorry to forget include the error message.
 The reason why 'rm -rf' failed is
         rm: argument list too long
 
 Thanks,
 

From: Makoto Matsushita <matusita@jp.FreeBSD.org>
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: misc/30647: "make release" in src/release/ creates ports.tgz
 that includes distfiles
Date: Sun, 24 Feb 2002 12:02:17 +0900

 I assume that this problem is already gone.  Would you please check
 current src/release/Makefile?
 
 If it is OK for you, I wanna close this PR.
 
 -- -
 Makoto `MAR' Matsushita
State-Changed-From-To: open->feedback 
State-Changed-By: matusita 
State-Changed-When: Mon Mar 25 06:24:39 PST 2002 
State-Changed-Why:  
Still awaiting the submitter's feedback. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=30647 
State-Changed-From-To: feedback->closed 
State-Changed-By: matusita 
State-Changed-When: Mon Mar 25 19:59:48 PST 2002 
State-Changed-Why:  
The submitter agrees to close this PR (see freebsd-bugs@FreeBSD.org). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=30647 
>Unformatted:
