From missnglnk@informationwave.net  Tue Jun 19 20:22:37 2001
Return-Path: <missnglnk@informationwave.net>
Received: from subtopia.informationwave.net (subtopia.informationwave.net [199.74.235.3])
	by hub.freebsd.org (Postfix) with ESMTP id DA67037B403
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 19 Jun 2001 20:22:36 -0700 (PDT)
	(envelope-from missnglnk@informationwave.net)
Received: by subtopia.informationwave.net (Postfix, from userid 100)
	id 811DE1C973; Tue, 19 Jun 2001 23:15:11 -0400 (EDT)
Message-Id: <20010619231511.A2899@subtopia.informationwave.net>
Date: Tue, 19 Jun 2001 23:15:11 -0400
From: Omachonu Ogali <missnglnk@informationwave.net>
To: FreeBSD-gnats-submit@freebsd.org
Subject: IPv6 support isn't #ifdef'd in src/contrib/tcpdump/print-ospf6.c

>Number:         28288
>Category:       misc
>Synopsis:       IPv6 support isn't #ifdef'd in src/contrib/tcpdump/print-ospf6.c
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    fenner
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jun 19 20:30:03 PDT 2001
>Closed-Date:    Wed Jul 11 14:46:31 PDT 2001
>Last-Modified:  Wed Jul 11 14:47:13 PDT 2001
>Originator:     Omachonu Ogali
>Release:        FreeBSD 5.0-CURRENT i386
>Organization:
>Environment:
System: FreeBSD hydrant.intranova.net 5.0-CURRENT FreeBSD 5.0-CURRENT #0: Mon Jun 18 18:29:39 EDT 2001 root@hydrant.intranova.net:/usr/src/sys/compile/GENERIC i386

>Description:
	IPv6 support is not checked in src/contrib/tcpdump/print-ospf6.c a 
	la #ifdef as it is in the other print-*6.c files, resulting in
	undefined references.
>How-To-Repeat:
	Compile without IPv6 support.
>Fix:
	--- src/contrib/tcpdump/print-ospf6.c.orig	Thu Jun 14 02:23:25 2001
	+++ src/contrib/tcpdump/print-ospf6.c	Tue Jun 19 22:59:38 2001
	@@ -32,2 +32,4 @@
	 
	+#ifdef INET6
	+
	 #include <sys/param.h>
	@@ -684 +686,3 @@
	 }
	+
	+#endif /* INET6 */
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: dwmalone 
State-Changed-When: Wed Jun 20 05:47:52 PDT 2001 
State-Changed-Why:  


http://www.FreeBSD.org/cgi/query-pr.cgi?pr=28288 
State-Changed-From-To: closed->open 
State-Changed-By: dwmalone 
State-Changed-When: Wed Jun 20 05:48:17 PDT 2001 
State-Changed-Why:  
Closed accidently. Give PR to Bill Fenner, who's looking after tcpdump. 


Responsible-Changed-From-To: freebsd-bugs->fenner 
Responsible-Changed-By: dwmalone 
Responsible-Changed-When: Wed Jun 20 05:48:17 PDT 2001 
Responsible-Changed-Why:  
Bill Fenner looks after tcpdump. 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=28288 

From: Bill Fenner <fenner@research.att.com>
To: missinglnk@informationwave.net, freebsd-gnats-submit@freebsd.org,
	fenner@research.att.com
Cc:  
Subject: Re: misc/28288: IPv6 support isn't #ifdef'd in src/contrib/tcpdump/print-ospf6.c
Date: Wed, 20 Jun 2001 08:34:04 -0700 (PDT)

 Would you try this patch?  tcpdump itself conditionally includes these
 sources, which is why there's no ifdef.
 
 Thanks,
   Bill
 
 cvs diff: Diffing .
 Index: Makefile
 ===================================================================
 RCS file: /home/ncvs/src/usr.sbin/tcpdump/tcpdump/Makefile,v
 retrieving revision 1.30
 diff -u -r1.30 Makefile
 --- Makefile	2001/04/20 17:30:11	1.30
 +++ Makefile	2001/06/20 15:30:37
 @@ -8,16 +8,16 @@
  	print-ah.c print-arp.c print-ascii.c print-atalk.c \
  	print-atm.c print-bgp.c print-bootp.c print-bxxp.c \
  	print-cdp.c print-chdlc.c print-cip.c print-cnfp.c \
 -	print-decnet.c print-dhcp6.c print-domain.c print-dvmrp.c \
 +	print-decnet.c print-domain.c print-dvmrp.c \
  	print-egp.c print-esp.c print-ether.c print-fddi.c \
 -	print-frag6.c print-gre.c print-icmp.c print-icmp6.c \
 -	print-igmp.c print-igrp.c print-ip.c print-ip6.c \
 -	print-ip6opts.c print-ipcomp.c print-ipx.c print-isakmp.c \
 +	print-gre.c print-icmp.c \
 +	print-igmp.c print-igrp.c print-ip.c \
 +	print-ipcomp.c print-ipx.c print-isakmp.c \
  	print-isoclns.c print-krb.c print-l2tp.c print-lane.c \
  	print-lcp.c print-llc.c print-mobile.c print-nfs.c \
 -	print-ntp.c print-null.c print-ospf.c print-ospf6.c \
 +	print-ntp.c print-null.c print-ospf.c \
  	print-pim.c print-ppp.c print-pppoe.c print-radius.c \
 -	print-raw.c print-rip.c print-ripng.c print-rt6.c \
 +	print-raw.c print-rip.c \
  	print-rx.c print-sl.c print-sll.c print-smb.c print-snmp.c \
  	print-stp.c print-sunrpc.c print-tcp.c print-telnet.c \
  	print-tftp.c print-timed.c print-token.c print-udp.c \
 @@ -28,6 +28,8 @@
  CFLAGS+= -DHAVE_CONFIG_H
  .if !defined(NOINET6)
  CFLAGS+=	-DINET6
 +SRCS+=		print-ip6.c print-ip6opts.c print-ripng.c print-icmp6.c \
 +		print-frag6.c print-rt6.c print-ospf6.c print-dhcp6.c
  .endif
  
  DPADD+=	${LIBL} ${LIBPCAP}

From: Omachonu Ogali <missnglnk@informationwave.net>
To: Bill Fenner <fenner@research.att.com>
Cc: freebsd-gnats-submit@freebsd.org
Subject: Re: misc/28288: IPv6 support isn't #ifdef'd in src/contrib/tcpdump/print-ospf6.c
Date: Wed, 20 Jun 2001 15:16:31 -0400

 On Wed, Jun 20, 2001 at 08:55:54AM -0700, Bill Fenner wrote:
 > 
 > [My original message bounced, but some really brilliant internal AT&T
 > mailer stripped the bounce message so I got an email from your
 > mailer-daemon with "<<< MIME ATTACHMENT STRIPPED >>>" -- if you reply,
 > please cc freebsd-gnats-submit@freebsd.org on your reply and keep the
 > subject the same.  Sorry for the confusion.]
 > 
 > Would you try this patch?  tcpdump itself conditionally includes these
 > sources, which is why there's no ifdef.
 
 Woohoo! I took a look at print-ip6.c and saw it #ifdef'd in there,
 didn't know about the Makefile thingy. :)
 
 > Thanks,
 >   Bill
 > 
 > cvs diff: Diffing .
 > Index: Makefile
 > ===================================================================
 > RCS file: /home/ncvs/src/usr.sbin/tcpdump/tcpdump/Makefile,v
 > retrieving revision 1.30
 > diff -u -r1.30 Makefile
 > --- Makefile	2001/04/20 17:30:11	1.30
 > +++ Makefile	2001/06/20 15:30:37
 > @@ -8,16 +8,16 @@
 >  	print-ah.c print-arp.c print-ascii.c print-atalk.c \
 >  	print-atm.c print-bgp.c print-bootp.c print-bxxp.c \
 >  	print-cdp.c print-chdlc.c print-cip.c print-cnfp.c \
 > -	print-decnet.c print-dhcp6.c print-domain.c print-dvmrp.c \
 > +	print-decnet.c print-domain.c print-dvmrp.c \
 >  	print-egp.c print-esp.c print-ether.c print-fddi.c \
 > -	print-frag6.c print-gre.c print-icmp.c print-icmp6.c \
 > -	print-igmp.c print-igrp.c print-ip.c print-ip6.c \
 > -	print-ip6opts.c print-ipcomp.c print-ipx.c print-isakmp.c \
 > +	print-gre.c print-icmp.c \
 > +	print-igmp.c print-igrp.c print-ip.c \
 > +	print-ipcomp.c print-ipx.c print-isakmp.c \
 >  	print-isoclns.c print-krb.c print-l2tp.c print-lane.c \
 >  	print-lcp.c print-llc.c print-mobile.c print-nfs.c \
 > -	print-ntp.c print-null.c print-ospf.c print-ospf6.c \
 > +	print-ntp.c print-null.c print-ospf.c \
 >  	print-pim.c print-ppp.c print-pppoe.c print-radius.c \
 > -	print-raw.c print-rip.c print-ripng.c print-rt6.c \
 > +	print-raw.c print-rip.c \
 >  	print-rx.c print-sl.c print-sll.c print-smb.c print-snmp.c \
 >  	print-stp.c print-sunrpc.c print-tcp.c print-telnet.c \
 >  	print-tftp.c print-timed.c print-token.c print-udp.c \
 > @@ -28,6 +28,8 @@
 >  CFLAGS+= -DHAVE_CONFIG_H
 >  .if !defined(NOINET6)
 >  CFLAGS+=	-DINET6
 > +SRCS+=		print-ip6.c print-ip6opts.c print-ripng.c print-icmp6.c \
 > +		print-frag6.c print-rt6.c print-ospf6.c print-dhcp6.c
 >  .endif
 >  
 >  DPADD+=	${LIBL} ${LIBPCAP}
 > 
 > 
 > 
 
 -- 
 Omachonu Ogali
 missnglnk@informationwave.net
 http://www.informationwave.net
State-Changed-From-To: open->closed 
State-Changed-By: fenner 
State-Changed-When: Wed Jul 11 14:46:31 PDT 2001 
State-Changed-Why:  
Fixed in rev 1.31 of src/usr.sbin/tcpdump/tcpdump/Makefile 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=28288 
>Unformatted:
 To: FreeBSD-gnats-submit@freebsd.org
 Subject: IPv6 support isn't #ifdef'd in src/contrib/tcpdump/print-ospf6.c
 From: Omachonu Ogali <missnglnk@informationwave.net>
 Reply-To: Omachonu Ogali <missnglnk@informationwave.net>
 Cc: 
 X-send-pr-version: 3.113
 X-GNATS-Notify: 
 
 
