From matt@braithwaite.net  Tue Jun 19 15:46:11 2001
Return-Path: <matt@braithwaite.net>
Received: from limekiller.braithwaite.net (foo82.dsl.alink.net [207.135.112.82])
	by hub.freebsd.org (Postfix) with ESMTP id E1B1237B401
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 19 Jun 2001 15:46:10 -0700 (PDT)
	(envelope-from matt@braithwaite.net)
Received: by limekiller.braithwaite.net (Postfix, from userid 1001)
	id 680A75A7D; Tue, 19 Jun 2001 15:46:10 -0700 (PDT)
Message-Id: <20010417064828.B0FCB5C79@limekiller.braithwaite.net>
Date: Mon, 16 Apr 2001 23:48:28 -0700 (PDT)
From: Matthew Braithwaite <matt@braithwaite.net>
To: FreeBSD-gnats-submit@freebsd.org
Subject: Missed free() in init(8):clean_ttys
X-Send-Pr-Version: 3.2

>Number:         28283
>Category:       misc
>Synopsis:       Due to apparent typo, result of strdup not freed
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    mikeh
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jun 19 15:50:01 PDT 2001
>Closed-Date:    Tue Jul 3 16:11:19 PDT 2001
>Last-Modified:  Tue Jul 03 16:12:08 PDT 2001
>Originator:     Matthew Braithwaite
>Release:        FreeBSD 4.2-RELEASE i386
>Organization:
>Environment:
>Description:

This sure looks like a typo to me:

*** init.c      Mon Jul 31 23:49:06 2000
--- /tmp/init.c Mon Apr 16 23:45:22 2001
***************
*** 1401,1407 ****
                        }
                        if (old_getty)
                                free(old_getty);
!                       if (old_getty)
                                free(old_window);
                        if (old_type)
                                free(old_type);
--- 1401,1407 ----
                        }
                        if (old_getty)
                                free(old_getty);
!                       if (old_window)
                                free(old_window);
                        if (old_type)
                                free(old_type);

>How-To-Repeat:
>Fix:
>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->mikeh 
Responsible-Changed-By: mikeh 
Responsible-Changed-When: Tue Jun 19 16:55:33 PDT 2001 
Responsible-Changed-Why:  
Look's reasonable I'll look at it. 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=28283 
State-Changed-From-To: open->analyzed 
State-Changed-By: mikeh 
State-Changed-When: Tue Jun 19 18:56:19 PDT 2001 
State-Changed-Why:  
Committed, thanks! (MFC in 2 weeks) 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=28283 
State-Changed-From-To: analyzed->closed 
State-Changed-By: mikeh 
State-Changed-When: Tue Jul 3 16:11:19 PDT 2001 
State-Changed-Why:  
Fix MFC'd. 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=28283 
>Unformatted:
