From nobody@FreeBSD.org  Mon Apr  2 18:21:06 2001
Return-Path: <nobody@FreeBSD.org>
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 26C2E37B718
	for <freebsd-gnats-submit@FreeBSD.org>; Mon,  2 Apr 2001 18:21:06 -0700 (PDT)
	(envelope-from nobody@FreeBSD.org)
Received: (from nobody@localhost)
	by freefall.freebsd.org (8.11.1/8.11.1) id f331L6655584;
	Mon, 2 Apr 2001 18:21:06 -0700 (PDT)
	(envelope-from nobody)
Message-Id: <200104030121.f331L6655584@freefall.freebsd.org>
Date: Mon, 2 Apr 2001 18:21:06 -0700 (PDT)
From: otterr@telocity.com
To: freebsd-gnats-submit@FreeBSD.org
Subject: misspelling in burncd application
X-Send-Pr-Version: www-1.0

>Number:         26306
>Category:       misc
>Synopsis:       misspelling in burncd application
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    sos
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Apr 02 18:30:01 PDT 2001
>Closed-Date:    Wed May 30 01:07:27 PDT 2001
>Last-Modified:  Wed May 30 01:14:03 PDT 2001
>Originator:     Otter
>Release:        4.3-RC (March 31, 2001)
>Organization:
>Environment:
FreeBSD kashmir.myip.org 4.3-RC FreeBSD 4.3-RC #7: Sat Mar 31 21:37:09 EST 2001     otterr@kashmir.myip.org:/usr/obj/usr/src/sys/kashmir  i386
>Description:
When using burncd to erase a CD-RW, it echoes "eraseing CD, please wait..". 
>How-To-Repeat:
prompt> burncd -f <device> erase
>Fix:
"eraseing" should be corrected to reflect the proper spelling: "erasing". (No offense to the Danes. The app makes up for it!)
>Release-Note:
>Audit-Trail:

From: Dima Dorfman <dima@unixfreak.org>
To: otterr@telocity.com
Cc: freebsd-gnats-submit@FreeBSD.org, sos@freebsd.org
Subject: Re: misc/26306: misspelling in burncd application 
Date: Mon, 02 Apr 2001 19:04:25 -0700

 [ cc'd to sos, the burncd author ]
 
 otterr@telocity.com writes:
 > 
 > >Number:         26306
 > >Category:       misc
 > >Synopsis:       misspelling in burncd application
 >
 > >Description:
 > When using burncd to erase a CD-RW, it echoes "eraseing CD, please wait..". 
 >
 > >Fix:
 > "eraseing" should be corrected to reflect the proper spelling: "erasing". (No
 >  offense to the Danes. The app makes up for it!)
 
 Actually, it isn't a spelling error on the author's part per se.  The
 way it's written in the code, it's very easy to overlook this mistake
 (esp. for a non-native English speaker).  Just thought I'd point that
 out.
 
 Attached is a patch.  It compiles, but other than that I've not tested
 it (I don't have a burner).
 
 					Dima Dorfman
 					dima@unixfreak.org
 
 Index: burncd.c
 ===================================================================
 RCS file: /st/src/FreeBSD/src/usr.sbin/burncd/burncd.c,v
 retrieving revision 1.12
 diff -u -r1.12 burncd.c
 --- burncd.c	2001/01/10 19:28:37	1.12
 +++ burncd.c	2001/04/03 02:01:45
 @@ -141,13 +141,17 @@
  		}
  		if (!strcmp(argv[arg], "erase") || !strcmp(argv[arg], "blank")){
  		    	int error, blank, percent;
 -			if (!quiet)
 -				fprintf(stderr, "%sing CD, please wait..\r",
 -					argv[arg]);
 -			if (!strcmp(argv[arg], "erase"))
 +			char *act_ing;
 +			if (!strcmp(argv[arg], "erase")) {
  				blank = CDR_B_ALL;
 -			else
 +				act_ing = "erasing";
 +			} else {
  				blank = CDR_B_MIN;
 +				act_ing = "blanking";
 +			}
 +			if (!quiet)
 +				fprintf(stderr, "%s CD, please wait..\r",
 +					act_ing);
  
  			if (ioctl(fd, CDRIOCBLANK, &blank) < 0)
          			err(EX_IOERR, "ioctl(CDRIOCBLANK)");
 @@ -156,9 +160,9 @@
  				error = ioctl(fd, CDRIOCGETPROGRESS, &percent);
  				if (percent > 0 && !quiet)
  					fprintf(stderr, 
 -						"%sing CD - %d %% done"
 +						"%s CD - %d %% done"
  						"     \r",
 -						argv[arg], percent);
 +						act_ing, percent);
  				if (error || percent == 100)
  					break;
  			}
 
Responsible-Changed-From-To: freebsd-bugs->sos 
Responsible-Changed-By: dd 
Responsible-Changed-When: Sat Apr 28 20:17:47 PDT 2001 
Responsible-Changed-Why:  
Over to maintainer (sos, this one has a patch). 

http://www.freebsd.org/cgi/query-pr.cgi?pr=26306 
State-Changed-From-To: open->closed 
State-Changed-By: sos 
State-Changed-When: Wed May 30 01:07:27 PDT 2001 
State-Changed-Why:  
Point taken :) fix a bit differently in -current. 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=26306 
>Unformatted:
