From nobody@FreeBSD.org  Fri Mar 23 21:00:32 2001
Return-Path: <nobody@FreeBSD.org>
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id D96B037B71A
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 23 Mar 2001 21:00:18 -0800 (PST)
	(envelope-from nobody@FreeBSD.org)
Received: (from nobody@localhost)
	by freefall.freebsd.org (8.11.1/8.11.1) id f2O50Ir84611;
	Fri, 23 Mar 2001 21:00:18 -0800 (PST)
	(envelope-from nobody)
Message-Id: <200103240500.f2O50Ir84611@freefall.freebsd.org>
Date: Fri, 23 Mar 2001 21:00:18 -0800 (PST)
From: miles@turboflux.net
To: freebsd-gnats-submit@FreeBSD.org
Subject: vsprintf calls __swsetup, then __smakebuf, it allocates mem and never frees it
X-Send-Pr-Version: www-1.0

>Number:         26044
>Category:       misc
>Synopsis:       vsprintf calls __swsetup, then __smakebuf, it allocates mem and never frees it
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    billf
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Mar 23 21:10:01 PST 2001
>Closed-Date:    Fri May 31 02:16:22 PDT 2002
>Last-Modified:  Fri May 31 02:16:22 PDT 2002
>Originator:     Miles Peterson
>Release:        4.2-STABLE
>Organization:
>Environment:
FreeBSD Phased.turboflux.net 4.2-STABLE FreeBSD 4.2-STABLE #2: Wed Dec 27 11:49:05 MST 2000     root@Phased.turboflux.net:/usr/src/sys/compile/BRIDGE  i386
>Description:
vsnprintf() has "FILE f" and sets "f._bf._base = str;" (where str is what the user passes in).  If user passes in NULL, __swsetup(&f) calls __smakebuf(&f), which allocates a buffer that isnt ever freed.
/usr/src/lib/libc/stdio/vsnprintf.c
>How-To-Repeat:
vsnprintf(NULL, 0, "yadda yadda!\n"); /* should do it */
>Fix:
if (!str) free(p._bf._base); /* just before the return (ret) */
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: assar 
State-Changed-When: Fri Jun 15 22:46:30 PDT 2001 
State-Changed-Why:  
thanks.  fixed. 


Responsible-Changed-From-To: freebsd-bugs->assar 
Responsible-Changed-By: assar 
Responsible-Changed-When: Fri Jun 15 22:46:30 PDT 2001 
Responsible-Changed-Why:  
I fixed it 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=26044 
State-Changed-From-To: closed->open 
State-Changed-By: billf 
State-Changed-When: Thu May 30 10:37:24 PDT 2002 
State-Changed-Why:  
this bug still exists. 


Responsible-Changed-From-To: assar->freebsd-bugs 
Responsible-Changed-By: billf 
Responsible-Changed-When: Thu May 30 10:37:24 PDT 2002 
Responsible-Changed-Why:  
this bug still exists. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=26044 

From: Maxim Konovalov <maxim@macomnet.ru>
To: billf@FreeBSD.ORG
Cc: miles@turboflux.net, <assar@FreeBSD.ORG>,
	<bug-followup@FreeBSD.ORG>
Subject: Re: misc/26044: vsprintf calls __swsetup, then __smakebuf, it
 allocates mem and never frees it
Date: Fri, 31 May 2002 13:01:44 +0400 (MSD)

 bin/36175 has a fix obtained from OpenBSD:
 
 http://www.FreeBSD.org/cgi/query-pr.cgi?pr=bin/36175
 
 On 10:38-0700, May 30, 2002, billf@FreeBSD.ORG wrote:
 
 > Synopsis: vsprintf calls __swsetup, then __smakebuf, it allocates mem and never frees it
 >
 > State-Changed-From-To: closed->open
 > State-Changed-By: billf
 > State-Changed-When: Thu May 30 10:37:24 PDT 2002
 > State-Changed-Why:
 > this bug still exists.
 >
 >
 > Responsible-Changed-From-To: assar->freebsd-bugs
 > Responsible-Changed-By: billf
 > Responsible-Changed-When: Thu May 30 10:37:24 PDT 2002
 > Responsible-Changed-Why:
 > this bug still exists.
 >
 > http://www.freebsd.org/cgi/query-pr.cgi?pr=26044
 >
 > To Unsubscribe: send mail to majordomo@FreeBSD.org
 > with "unsubscribe freebsd-bugs" in the body of the message
 >
 >
 
 -- 
 Maxim Konovalov, MAcomnet, Internet Dept., system engineer
 phone: +7 (095) 796-9079, mailto:maxim@macomnet.ru
 
State-Changed-From-To: open->closed 
State-Changed-By: billf 
State-Changed-When: Fri May 31 02:15:57 PDT 2002 
State-Changed-Why:  
see pr# 36175 


Responsible-Changed-From-To: freebsd-bugs->billf 
Responsible-Changed-By: billf 
Responsible-Changed-When: Fri May 31 02:15:57 PDT 2002 
Responsible-Changed-Why:  
see pr# 36175 

http://www.freebsd.org/cgi/query-pr.cgi?pr=26044 
>Unformatted:
