From sketchy@weirdo.netcraft.com  Wed Mar  7 15:59:40 2001
Return-Path: <sketchy@weirdo.netcraft.com>
Received: from weirdo.netcraft.com (weirdo.netcraft.com [195.92.95.47])
	by hub.freebsd.org (Postfix) with ESMTP id 10FAB37B719
	for <FreeBSD-gnats-submit@freebsd.org>; Wed,  7 Mar 2001 15:59:39 -0800 (PST)
	(envelope-from sketchy@weirdo.netcraft.com)
Received: (from sketchy@localhost)
	by weirdo.netcraft.com (8.11.1/8.11.1) id f27NxYJ03806;
	Wed, 7 Mar 2001 23:59:35 GMT
	(envelope-from sketchy)
Message-Id: <200103072359.f27NxYJ03806@weirdo.netcraft.com>
Date: Wed, 7 Mar 2001 23:59:35 GMT
From: Jonathan Perkin <sketchy@bsdcode.net>
Reply-To: Jonathan Perkin <sketchy@bsdcode.net>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: "distribution:" target for src/etc/Makefile fails with devfs
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         25596
>Category:       misc
>Synopsis:       "distribution:" target for src/etc/Makefile fails with devfs
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed Mar 07 16:00:01 PST 2001
>Closed-Date:    Mon Mar 12 19:06:04 PST 2001
>Last-Modified:  Mon Mar 12 19:06:17 PST 2001
>Originator:     Jonathan Perkin
>Release:        FreeBSD 5.0-CURRENT i386
>Organization:
none
>Environment:
System: FreeBSD weirdo.bsdcode.net 5.0-CURRENT FreeBSD 5.0-CURRENT #1: Tue Mar 6 16:28:18 GMT 2001 sketchy@weirdo.bsdcode.net:/usr/obj/usr/src/sys/WEIRDO i386


>Description:

	Since DEVFS was made default in -current a month or so ago, the
	distribution target in src/etc/Makefile has been broken because
	MAKEDEV cannot be installed to /dev

	distribution is still a viable target, especially for people such as
	myself who occasionally like to wipe out /etc + /var and repopulate
	from scratch to avoid old cruft.  But even a "make -k" fails to work.

	Moving the MAKEDEV installation inside the testcase for NO_MAKEDEV
	makes sense anyway, as if you don't want /dev to be recreated,
	you're unlikely to want MAKEDEV to be reinstalled.

	(I apologise if this pr has already been received - I'm not sure
	whether it's related to mail problems I've been having recently or
	whether the gnats system is just slow :o)

>How-To-Repeat:
	
	$ cd /usr/src/etc
	$ make [-k] [NO_MAKEDEV=yes] distribution

>Fix:

Index: Makefile
===================================================================
RCS file: /home/ncvs/src/etc/Makefile,v
retrieving revision 1.243
diff -u -r1.243 Makefile
--- Makefile	2001/03/01 03:51:18	1.243
+++ Makefile	2001/03/07 12:22:40
@@ -76,9 +76,7 @@
 	( cd ${.CURDIR}/../share/termcap; ${MAKE} etc-termcap ); \
 	( cd ${.CURDIR}/../usr.sbin/rmt; ${MAKE} etc-rmt ); \
 	( cd ${.CURDIR}/isdn; ${MAKE} install ); \
-	pwd_mkdb -p -d ${DESTDIR}/etc ${DESTDIR}/etc/master.passwd; \
-	${INSTALL} -c -o ${BINOWN} -g ${BINGRP} -m 555 \
-	     MAKEDEV.local MAKEDEV ${DESTDIR}/dev )
+	pwd_mkdb -p -d ${DESTDIR}/etc ${DESTDIR}/etc/master.passwd; )
 .if !defined(NO_SENDMAIL)
 	( cd ${.CURDIR}/sendmail; ${MAKE} distribution );
 .endif
@@ -94,6 +92,9 @@
 	    ${DESTDIR}/etc/ssl )
 .endif
 .if !defined(NO_MAKEDEV)
+	(cd ${.CURDIR}; \
+	${INSTALL} -c -o ${BINOWN} -g ${BINGRP} -m 555 \
+	     MAKEDEV.local MAKEDEV ${DESTDIR}/dev )
 	(cd ${DESTDIR}/dev; sh MAKEDEV all)
 .endif
 	(cd ${.CURDIR}/root; \
>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: des 
State-Changed-When: Mon Mar 12 19:06:04 PST 2001 
State-Changed-Why:  
Fixed. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=25596 
>Unformatted:
