From mwm@mired.org  Sat Nov 25 12:13:23 2000
Return-Path: <mwm@mired.org>
Received: from guru.mired.org (okc-65-26-235-186.mmcable.com [65.26.235.186])
	by hub.freebsd.org (Postfix) with SMTP id 4181737B4C5
	for <FreeBSD-gnats-submit@freebsd.org>; Sat, 25 Nov 2000 12:13:23 -0800 (PST)
Received: (qmail 75769 invoked by uid 100); 25 Nov 2000 20:13:22 -0000
Message-Id: <20001125201322.75768.qmail@guru.mired.org>
Date: 25 Nov 2000 20:13:22 -0000
From: mwm@mired.org
Reply-To: mwm@mired.org
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: The PR system has no way to let committers know that a PR includes commitable code
X-Send-Pr-Version: 3.113
X-GNATS-Notify:

>Number:         23094
>Category:       misc
>Synopsis:       The PR system has no way to let committers know that a PR includes commitable code
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    dd
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Nov 25 12:20:01 PST 2000
>Closed-Date:    Sat Aug 11 13:16:05 PDT 2001
>Last-Modified:  Sat Aug 11 13:16:13 PDT 2001
>Originator:     Mike Meyer
>Release:        FreeBSD 5.0-CURRENT i386
>Organization:
Meyer Consulting
>Environment:
System: FreeBSD guru.mired.org 5.0-CURRENT FreeBSD 5.0-CURRENT #0: Sun Nov 19 06:16:20 CST 2000 mwm@guru.mired.org:/usr/obj/sharetmp/src/sys/GURU i386

>Description:

It seems that PR's that include source - patches to fix the problem,
new documentation, new code - can sit in the PR queue for months on
end. While this is understandable for PRs that require debugging, a PR
that just needs to be audited and committed should either be commited
or rejected in fairly short order.

>How-To-Repeat:

Try submitting PRs and tracking how many get dealt with less than a
month, vs. how many get ignored for the same period of time. My
numbers have > 50% being ignored, and a fair percentage of the rest
drawing a comment or two, and *then* sitting unresolved.

>Fix:

Adding some kind of "contains committable material" indicator to the
PR would allow committers to easily find - and deal with - PRs where
the user has provided an immediate contribution, as opposed to just a
bug report. Maybe a one-line "Fix" field that has options like
"bug-report; suggestion; tested patch; new code; new docs".


>Release-Note:
>Audit-Trail:

From: Bill Fumerola <billf@mu.org>
To: mwm@mired.org
Cc: FreeBSD-gnats-submit@freebsd.org
Subject: Re: misc/23094: The PR system has no way to let committers know that a PR includes commitable code
Date: Sat, 25 Nov 2000 14:24:00 -0600

 On Sat, Nov 25, 2000 at 08:13:22PM -0000, mwm@mired.org wrote:
 
 > >Category:       misc
 > >Synopsis:       The PR system has no way to let committers know that a PR includes commitable code
 
 typically, one uses [PATCH] at the beginning of "synopsis" to indicate
 that a patch is in the PR.
 
 -- 
 Bill Fumerola - security yahoo         / Yahoo! inc.
               - fumerola@yahoo-inc.com / billf@FreeBSD.org
 
 
 
 

From: Mike Meyer <mwm@mired.org>
To: Bill Fumerola <billf@mu.org>
Cc: mwm@mired.org, FreeBSD-gnats-submit@freebsd.org
Subject: Re: misc/23094: The PR system has no way to let committers know that a PR includes commitable code
Date: Sat, 25 Nov 2000 14:26:02 -0600 (CST)

 Bill Fumerola <billf@mu.org> types:
 > On Sat, Nov 25, 2000 at 08:13:22PM -0000, mwm@mired.org wrote:
 > > >Category:       misc
 > > >Synopsis:       The PR system has no way to let committers know that a PR includes commitable code
 > 
 > typically, one uses [PATCH] at the beginning of "synopsis" to indicate
 > that a patch is in the PR.
 
 Is this documented anywhere? What about man pages, FAQ submission
 (though those are the exceptions to this problem), and new ports?
 
 	<mike
 
 --
 Mike Meyer					http://www.mired.org/home/mwm/
 Freelance WWW/Unix/FreeBSD consultant,		email for rates.
 

From: Mike Meyer <mwm@mired.org>
To: Bill Fumerola <billf@mu.org>
Cc: FreeBSD-gnats-submit@freebsd.org
Subject: Re: misc/23094: The PR system has no way to let committers know that a PR includes commitable code
Date: Sat, 25 Nov 2000 15:07:29 -0600 (CST)

 Mike Meyer <mwm@mired.org> types:
 > Bill Fumerola <billf@mu.org> types:
 > > On Sat, Nov 25, 2000 at 08:13:22PM -0000, mwm@mired.org wrote:
 > > > >Category:       misc
 > > > >Synopsis:       The PR system has no way to let committers know that a PR includes commitable code
 > > typically, one uses [PATCH] at the beginning of "synopsis" to indicate
 > > that a patch is in the PR.
 > Is this documented anywhere? What about man pages, FAQ submission
 > (though those are the exceptions to this problem), and new ports?
 
 In thinking about it, documenting that in the block of text at the top
 of the pr page would certainly solve the problem.
 
 	<mike
 
 --
 Mike Meyer					http://www.mired.org/home/mwm/
 Freelance WWW/Unix/FreeBSD consultant,		email for rates.
 
Responsible-Changed-From-To: freebsd-bugs->dd 
Responsible-Changed-By: dd 
Responsible-Changed-When: Thu May 31 18:58:07 PDT 2001 
Responsible-Changed-Why:  
I'll document this somewhere.  Of course, if you (the originator) would like 
to suggest a place or even supply a patch, it would be most appreciated :-) 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=23094 

From: <pavalos@theshell.com>
To: dd@freebsd.org, freebsd-gnats-submit@freebsd.org, mwm@mired.org
Cc:  
Subject: Re: misc/23094: The PR system has no way to let committers know that a PR includes commitable code
Date: Sat, 21 Jul 2001 04:14:23 -0700 (PDT)

 I'm not an expert at sgml, but these changes should take care of any
 confusion/frustration for submitting patches.
 
 Index: chapter.sgml
 ===================================================================
 RCS file: /home/ncvs/doc/en_US.ISO8859-1/books/handbook/contrib/chapter.sgml,v
 retrieving revision 1.456
 diff -u -r1.456 chapter.sgml
 --- chapter.sgml	2001/07/19 12:58:52	1.456
 +++ chapter.sgml	2001/07/21 11:02:19
 @@ -445,7 +445,8 @@
  	report it using the &man.send-pr.1; program or its <ulink
  	  url="http://www.FreeBSD.org/send-pr.html">WEB-based
  	  equivalent</ulink>.  Try to fill-in each field of the bug report.
 -	Unless they exceed 65KB, include any patches directly in the report.
 +	Unless they exceed 65KB, include any patches directly in the report,
 +	and put <literal>"[PATCH]"</literal> in the synopsis.
  	When including patches, <emphasis>do not</emphasis> use cut-and-paste
  	because cut-and-paste turns tabs into spaces and makes them unusable.
  	Consider compressing patches and using &man.uuencode.1; if they exceed
 @@ -522,8 +523,9 @@
  	<emphasis>Do not</emphasis> just send the diffs to the &a.hackers; or
  	they will get lost! We greatly appreciate your submission (this is a
  	volunteer project!); because we are busy, we may not be able to
 -	address it immediately, but it will remain in the pr database until we
 -	do.</para>
 +	address it immediately, but it will remain in the PR database until we
 +	do.  Indicate your submission by including <literal>"[PATCH]"</literal>
 +	in the synopsis of the report.</para>
  
        <indexterm>
          <primary><command>uuencode</command></primary>
 

From: Dima Dorfman <dima@unixfreak.org>
To: pavalos@theshell.com
Cc: freebsd-gnats-submit@freebsd.org
Subject: Re: misc/23094: The PR system has no way to let committers know that a PR includes commitable code 
Date: Sun, 22 Jul 2001 08:53:59 -0700

 <pavalos@theshell.com> writes:
 > Index: chapter.sgml
 > ===================================================================
 > RCS file: /home/ncvs/doc/en_US.ISO8859-1/books/handbook/contrib/chapter.sgml,
 > v
 > retrieving revision 1.456
 > diff -u -r1.456 chapter.sgml
 > --- chapter.sgml	2001/07/19 12:58:52	1.456
 > +++ chapter.sgml	2001/07/21 11:02:19
 > @@ -445,7 +445,8 @@
 >  	report it using the &man.send-pr.1; program or its <ulink
 >  	  url="http://www.FreeBSD.org/send-pr.html">WEB-based
 >  	  equivalent</ulink>.  Try to fill-in each field of the bug report.
 > -	Unless they exceed 65KB, include any patches directly in the report.
 > +	Unless they exceed 65KB, include any patches directly in the report,
 > +	and put <literal>"[PATCH]"</literal> in the synopsis.
 
 Just <literal>[PATCH]</literal> should suffice (no quotes).
 
 Also, it'd be nice if whatever mentions [PATCH] mentioned that this
 should be used for patches which are suitable to be applied to the
 repository.  There are some PRs labeled [PATCH] where the patch is
 something like a sample program, or a way to reproduce the bug.  I.e.,
 [PATCH] means "patch that could be applied", not "there is a patch
 somewhere in this PR".
 
 Thanks.

From: <pavalos@theshell.com>
To: dima@unixfreak.org, freebsd-gnats-submit@freebsd.org
Cc:  
Subject: Re: misc/23094: The PR system has no way to let committers know that a PR includes commitable code
Date: Thu, 26 Jul 2001 11:30:23 -0700 (PDT)

 It's not super robust, but how's this:
 
 Index: chapter.sgml
 ===================================================================
 RCS file: /home/ncvs/doc/en_US.ISO8859-1/books/handbook/contrib/chapter.sgml,v
 retrieving revision 1.458
 diff -u -r1.458 chapter.sgml
 --- chapter.sgml	2001/07/23 22:51:24	1.458
 +++ chapter.sgml	2001/07/26 18:24:02
 @@ -446,6 +446,8 @@
  	  url="http://www.FreeBSD.org/send-pr.html">WEB-based
  	  equivalent</ulink>.  Try to fill-in each field of the bug report.
  	Unless they exceed 65KB, include any patches directly in the report.
 +	If the patch is suitable to be applied to the source tree put
 +	<literal>[PATCH]</literal> in the synopsis of the report.
  	When including patches, <emphasis>do not</emphasis> use cut-and-paste
  	because cut-and-paste turns tabs into spaces and makes them unusable.
  	Consider compressing patches and using &man.uuencode.1; if they exceed
 @@ -522,8 +524,9 @@
  	<emphasis>Do not</emphasis> just send the diffs to the &a.hackers; or
  	they will get lost! We greatly appreciate your submission (this is a
  	volunteer project!); because we are busy, we may not be able to
 -	address it immediately, but it will remain in the pr database until we
 -	do.</para>
 +	address it immediately, but it will remain in the PR database until we
 +	do.  Indicate your submission by including <literal>[PATCH]</literal>
 +	in the synopsis of the report.</para>
  
        <indexterm>
          <primary><command>uuencode</command></primary>
State-Changed-From-To: open->closed 
State-Changed-By: dd 
State-Changed-When: Sat Aug 11 13:16:05 PDT 2001 
State-Changed-Why:  
The handbook now mentions [PATCH] 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=23094 
>Unformatted:
