From gdonl@tsc.tdk.com  Tue Sep 12 17:49:37 2000
Return-Path: <gdonl@tsc.tdk.com>
Received: from gatekeeper.tsc.tdk.com (gatekeeper.tsc.tdk.com [207.113.159.21])
	by hub.freebsd.org (Postfix) with ESMTP id 1E3E637B422
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 12 Sep 2000 17:49:37 -0700 (PDT)
Received: from imap.gv.tsc.tdk.com (imap.gv.tsc.tdk.com [192.168.241.198])
	by gatekeeper.tsc.tdk.com (8.8.8/8.8.8) with ESMTP id RAA09241
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 12 Sep 2000 17:49:36 -0700 (PDT)
	(envelope-from gdonl@tsc.tdk.com)
Received: from gvpc85.gv.tsc.tdk.com (gvpc85.gv.tsc.tdk.com [192.168.240.85])
	by imap.gv.tsc.tdk.com (8.9.3/8.9.3) with ESMTP id RAA73327
	for <FreeBSD-gnats-submit@freebsd.org>; Tue, 12 Sep 2000 17:49:35 -0700 (PDT)
	(envelope-from Don.Lewis@tsc.tdk.com)
Received: (from gdonl@localhost)
	by gvpc85.gv.tsc.tdk.com (8.11.0/8.11.0) id e8CHpt905506;
	Tue, 12 Sep 2000 10:51:55 -0700 (PDT)
	(envelope-from Don.Lewis@tsc.tdk.com)
Message-Id: <200009121751.e8CHpt905506@gvpc85.gv.tsc.tdk.com>
Date: Tue, 12 Sep 2000 10:51:55 -0700 (PDT)
From: Don Lewis <Don.Lewis@tsc.tdk.com>
Sender: gdonl@tsc.tdk.com
Reply-To: gdonl@tsc.tdk.com
To: FreeBSD-gnats-submit@freebsd.org
Subject: MAKEDEV on fixit floppy should not reset $PATH
X-Send-Pr-Version: 3.2

>Number:         21241
>Category:       misc
>Synopsis:       MAKEDEV on fixit floppy should not reset $PATH
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Sep 12 17:50:00 PDT 2000
>Closed-Date:    Tue Nov 7 03:28:54 PST 2000
>Last-Modified:  Tue Nov 07 03:35:55 PST 2000
>Originator:     Don Lewis
>Release:        FreeBSD 4.1-STABLE i386
>Organization:
TDK Semiconductor Corp.
>Environment:

	

>Description:

	The copy of MAKEDEV on the fixit floppy should not reset its
	$PATH.  If it does, it won't be able to find the needed executables
	on the fixit floppy, such as expr.  The release/Makefile attempts
	to edit MAKEDEV to prevent it from setting $PATH, but some formatting
	changes to MAKEDEV now prevent the editing from being successful.

>How-To-Repeat:

	

>Fix:


Index: release/Makefile
===================================================================
RCS file: /home/ncvs/src/release/Makefile,v
retrieving revision 1.536.2.22
diff -u -r1.536.2.22 Makefile
--- release/Makefile	2000/08/22 09:43:55	1.536.2.22
+++ release/Makefile	2000/09/12 17:47:16
@@ -582,7 +582,7 @@
 	@cd ${.CURDIR} && $(MAKE) installCRUNCH CRUNCH=fixit \
 		DIR=${RD}/fixitfd/stand ZIP=false
 	@( cd ${RD}/fixitfd/dev && \
-		sed -e '/^PATH/s/^/#/' ${RD}/trees/bin/dev/MAKEDEV > MAKEDEV && \
+		sed -e '/^[ 	]*PATH/s/^/#/' ${RD}/trees/bin/dev/MAKEDEV > MAKEDEV && \
 		chmod 755 MAKEDEV && \
 		sh MAKEDEV fixit )
 	@cp ${RD}/trees/bin/etc/spwd.db ${RD}/trees/bin/etc/group \

>Release-Note:
>Audit-Trail:
State-Changed-From-To: open->closed 
State-Changed-By: truckman 
State-Changed-When: Tue Nov 7 03:28:54 PST 2000 
State-Changed-Why:  
The correct fix is to set MAKEDEVPATH in sysinstall to include the 
necessary directories in /mnt2, which is where the fixit floppy is 
mounted.  It is also necessary to search the path that MAKEDEV uses 
to find mknod instead of hardwiring it to /sbin/mknod. 

Fixed in release/sysinstall/install.c 1.286 and 1.268.2.16, etc/MAKEDEV 
1.280 and 1.243.2.15 (RELENG_4). 


http://www.freebsd.org/cgi/query-pr.cgi?pr=21241 
>Unformatted:
