From fanf@dotat.at  Tue Sep  5 18:25:33 2000
Return-Path: <fanf@dotat.at>
Received: from hand.dotat.at (sfo-gw.covalent.net [207.44.198.62])
	by hub.freebsd.org (Postfix) with ESMTP id C64A237B423
	for <FreeBSD-gnats-submit@freebsd.org>; Tue,  5 Sep 2000 18:25:32 -0700 (PDT)
Received: from fanf by hand.dotat.at with local (Exim 3.15 #3)
	id 13WTxw-000G1H-00
	for FreeBSD-gnats-submit@freebsd.org; Wed, 06 Sep 2000 01:25:28 +0000
Message-Id: <E13WTxw-000G1H-00@hand.dotat.at>
Date: Wed, 06 Sep 2000 01:25:28 +0000
From: Tony Finch <dot@dotat.at>
Sender: fanf@dotat.at
Reply-To: Tony Finch <dot@dotat.at>
To: FreeBSD-gnats-submit@freebsd.org
Subject: default setting of ${SUP} in Makefile.inc1 doesn't work
X-Send-Pr-Version: 3.2

>Number:         21070
>Category:       misc
>Synopsis:       default setting of ${SUP} in Makefile.inc1 doesn't work
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    marcel
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Sep 05 18:30:01 PDT 2000
>Closed-Date:    Fri Feb 13 22:05:16 PST 2004
>Last-Modified:  Fri Feb 13 22:05:16 PST 2004
>Originator:     Tony Finch <dot@dotat.at>
>Release:        FreeBSD 4.1-STABLE-20000831 i386
>Organization:
dotat
>Environment:

FreeBSD hand.dotat.at 4.1-STABLE-20000831 FreeBSD 4.1-STABLE-20000831 #1: Fri Sep  1 04:51:19 UTC 2000     root@hand.dotat.at:/FreeBSD/obj/FreeBSD/releng4/sys/DELL-Latitude-CPx  i386

>Description:

cvsup is usually installed in /usr/local/bin
/usr/src/Makefile sets the PATH to /sbin:/bin:/usr/sbin:/usr/bin
before running Makefile.inc1
/usr/src/Makefile.inc1 sets SUP to just "cvsup" if it isn't already set

The result of all this is not as helpful as it tries to be.

>How-To-Repeat:

Run `make update` with a make.conf containing a definition of SUPFILE but
no definition of SUP. Make will then bomb when it fails to find cvsup.

>Fix:

Index: Makefile.inc1
===================================================================
RCS file: /home/ncvs/src/Makefile.inc1,v
retrieving revision 1.141.2.8
diff -u -r1.141.2.8 Makefile.inc1
--- Makefile.inc1	2000/08/23 19:27:30	1.141.2.8
+++ Makefile.inc1	2000/09/06 01:14:25
@@ -111,7 +111,7 @@
 CLEANDIR=	cleandir
 .endif
 
-SUP?=		cvsup
+SUP?=		/usr/local/bin/cvsup
 SUPFLAGS?=	-g -L 2 -P -
 .if defined(SUPHOST)
 SUPFLAGS+=	-h ${SUPHOST}

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->marcel 
Responsible-Changed-By: sheldonh 
Responsible-Changed-When: Wed Sep 6 05:58:18 PDT 2000 
Responsible-Changed-Why:  
Marcel restricted the PATH in rev 1.232.  The ideal solution here 
is for both bsd.port.mk and Makefile to include some other .mk file 
that provides a default definition of LOCALBASE.  Then we can 
use ${LOCALBASE}/bin/cvsup as the default value for SUP. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=21070 
State-Changed-From-To: open->closed 
State-Changed-By: marcel 
State-Changed-When: Fri Feb 13 22:03:07 PST 2004 
State-Changed-Why:  
This was fixed in rev. 1.223 of Makefile.inc and MFC'd to rev. 1.141.2.35. 
The PR mentioned in the commit log is 31932. A duplicate therefore. 


http://www.freebsd.org/cgi/query-pr.cgi?pr=21070 
>Unformatted:
