From gpalmer@orion.webspan.net  Mon Nov 25 19:22:18 1996
Received: from mail.webspan.net (mail.webspan.net [206.154.70.7])
          by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id TAA02151
          for <freebsd-gnats-submit@freebsd.org>; Mon, 25 Nov 1996 19:22:13 -0800 (PST)
Received: from orion.webspan.net (orion.webspan.net [206.154.70.5]) 
          by mail.webspan.net (8.7.5/8.7.3) with ESMTP id WAA00469
          for <freebsd-gnats-submit@freebsd.org>; Mon, 25 Nov 1996 22:21:36 -0500 (EST)
Received: from orion.webspan.net (localhost [127.0.0.1]) 
          by orion.webspan.net (8.7.5/8.7.3) with ESMTP id WAA19301
          for <freebsd-gnats-submit@freebsd.org>; Mon, 25 Nov 1996 22:21:36 -0500 (EST)
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.18]) 
          by mail.webspan.net (8.7.5/8.7.3) with ESMTP id WAA28253
          for <gpalmer@webspan.net>; Mon, 25 Nov 1996 22:05:48 -0500 (EST)
Received: from nike.efn.org (resnet.uoregon.edu [128.223.170.28])
          by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id TAA01461
          for <FreeBSD-gnats@freefall.FreeBSD.org>; Mon, 25 Nov 1996 19:04:00 -0800 (PST)
Received: (from root@localhost) by nike.efn.org (8.8.3/8.8.3) id TAA06775; Mon, 25 Nov 1996 19:03:43 -0800 (PST)
Message-Id: <199611260303.TAA06775@nike.efn.org>
Date: Mon, 25 Nov 1996 19:03:43 -0800 (PST)
From: John-Mark Gurney <jmg@nike.efn.org>
Reply-To: gurney_j@efn.org
To: FreeBSD-gnats@freefall.FreeBSD.org
Subject: bsd.lib.mk bugs
X-Send-Pr-Version: 3.2

>Number:         2105
>Category:       misc
>Synopsis:       bsd.lib.mk has problems with STRIP and INTERNALSTATICLIB
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    jmg
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Nov 25 19:30:11 PST 1996
>Closed-Date:    Thu May 6 02:20:14 PDT 1999
>Last-Modified:  Thu May  6 02:28:21 PDT 1999
>Originator:     John-Mark Gurney
>Release:        FreeBSD 2.2-960801-SNAP i386
>Organization:
Cu Networking
>Environment:

a 2.2-960803-SNAP but with current cvs tree... all patches relative to current
	

>Description:

a)	if you define INTERNALSTATICLIB, bsd.lib.mk still tries to install it, even though INTERNALLIB doesn't...
b)	INSTALL doesn't strip dynamic libs upon installing
	

>How-To-Repeat:

a)	define INTERNALSTATICLIB, and then do a make install, it installs

b)	install a dynamic library, file dynamic_lib, and see that it isn't stripped
	

>Fix:
	
apply this patch, a is the first hunk, b is the second:

Index: bsd.lib.mk
===================================================================
RCS file: /usr/cvs/src/share/mk/bsd.lib.mk,v
retrieving revision 1.37
diff -c -r1.37 bsd.lib.mk
*** bsd.lib.mk	1996/06/29 03:12:48	1.37
--- bsd.lib.mk	1996/11/26 02:57:47
***************
*** 199,205 ****
  .endif
  
  realinstall: beforeinstall
! .if !defined(INTERNALLIB)
  	${INSTALL} ${COPY} -o ${LIBOWN} -g ${LIBGRP} -m ${LIBMODE} \
  	    ${INSTALLFLAGS} lib${LIB}.a ${DESTDIR}${LIBDIR}
  .if !defined(NOPROFILE)
--- 199,205 ----
  .endif
  
  realinstall: beforeinstall
! .if !defined(INTERNALLIB) && !defined(INTERNALSTATICLIB)
  	${INSTALL} ${COPY} -o ${LIBOWN} -g ${LIBGRP} -m ${LIBMODE} \
  	    ${INSTALLFLAGS} lib${LIB}.a ${DESTDIR}${LIBDIR}
  .if !defined(NOPROFILE)
***************
*** 209,215 ****
  .endif
  .if !defined(NOPIC)
  .if defined(SHLIB_MAJOR) && defined(SHLIB_MINOR)
! 	${INSTALL} ${COPY} -o ${LIBOWN} -g ${LIBGRP} -m ${LIBMODE} \
  	    ${INSTALLFLAGS} ${SHLINSTALLFLAGS} \
  	    lib${LIB}.so.${SHLIB_MAJOR}.${SHLIB_MINOR} \
  	    ${DESTDIR}${SHLIBDIR}
--- 209,215 ----
  .endif
  .if !defined(NOPIC)
  .if defined(SHLIB_MAJOR) && defined(SHLIB_MINOR)
! 	${INSTALL} ${COPY} ${STRIP} -o ${LIBOWN} -g ${LIBGRP} -m ${LIBMODE} \
  	    ${INSTALLFLAGS} ${SHLINSTALLFLAGS} \
  	    lib${LIB}.so.${SHLIB_MAJOR}.${SHLIB_MINOR} \
  	    ${DESTDIR}${SHLIBDIR}
	

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->jmg 
Responsible-Changed-By: jmg 
Responsible-Changed-When: Sun Apr 12 15:25:25 PDT 1998 
Responsible-Changed-Why:  
now that I'm a committer, I'll take care of this... 
State-Changed-From-To: open->closed 
State-Changed-By: jmg 
State-Changed-When: Thu May 6 02:20:14 PDT 1999 
State-Changed-Why:  
the first item is no longer a problem in -current, 
the second item probably isn't going to change as bde says it may break 
things and make debugging unnecessarly difficul... 
>Unformatted:
John-Mark Gurney
