From robert@fledge.watson.org  Wed Aug 30 10:38:24 2000
Return-Path: <robert@fledge.watson.org>
Received: from fledge.watson.org (fledge.watson.org [204.156.12.50])
	by hub.freebsd.org (Postfix) with ESMTP id 9C5CF37B423
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 30 Aug 2000 10:38:23 -0700 (PDT)
Received: (from robert@localhost)
	by fledge.watson.org (8.9.3/8.9.3) id NAA13834;
	Wed, 30 Aug 2000 13:37:36 -0400 (EDT)
	(envelope-from robert)
Message-Id: <200008301737.NAA13834@fledge.watson.org>
Date: Wed, 30 Aug 2000 13:37:36 -0400 (EDT)
From: rwatson@freebsd.org
Sender: robert@fledge.watson.org
Reply-To: rwatson@freebsd.org
To: FreeBSD-gnats-submit@freebsd.org
Subject: mergemaster doesn't udnerstand recent sendmail config changes
X-Send-Pr-Version: 3.2

>Number:         20948
>Category:       misc
>Synopsis:       /etc/aliases and other changes not known to mergemaster
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    dougb
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Aug 30 10:40:01 PDT 2000
>Closed-Date:    Fri Oct 27 03:23:11 PDT 2000
>Last-Modified:  Fri Oct 27 03:24:49 PDT 2000
>Originator:     Robert Watson
>Release:        FreeBSD 5.0-STABLE i386
>Organization:
>Environment:

5.0-CURRENT as of recent sendmail update, upgrading from a prior
5.0-CURRENT.

>Description:

Several files have moved from /etc to /etc/mail, including aliases.
Mergemaster often assists with magic involving file upgrades, but
simply installs a new, empty default aliases in /etc/mail/aliases,
and leaves the current as is.  A nice feature would be if mergemaster
would observe the presence of an /etc/aliases, no /etc/mail/aliases,
offer to move the file, then create the symlink from /etc/aliases to
/etc/mail/aliases.  Creating and maintaining that symlink should
be similar to the maintaining of /root/.cshrc and /.cshrc, where
there is already precedent for mergemaster groking some of our specific
layout.  I believe /etc/sendmail.cw is now expected to be in the
new location.

>How-To-Repeat:

Upgrade.  mergemaster.

>Fix:

Not available.


>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->billf 
Responsible-Changed-By: sheldonh 
Responsible-Changed-When: Thu Aug 31 05:04:18 PDT 2000 
Responsible-Changed-Why:  
Over to maintainer. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=20948 

From: Doug Barton <DougB@gorean.org>
To: rwatson@freebsd.org
Cc: FreeBSD-gnats-submit@freebsd.org,
	Gregory Neil Shapiro <gshapiro@freebsd.org>
Subject: Re: misc/20948: mergemaster doesn't udnerstand recent sendmail config 
 changes
Date: Thu, 21 Sep 2000 16:50:23 -0700

 rwatson@freebsd.org wrote:
 
 > >Synopsis:       /etc/aliases and other changes not known to mergemaster
 
 	This synopsis is inaccurate. I was aware of the change, and approved a
 patch by (sendmail-meister) Gregory Shapiro to handle the move. 
 
 > A nice feature would be if mergemaster
 > would observe the presence of an /etc/aliases, no /etc/mail/aliases,
 > offer to move the file, then create the symlink from /etc/aliases to
 > /etc/mail/aliases. 
 
 	This is fraught with danger on many fronts. A better solution might be
 to put:
 
 define(`ALIAS_FILE', `/etc/aliases,/etc/mail/aliases')dnl
 
 in freebsd.mc, assuming that sendmail won't barf if either is missing.
 It might also be possible to do what Robert is suggesting with mtree.
 However, anything involving the "right" way to handle MTA issues is
 likely to provoke huge, non-productive arguments that reach no
 conclusion, and I don't want to put myself or my helpless little program
 in the middle of them. 
 
 > Creating and maintaining that symlink should
 > be similar to the maintaining of /root/.cshrc and /.cshrc, where
 > there is already precedent for mergemaster groking some of our specific
 > layout.  
 
 	This is not a valid precedent, given that those hard links have been
 around for years, don't change, are not likely to change, and are as
 uncontroversial as anything gets around here. 
 
 	While I do appreciate this suggestion, I will not be including it in
 mergemaster. I would appreciate it if someone with commit priv's would
 close this PR. 
 
 Thanks,
 
 Doug
 

From: Gregory Neil Shapiro <gshapiro@freebsd.org>
To: Doug Barton <DougB@gorean.org>
Cc: rwatson@freebsd.org, FreeBSD-gnats-submit@freebsd.org
Subject: Re: misc/20948: mergemaster doesn't udnerstand recent sendmail config 
 changes
Date: Thu, 21 Sep 2000 18:34:33 -0700 (PDT)

 DougB> This is fraught with danger on many fronts. A better solution might be
 DougB> to put:
 
 DougB> define(`ALIAS_FILE', `/etc/aliases,/etc/mail/aliases')dnl
 
 DougB> in freebsd.mc, assuming that sendmail won't barf if either is missing.
 
 Unfortunately, sendmail will not like that.
 

From: Robert Watson <rwatson@freebsd.org>
To: Doug Barton <DougB@gorean.org>
Cc: FreeBSD-gnats-submit@freebsd.org,
	Gregory Neil Shapiro <gshapiro@freebsd.org>
Subject: Re: misc/20948: mergemaster doesn't udnerstand recent sendmail config  changes
Date: Fri, 22 Sep 2000 13:38:19 -0400 (EDT)

 On Thu, 21 Sep 2000, Doug Barton wrote:
 
 > rwatson@freebsd.org wrote:
 > 
 > > >Synopsis:       /etc/aliases and other changes not known to mergemaster
 > 
 > 	This synopsis is inaccurate. I was aware of the change, and approved a
 > patch by (sendmail-meister) Gregory Shapiro to handle the move. 
 
 When I emailed those listed as MAINTAINER in the Makefile, I got a
 black-hole, and as mergemaster appeared not to know what I do, I felt this
 was a safe assumption. :-)
 
 > in freebsd.mc, assuming that sendmail won't barf if either is missing.
 > It might also be possible to do what Robert is suggesting with mtree.
 > However, anything involving the "right" way to handle MTA issues is
 > likely to provoke huge, non-productive arguments that reach no
 > conclusion, and I don't want to put myself or my helpless little program
 > in the middle of them. 
 
 The aliases file move appears to be permanent and system-wide.  I.e., it
 is moved in the CVS repo, and /etc/aliases is no more.  It seems to me
 that a reasonable check is (if file isn't in /etc/mail/aliases, and is in
 /etc/aliases, offer to (move it, check out the new file, or do nothing).
 If both files exist and they're different, fine.  mergemaster already
 installs other sendmail-specific files even if another MTA is in use.
 
 > > Creating and maintaining that symlink should
 > > be similar to the maintaining of /root/.cshrc and /.cshrc, where
 > > there is already precedent for mergemaster groking some of our specific
 > > layout.  
 > 
 > 	This is not a valid precedent, given that those hard links have been
 > around for years, don't change, are not likely to change, and are as
 > uncontroversial as anything gets around here. 
 > 
 > 	While I do appreciate this suggestion, I will not be including it in
 > mergemaster. I would appreciate it if someone with commit priv's would
 > close this PR. 
 
 My belief is that while this was initially controversial, the world seems
 to have accepted it fine.  In the mean time, users are being bitten
 because the aliases file has changed out from under them, and the normal
 merge tool, mergemaster, makes no comment.
 
   Robert N M Watson 
 
 robert@fledge.watson.org              http://www.watson.org/~robert/
 PGP key fingerprint: AF B5 5F FF A6 4A 79 37  ED 5F 55 E9 58 04 6A B1
 TIS Labs at Network Associates, Safeport Network Services
 
 
 

From: Gregory Neil Shapiro <gshapiro@gshapiro.net>
To: Robert Watson <rwatson@freebsd.org>
Cc: Doug Barton <DougB@gorean.org>, FreeBSD-gnats-submit@freebsd.org,
	Gregory Neil Shapiro <gshapiro@freebsd.org>
Subject: Re: misc/20948: mergemaster doesn't udnerstand recent sendmail config  changes
Date: Fri, 22 Sep 2000 10:54:46 -0700 (PDT)

 rwatson> My belief is that while this was initially controversial, the
 rwatson> world seems to have accepted it fine.  In the mean time, users are
 rwatson> being bitten because the aliases file has changed out from under
 rwatson> them, and the normal merge tool, mergemaster, makes no comment.
 
 Would a simple comment be sufficient?  If so, Doug, what do you think of:
 
 Index: mergemaster.sh
 ===================================================================
 RCS file: /home/ncvs/src/usr.sbin/mergemaster/mergemaster.sh,v
 retrieving revision 1.6.2.2
 diff -u -u -r1.6.2.2 mergemaster.sh
 --- mergemaster.sh	2000/08/27 17:31:45	1.6.2.2
 +++ mergemaster.sh	2000/09/22 17:54:08
 @@ -353,6 +353,16 @@
    esac
  fi
  
 +# Warn users who have an /etc/aliases file
 +#
 +if [ -f /etc/aliases ]; then
 +  echo " *** There is an /etc/aliases file on this system. Starting with"
 +  echo "     FreeBSD version 4.1.1 that file has moved from /etc/aliases"
 +  echo "     to /etc/mail/aliases. If you are upgrading an older system"
 +  echo "     make sure that you move that file by hand before upgrading"
 +  echo "     the /etc/mail/sendmail.cf file."
 +fi
 +
  echo ''
  echo "*** Beginning comparison"
  echo ''
 

From: Doug Barton <DougB@gorean.org>
To: Robert Watson <rwatson@freebsd.org>
Cc: FreeBSD-gnats-submit@freebsd.org,
	Gregory Neil Shapiro <gshapiro@freebsd.org>
Subject: Re: misc/20948: mergemaster doesn't udnerstand recent sendmail config
  changes
Date: Fri, 22 Sep 2000 15:22:47 -0700 (PDT)

 On Fri, 22 Sep 2000, Robert Watson wrote:
 
 > 
 > On Thu, 21 Sep 2000, Doug Barton wrote:
 > 
 > > rwatson@freebsd.org wrote:
 > > 
 > > > >Synopsis:       /etc/aliases and other changes not known to mergemaster
 > > 
 > > 	This synopsis is inaccurate. I was aware of the change, and approved a
 > > patch by (sendmail-meister) Gregory Shapiro to handle the move. 
 > 
 > When I emailed those listed as MAINTAINER in the Makefile, I got a
 > black-hole, and as mergemaster appeared not to know what I do, I felt this
 > was a safe assumption. :-)
 
 	Unfortunately, I did not respond soon enough to your message to
 let you know that I was still thinking about how I wanted to handle
 it. That was an oversight on my part. 
 
 > My belief is that while this was initially controversial, the world seems
 > to have accepted it fine.
 
 	That's because we have not had a significant percentage of our
 userbase upgrade to a system with the new sendmail yet. The recent
 hulabaloo regarding the /usr/sbin/sendmail@ -> /usr/sbin/mailwrapper link
 was MORE than enough to show me that those anti-sendmail folks are going
 to violently oppose any assumptions about how mail related stuff
 "should" look. The fact that even on -current there was an animated
 discussion about what is the "right" thing to do with this issue further
 cemented my belief. 
 
 >  In the mean time, users are being bitten
 > because the aliases file has changed out from under them, and the normal
 > merge tool, mergemaster, makes no comment.
 
 	Show me some. I have been watching the lists carefully for posts
 related to this issue and I haven't seen any. The fact is, this is a one
 time change, mm will already call their attention to the fact that it's
 changed locations when it tells the user that it's installing a new
 aliases file in /etc/mail because there isn't one already, AND it will
 prompt the user at the end to run 'newaliases' because they just installed
 a new aliases file. If all of those signs and banners aren't enough,
 one more warning message won't help. 
 
 	Unlike the /etc/sysconfig change, this problem is likely to fail
 in a loud, spectacular manner which will immediately draw the admin's
 attention to it should they miss any of the existing warning signs already
 before rebooting. 
 
 
 
State-Changed-From-To: open->closed 
State-Changed-By: dougb 
State-Changed-When: Fri Oct 27 03:23:11 PDT 2000 
State-Changed-Why:  
Popular consensus is that this change is not mm's problem. 


Responsible-Changed-From-To: billf->dougb 
Responsible-Changed-By: dougb 
Responsible-Changed-When: Fri Oct 27 03:23:11 PDT 2000 
Responsible-Changed-Why:  
I'm a committer now 

http://www.freebsd.org/cgi/query-pr.cgi?pr=20948 
>Unformatted:
