From nobody@FreeBSD.ORG  Sat Jul  1 16:29:55 2000
Return-Path: <nobody@FreeBSD.ORG>
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 1C98B37B788; Sat,  1 Jul 2000 16:29:55 -0700 (PDT)
Message-Id: <20000701232955.1C98B37B788@hub.freebsd.org>
Date: Sat,  1 Jul 2000 16:29:55 -0700 (PDT)
From: fred@condo.chico.ca.us
Sender: nobody@FreeBSD.ORG
To: freebsd-gnats-submit@FreeBSD.org
Subject: Disk status in daily report is hard to read because space is reported in K.
X-Send-Pr-Version: www-1.0

>Number:         19631
>Category:       misc
>Synopsis:       Disk status in daily report is hard to read because space is reported in K.
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    brian
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sat Jul 01 16:30:00 PDT 2000
>Closed-Date:    Sun Sep 24 06:40:01 PDT 2000
>Last-Modified:  Sun Sep 24 06:40:16 PDT 2000
>Originator:     Fred Condo
>Release:        4.0-STABLE
>Organization:
>Environment:
FreeBSD absinthe.condo.chico.ca.us 4.0-STABLE FreeBSD 4.0-STABLE #6 Sat Jul  1 10:40:13 PDT 2000     fred@absinthe.condo.chico.ca.us:/usr/src/sys/compile/ABSINTHE  i386

>Description:
/etc/periodic/daily/400.disk-status runs daily and includes the output
of df -k to show disk usage. Since modern disks are big, it is hard to
read the disk sizes. It would be more readable to use the new df -h 
option, which reports disk sizes in M and G.
>How-To-Repeat:
Read the daily reports sent to root.
>Fix:
Change the df command to:

df -h -t nonfs

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->sheldonh 
Responsible-Changed-By: sheldonh 
Responsible-Changed-When: Mon Jul 3 03:17:09 PDT 2000 
Responsible-Changed-Why:  
I have time to look at this while I'm waiting for feedback 
on my conformance manual page improvements proposal. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=19631 

From: Sheldon Hearn <sheldonh@uunet.co.za>
To: fred@condo.chico.ca.us
Cc: freebsd-gnats-submit@FreeBSD.ORG
Subject: Re: misc/19631: Disk status in daily report is hard to read because space is reported in K. 
Date: Mon, 03 Jul 2000 12:17:01 +0200

 On Sat, 01 Jul 2000 16:29:55 MST, fred@condo.chico.ca.us wrote:
 
 > >Description:
 > /etc/periodic/daily/400.disk-status runs daily and includes the output
 > of df -k to show disk usage. Since modern disks are big, it is hard to
 > read the disk sizes. It would be more readable to use the new df -h 
 > option, which reports disk sizes in M and G.
 
 The disadvantage of your proposed change is that folks who feed this
 mail into scripts will have problems.  However, I'm certainly keen on
 conditionalizing your change on a periodic.conf variable.
 
 Ciao,
 Sheldon.
 
Responsible-Changed-From-To: sheldonh->brian 
Responsible-Changed-By: sheldonh 
Responsible-Changed-When: Mon Jul 3 03:30:51 PDT 2000 
Responsible-Changed-Why:  
Over to the new periodic maintainer. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=19631 

From: Sheldon Hearn <sheldonh@uunet.co.za>
To: Brian Somers <brian@Awfulhak.org>
Cc: freebsd-gnats-submit@FreeBSD.org
Subject: Re: misc/19631: Disk status in daily report is hard to read
Date: Mon, 03 Jul 2000 12:30:44 +0200

 Hi Brian,
 
 Please check the following PR and then consider the patch below.
 
 	http://www.freebsd.org/cgi/query-pr.cgi?pr=19631
 
 Thanks,
 Sheldon.
 
 Index: etc/defaults/periodic.conf
 ===================================================================
 RCS file: /home/ncvs/src/etc/defaults/periodic.conf,v
 retrieving revision 1.5
 diff -u -d -r1.5 periodic.conf
 --- etc/defaults/periodic.conf	2000/06/30 09:41:15	1.5
 +++ etc/defaults/periodic.conf	2000/07/03 10:20:39
 @@ -81,6 +81,7 @@
  
  # 400.status-disks
  daily_status_disks_enable="YES"				# Check disk status
 +daily_status_df_flags="-h -t nonfs"			# df(1) flags for check
  
  # 410.status-uucp
  daily_status_uucp_enable="YES"				# Check uucp status
 Index: etc/periodic/daily/400.status-disks
 ===================================================================
 RCS file: /home/ncvs/src/etc/periodic/daily/400.status-disks,v
 retrieving revision 1.3
 diff -u -d -r1.3 400.status-disks
 --- etc/periodic/daily/400.status-disks	2000/06/23 01:18:23	1.3
 +++ etc/periodic/daily/400.status-disks	2000/07/03 10:19:32
 @@ -16,7 +16,7 @@
  	echo ""
  	echo "Disk status:"
  
 -	df -k -t nonfs
 +	df $daily_status_df_flags
  
  	# display which filesystems need backing up
  
 Index: share/man/man5/periodic.conf.5
 ===================================================================
 RCS file: /home/ncvs/src/share/man/man5/periodic.conf.5,v
 retrieving revision 1.7
 diff -u -d -r1.7 periodic.conf.5
 --- share/man/man5/periodic.conf.5	2000/06/30 11:24:31	1.7
 +++ share/man/man5/periodic.conf.5	2000/07/03 10:26:45
 @@ -216,13 +216,24 @@
  .Dq YES
  if you want to run
  .Pa /etc/uuclean.daily .
 -.it Ar daily_status_disks_enable
 +.It Ar daily_status_disks_enable
  (bool) Set to
  .Dq YES
  if you want to run
 -.Ic df -k -t nonfs
 +.Xr df 1
 +.Po
 +with the arguments supplied in
 +.Ar daily_status_df_flags
 +.Pc
  and
  .Ic dump W .
 +.It Ar daily_status_df_flags
 +(str) Set to the arguments for the
 +.Xr df 1
 +utility when
 +.Ar daily_status_disks_enable
 +is set to
 +.Dq YES .
  .It Ar daily_status_uucp_enable
  (bool) Set to
  .Dq YES
 
State-Changed-From-To: open->analyzed 
State-Changed-By: sheldonh 
State-Changed-When: Wed Jul 5 03:47:57 PDT 2000 
State-Changed-Why:  
I committed to HEAD a solution as proposed and have left this for  
Brian as a reminder to MFC when he sees fit. 


http://www.freebsd.org/cgi/query-pr.cgi?pr=19631 
State-Changed-From-To: analyzed->closed 
State-Changed-By: brian 
State-Changed-When: Sun Sep 24 06:40:01 PDT 2000 
State-Changed-Why:  
The change was MFC'd recently 

http://www.freebsd.org/cgi/query-pr.cgi?pr=19631 
>Unformatted:
