From benno@rat-thing.netizen.com.au  Thu Jun 29 06:56:58 2000
Return-Path: <benno@rat-thing.netizen.com.au>
Received: from rat-thing.netizen.com.au (minerva-as54.labyrinth.net.au [202.182.82.54])
	by hub.freebsd.org (Postfix) with ESMTP id ABE4037BA1D
	for <FreeBSD-gnats-submit@freebsd.org>; Thu, 29 Jun 2000 06:56:53 -0700 (PDT)
	(envelope-from benno@rat-thing.netizen.com.au)
Received: (from benno@localhost)
	by rat-thing.netizen.com.au (8.9.3/8.9.3) id XAA11767;
	Thu, 29 Jun 2000 23:56:58 +1000 (EST)
	(envelope-from benno)
Message-Id: <200006291356.XAA11767@rat-thing.netizen.com.au>
Date: Thu, 29 Jun 2000 23:56:58 +1000 (EST)
From: benno@netizen.com.au
Sender: benno@rat-thing.netizen.com.au
Reply-To: benno@netizen.com.au
To: FreeBSD-gnats-submit@freebsd.org
Subject: [patch] add magic to file(1) to recognise SID tunes
X-Send-Pr-Version: 3.2

>Number:         19576
>Category:       misc
>Synopsis:       [patch] add magic to file(1) to recognise SID tunes
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    obrien
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jun 29 07:00:01 PDT 2000
>Closed-Date:    Fri Nov 10 21:26:13 PST 2000
>Last-Modified:  Fri Nov 10 21:27:14 PST 2000
>Originator:     Benno Rice
>Release:        FreeBSD 5.0-CURRENT i386
>Organization:
Netizen Pty Ltd
>Environment:

FreeBSD rat-thing.netizen.com.au 5.0-CURRENT FreeBSD 5.0-CURRENT #16: Mon May 29 09:24:20 EST 2000     benno@rat-thing.netizen.com.au:/usr/src/sys/compile/RATTHING  i386

>Description:

file(1) does not currently recognise SID tunes.

>How-To-Repeat:

run file on a SID tune file (.sid file)

>Fix:

Apply the following patch to usr.bin/file/Magdir/audio:

--- audio	Thu Jun 29 23:53:49 2000
+++ audio.new	Thu Jun 29 23:53:46 2000
@@ -94,3 +94,6 @@
 
 0	string		GF1PATCH110\0ID#000002\0	GUS patch
 0	string		GF1PATCH100\0ID#000002\0	Old GUS	patch
+
+# Commodore 64 SID tunes
+0	string		PSID		Commodore 64 SID tune

>Release-Note:
>Audit-Trail:

From: alex@big.endian.de (Alexander Langer)
To: benno@netizen.com.au
Cc: FreeBSD-gnats-submit@FreeBSD.ORG
Subject: Re: misc/19576: [patch] add magic to file(1) to recognise SID tunes
Date: Thu, 29 Jun 2000 16:16:06 +0200

 Thus spake benno@netizen.com.au (benno@netizen.com.au):
 
 > +
 > +# Commodore 64 SID tunes
 > +0	string		PSID		Commodore 64 SID tune
 
 That is a little few:
 
 alex:~ $ cat psid.txt ; file psid.txt
 PSID AUDIO FORMAT
 =================
 
 The psid audio format is a nice thing.
 psid.txt: Commodore 64 SID tune
 
 Can't you extend this?
 
 Alex
 -- 
 cat: /home/alex/.sig: No such file or directory
 

From: Benno Rice <benno@netizen.com.au>
To: Alexander Langer <alex@big.endian.de>
Cc: FreeBSD-gnats-submit@FreeBSD.ORG
Subject: Re: misc/19576: [patch] add magic to file(1) to recognise SID tunes
Date: Fri, 30 Jun 2000 00:25:11 +1000

 On Thu, Jun 29, 2000 at 04:16:06PM +0200, Alexander Langer wrote:
 > Thus spake benno@netizen.com.au (benno@netizen.com.au):
 > 
 > > +
 > > +# Commodore 64 SID tunes
 > > +0	string		PSID		Commodore 64 SID tune
 > 
 > That is a little few:
 
 [snip]
  
 > Can't you extend this?
 
 How about:
 
 --- audio       Thu Jun 29 23:53:49 2000
 +++ audio.new   Fri Jun 30 00:22:07 2000
 @@ -94,3 +94,6 @@
  
  0      string          GF1PATCH110\0ID#000002\0        GUS patch
  0      string          GF1PATCH100\0ID#000002\0        Old GUS patch
 +
 +# Commodore 64 SID tunes
 +0      string          PSID\0          Commodore 64 SID tune
 
 I'd extend it further, but it seems to vary beyond that point.
 If this isn't sufficient, I can actually go hunting for some sort of spec. =)
 
 -- 
 Benno Rice                                      "No, no. We're *sweet* and
 XNFP Aries Dark Subculture-                      *innocent* evil bastards."
 friendly Internet Geek
 benno@netizen.com.au                                      "Defend your joy"
 

From: Alexander Langer <alex@big.endian.de>
To: Benno Rice <benno@netizen.com.au>
Cc: FreeBSD-gnats-submit@FreeBSD.ORG
Subject: Re: misc/19576: [patch] add magic to file(1) to recognise SID tunes
Date: Thu, 29 Jun 2000 16:36:20 +0200

 Thus spake Benno Rice (benno@netizen.com.au):
 
 > +# Commodore 64 SID tunes
 > +0      string          PSID\0          Commodore 64 SID tune
 > I'd extend it further, but it seems to vary beyond that point.
 > If this isn't sufficient, I can actually go hunting for some sort of spec. =)
 
 Seems better, but go hunting :)
 
 Alex
 
 -- 
 cat: /home/alex/.sig: No such file or directory
 

From: Sheldon Hearn <sheldonh@uunet.co.za>
To: Benno Rice <benno@netizen.com.au>
Cc: freebsd-gnats-submit@FreeBSD.org
Subject: Re: misc/19576: [patch] add magic to file(1) to recognise SID tunes 
Date: Thu, 29 Jun 2000 16:46:54 +0200

 On Thu, 29 Jun 2000 07:30:03 MST, Benno Rice wrote:
 
 >  > Can't you extend this?
 >  
 >  How about:
 >  
 >  --- audio       Thu Jun 29 23:53:49 2000
 >  +++ audio.new   Fri Jun 30 00:22:07 2000
 
 Nonono.  We've been down the local modifications road and it isn't
 pretty.  Please contact file(1)'s maintainer.  Having changes
 incorporated into the official distribution is a much better idea, even
 if it does take a little longer to filter into FreeBSD.
 
 Ciao,
 Sheldon.
 
Responsible-Changed-From-To: freebsd-bugs->obrien 
Responsible-Changed-By: sheldonh 
Responsible-Changed-When: Thu Aug 3 13:14:39 PDT 2000 
Responsible-Changed-Why:  
David promised to chat to the file(1) maintainer. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=19576 
State-Changed-From-To: open->closed 
State-Changed-By: obrien 
State-Changed-When: Fri Nov 10 21:26:13 PST 2000 
State-Changed-Why:  
We have switched to the Christos Zoulas maintained version of `file'. 
Desired changes should be submitted to Christos. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=19576 
>Unformatted:
