From nobody@FreeBSD.ORG  Sun Jun 18 10:03:25 2000
Return-Path: <nobody@FreeBSD.ORG>
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id B63AE37B8A6; Sun, 18 Jun 2000 10:03:25 -0700 (PDT)
Message-Id: <20000618170325.B63AE37B8A6@hub.freebsd.org>
Date: Sun, 18 Jun 2000 10:03:25 -0700 (PDT)
From: patl@phoenix.volant.org
Sender: nobody@FreeBSD.ORG
To: freebsd-gnats-submit@FreeBSD.org
Subject: /etc/defaults/make.conf lists wrong value for PERL_THREADED
X-Send-Pr-Version: www-1.0

>Number:         19367
>Category:       misc
>Synopsis:       /etc/defaults/make.conf lists wrong value for PERL_THREADED
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    markm
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Jun 18 10:10:00 PDT 2000
>Closed-Date:    Wed Aug 29 10:08:49 PDT 2001
>Last-Modified:  Wed Aug 29 10:09:08 PDT 2001
>Originator:     PM Lashley
>Release:        4.0-STABLE
>Organization:
Phoenix Volant
>Environment:
>Description:
In /etc/defaults/make.conf there is a commented-out entry for
PERL_THREADED, with a comment indicating that uncommenting it
will build perl with multi-thread support.  It quietly fails.
The value should be 'yes', not 'true'.
>How-To-Repeat:
copy the PERL_THREADED=true line to /etc/make.conf and 'make world';
then run 'perl -V'.  You will see that it lists usethreads=undef.
>Fix:
Change the value of the PERL_THREADED macro to: yes

>Release-Note:
>Audit-Trail:

From: Johan Karlsson <k@numeri.campus.luth.se>
To: freebsd-gnats-submit@FreeBSD.org
Cc: patl@phoenix.volant.org, markm@FreeBSD.org
Subject: Re: misc/19367: /etc/defaults/make.conf lists wrong value for 
 PERL_THREADED
Date: Thu, 03 Aug 2000 18:33:21 +0200

 Hi 
 
 I think a better solution is to change
 /usr/src/gnu/usr.bin/perl/perl/Makefile:.if ${PERL_THREADED} == "yes"
 /usr/src/gnu/usr.bin/perl/Makefile.inc:PERL_THREADED?= no
 /usr/src/gnu/usr.bin/perl/Makefile.inc:.if ${PERL_THREADED} == "yes"
 
 to use 'true' instead since our make.conf uses true for every other value.
 
 
 in /usr/src/gnu/usr.bin/perl/perl/
 --- Makefile.~1~	Thu Aug  3 18:27:23 2000
 +++ Makefile	Thu Aug  3 18:28:03 2000
 @@ -24,7 +24,7 @@
  DYNAMIC_EXT=	B/B DB_File/DB_File Data/Dumper/Dumper Fcntl/Fcntl IO/IO \
  		IPC/SysV/SysV NDBM_File/NDBM_File Opcode/Opcode POSIX/POSIX \
  		SDBM_File/SDBM_File Socket/Socket attrs/attrs re/re
 -.if ${PERL_THREADED} == "yes"
 +.if ${PERL_THREADED} != "no"
  DYNAMIC_EXT+=	Thread/Thread
  .endif
  
 
 in /usr/src/gnu/usr.bin/perl/
 --- Makefile.inc.~1~	Thu Aug  3 18:27:27 2000
 +++ Makefile.inc	Thu Aug  3 18:28:26 2000
 @@ -58,7 +58,7 @@
  FARMDIRS=	lib ext Porting hints
  
  PERL_THREADED?= no
 -.if ${PERL_THREADED} == "yes"
 +.if ${PERL_THREADED} != "no"
  CFLAGS+=        -pthread
  THREAD=		threads-
  .endif
 
 
 Mark (markm), can you please have a look at this since you made the changes.
 
 Thanks
 Johan K
 
 
Responsible-Changed-From-To: freebsd-bugs->markm 
Responsible-Changed-By: sheldonh 
Responsible-Changed-When: Thu Aug 3 09:46:53 PDT 2000 
Responsible-Changed-Why:  
Johan's feedback will be interesting to the perl5 maintainer. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=19367 

From: Pat Lashley <patl@phoenix.volant.org>
To: freebsd-gnats-submit@FreeBSD.org, patl@phoenix.volant.org
Cc:  
Subject: Re: misc/19367: /etc/defaults/make.conf lists wrong value for 
 PERL_THREADED
Date: Sat, 17 Mar 2001 23:36:20 -0800

 As of 4.3-BETA (2001-03-17), it appears that the Makefiles themselves
 are inconsistant.
 /usr/src/gnu/usr.bin/perl/Makefile.inc tests PERL_THREADED against
 "true" but
 /usr/src/gnu/usr.bin/perl/library/Makefile tests it against "yes"
 /etc/defaults/make.conf suggests "true"
 
 
 -Pat
 
State-Changed-From-To: open->closed 
State-Changed-By: tobez 
State-Changed-When: Wed Aug 29 10:08:49 PDT 2001 
State-Changed-Why:  
We have no PERL_THREADED any longer. 

http://www.FreeBSD.org/cgi/query-pr.cgi?pr=19367 
>Unformatted:
