From nobody@FreeBSD.ORG  Tue Jun 13 09:29:20 2000
Return-Path: <nobody@FreeBSD.ORG>
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 2E88F37C120; Tue, 13 Jun 2000 09:29:19 -0700 (PDT)
Message-Id: <20000613162919.2E88F37C120@hub.freebsd.org>
Date: Tue, 13 Jun 2000 09:29:19 -0700 (PDT)
From: pmgleitz@research.att.com
Sender: nobody@FreeBSD.ORG
To: freebsd-gnats-submit@FreeBSD.org
Subject: Poor error message when fetching files with active mode ftp fails in bsd.port.mk.
X-Send-Pr-Version: www-1.0

>Number:         19246
>Category:       misc
>Synopsis:       Poor error message when fetching files with active mode ftp fails in bsd.port.mk.
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    portmgr
>State:          closed
>Quarter:        
>Keywords:       
>Date-Required:  
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jun 13 09:30:02 PDT 2000
>Closed-Date:    Mon May 05 22:17:13 PDT 2003
>Last-Modified:  Mon May 05 22:17:13 PDT 2003
>Originator:     Peter Gleitz
>Release:        3.4-STABLE
>Organization:
Research
>Environment:
FreeBSD britten.research.att.com 3.4-STABLE FreeBSD 3.4-STABLE #0: Mon Jan 31 16:48:10 EST 2000     pmgleitz@britten.research.att.com:/usr/cvsrc/src/sys/compile/PMG_KERNEL_1  i386

>Description:
I first ran into this when trying to build  a kame application with
bsd.port.mk, but the problem probably should be corrected in other
makefiles.

I run from behind a firewall that only permits passive mode ftp. When 
the make tries to fetch files from various repositories, /usr/bin/fetch
fails to open the data channel in active mode ftp and after timing out
moves on to the next repository, where it fails again for the same reason.

At the end of this doomed iteration over repositories, the make gives up
and advises fetching the files by hand. It seems to me this error message
could be slightly more informative, perhaps advising that /etc/make.conf
has an FTP_PASSIVE_MODE flag  that should be investigated.

The message you presently get is:
	${ECHO_MSG} ">> Couldn't fetch it - please try to retrieve this";\
			${ECHO_MSG} ">> port manually into ${_DISTDIR} and try again."; \

Surely this could be expanded to suggest the possibility of setting the 
passive mode flags before having to deal with the painful alternative
of hand fetching.

As another possibility, the script might also be made smart enough
to realize what has happened and either recover from the failure
by setting passive mode or at least advising with an appropriate
message about /etc/make.conf


When I run an active mode ftp fetch from the command line, after a 
fashion, I get:

PORT command successful.
Sending: RETR sendmail893+3.2W.patch.gz
Can't build data connection: Operation timed out.
fetch: ftp://ftp.kyoto.wide.ad.jp//pub/mail/sendmail/sendmail893+3.2W.patch.gz: FTP error:
fetch: Can't open data connection

and surely this would be easy enough to parse and decide that a passive
mode ftp would surely be more likely to succeed, so why not have the script
say so.
>How-To-Repeat:

>Fix:
See full description for two suggestions.

>Release-Note:
>Audit-Trail:
Responsible-Changed-From-To: freebsd-bugs->freebsd-ports 
Responsible-Changed-By: johan 
Responsible-Changed-When: Fri Aug 11 15:13:44 PDT 2000 
Responsible-Changed-Why:  
This is a bsd.port.mk problem. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=19246 
Responsible-Changed-From-To: freebsd-ports->asami 
Responsible-Changed-By: sobomax 
Responsible-Changed-When: Tue Mar 13 08:32:03 PST 2001 
Responsible-Changed-Why:  
bsd.port.mk is a asami's land. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=19246 
Responsible-Changed-From-To: asami->portmgr 
Responsible-Changed-By: will 
Responsible-Changed-When: Wed Apr 4 01:13:06 PDT 2001 
Responsible-Changed-Why:  
Over to new maintainer. 

http://www.freebsd.org/cgi/query-pr.cgi?pr=19246 

From: Tim Kientzle <kientzle@acm.org>
To: freebsd-gnats-submit@FreeBSD.org, pmgleitz@research.att.com,
	portmgr@FreeBSD.org
Cc:  
Subject: Re: misc/19246: Poor error message when fetching files with active mode ftp fails in bsd.port.mk.
Date: Fri, 01 Feb 2002 15:45:53 -0800

 Is there any reason to not simply change FETCH_CMD
 in bsd.port.mk to _always_ use passive-mode FTP?
 That would certainly solve the problem; the current
 setting means that people serious about network
 security can't really use the ports system at all.
 
 Tim Kientzle, kientzle@acm.org
 
State-Changed-From-To: open->suspended 
State-Changed-By: kris 
State-Changed-When: Fri Aug 30 22:15:25 PDT 2002 
State-Changed-Why:  
Awaiting patch to implement requested behaviour 

http://www.freebsd.org/cgi/query-pr.cgi?pr=19246 
State-Changed-From-To: suspended->closed 
State-Changed-By: kris 
State-Changed-When: Mon May 5 22:17:03 PDT 2003 
State-Changed-Why:  
Timeout awaiting patch 

http://www.freebsd.org/cgi/query-pr.cgi?pr=19246 
>Unformatted:
